mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: AngeloGioacchino Del Regno  <angelogioacchino.delregno@collabora.com>
To: "Nancy.Lin" <nancy.lin@mediatek.com>,
	Rob Herring <robh+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Chun-Kuang Hu <chunkuang.hu@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	wim@linux-watchdog.org, linux@roeck-us.net
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	"jason-jh . lin" <jason-jh.lin@mediatek.com>,
	Yongqiang Niu <yongqiang.niu@mediatek.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org,
	dri-devel@lists.freedesktop.org, llvm@lists.linux.dev,
	singo.chang@mediatek.com, srv_heupstream@mediatek.com,
	Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [RESEND v13 07/22] soc: mediatek: mmsys: specify 64BIT dependency for MTK_MMSYS
Date: Tue, 8 Mar 2022 14:41:59 +0100	[thread overview]
Message-ID: <d6fa28ef-fdbb-2b6c-acaa-4c35bb631ab4@collabora.com> (raw)
In-Reply-To: <20220308093018.24189-8-nancy.lin@mediatek.com>

Il 08/03/22 10:30, Nancy.Lin ha scritto:
> Because mtk-mutex change to use unsigned long mutex module type,
> it should depend 64BIT. This is a preparation for adding support for
> mt8195 vdosys1 mutex.
> 
> Signed-off-by: Nancy.Lin <nancy.lin@mediatek.com>
> ---
>   drivers/soc/mediatek/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/soc/mediatek/Kconfig b/drivers/soc/mediatek/Kconfig
> index fdd8bc08569e..24f792c46444 100644
> --- a/drivers/soc/mediatek/Kconfig
> +++ b/drivers/soc/mediatek/Kconfig
> @@ -68,6 +68,7 @@ config MTK_SCPSYS_PM_DOMAINS
>   config MTK_MMSYS
>   	bool "MediaTek MMSYS Support"
>   	default ARCH_MEDIATEK
> +	depends on 64BIT
>   	depends on HAS_IOMEM
>   	help
>   	  Say yes here to add support for the MediaTek Multimedia

Breaking old platforms is forbidden.

MT2701 and MT7623N are 32-bit ARM SoCs and:
- mt2701 needs mmsys only; but
- mt7623n needs mmsys and mutex.

Besides, this is an easy fix: just change your unsigned long to a fixed size u64.

       reply	other threads:[~2022-03-08 13:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220308093018.24189-1-nancy.lin@mediatek.com>
     [not found] ` <20220308093018.24189-8-nancy.lin@mediatek.com>
2022-03-08 13:41   ` AngeloGioacchino Del Regno [this message]
     [not found] ` <20220308093018.24189-23-nancy.lin@mediatek.com>
2022-03-08 13:43   ` [RESEND v13 22/22] arm64: dts: mt8195: add display node for vdosys1 AngeloGioacchino Del Regno
     [not found] ` <20220308093018.24189-2-nancy.lin@mediatek.com>
2022-03-08 13:43   ` [RESEND v13 01/22] dt-bindings: mediatek: add vdosys1 RDMA definition for mt8195 AngeloGioacchino Del Regno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d6fa28ef-fdbb-2b6c-acaa-4c35bb631ab4@collabora.com \
    --to=angelogioacchino.delregno@collabora.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=airlied@linux.ie \
    --cc=chunkuang.hu@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jason-jh.lin@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux@roeck-us.net \
    --cc=llvm@lists.linux.dev \
    --cc=matthias.bgg@gmail.com \
    --cc=nancy.lin@mediatek.com \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=singo.chang@mediatek.com \
    --cc=srv_heupstream@mediatek.com \
    --cc=wim@linux-watchdog.org \
    --cc=yongqiang.niu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®