mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tyler Baicar <tbaicar@codeaurora.org>
To: Xie XiuQi <xiexiuqi@huawei.com>,
	catalin.marinas@arm.com, will.deacon@arm.com, mingo@redhat.com,
	mark.rutland@arm.com, ard.biesheuvel@linaro.org,
	james.morse@arm.com, Dave.Martin@arm.com,
	takahiro.akashi@linaro.org, stephen.boyd@linaro.org, bp@suse.de,
	julien.thierry@arm.com, shiju.jose@huawei.com,
	zjzhang@codeaurora.org
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
	wangxiongfeng2@huawei.com, zhengqiang10@huawei.com,
	gengdongjiu@huawei.com, huawei.libin@huawei.com,
	wangkefeng.wang@huawei.com, lijinyue@huawei.com,
	guohanjun@huawei.com, hanjun.guo@linaro.org,
	cj.chengjian@huawei.com
Subject: Re: [PATCH v4 0/4] arm64/ras: support sea error recovery
Date: Thu, 25 Jan 2018 12:11:09 -0500	[thread overview]
Message-ID: <d6fb667b-402c-00df-fc56-1252261fbbe1@codeaurora.org> (raw)
In-Reply-To: <1506516620-20033-1-git-send-email-xiexiuqi@huawei.com>

Hello Xie,


On 9/27/2017 8:50 AM, Xie XiuQi wrote:
> With ARM v8.2 RAS Extension, SEA are usually triggered when memory errors
> are consumed. According to the existing process, errors occurred in the
> kernel, leading to direct panic, if it occurred the user-space, we should
> just kill process.
>
> But there is a class of error, in fact, is not necessary to kill
> process, you can recover and continue to run the process. Such as
> the instruction data corrupted, where the memory page might be
> read-only, which is has not been modified, the disk might have the
> correct data, so you can directly drop the page, ant reload it when
> necessary.
>
> So this patchset is just try to solve such problem: if the error is
> consumed in user-space and the error occurs on a clean page, you can
> directly drop the memory page without killing process.
>
> If the corrupted page is clean, just dropped it and return to user-space
> without side effects. And if corrupted page is dirty, memory_failure()
> will send SIGBUS with code=BUS_MCEERR_AR. While without this patchset,
> do_sea() will just send SIGBUS, so the process was killed in the same place.
>
> Because memory_failure() may sleep, we can not call it directly in SEA
> exception context. So we saved faulting physical address associated with
> a process in the ghes handler and set __TIF_SEA_NOTIFY. When we return
> from SEA exception context and get into do_notify_resume() before the
> process running, we could check it and call memory_failure() to do
> recovery. It's safe, because we are in process context.
>
> In some platform, when SEA triggerred, physical address could be reported
> by memory section or by processor section, so we save address at this two
> place.
For this series - Tested-by: Tyler Baicar <tbaicar@codeaurora.org>

Note that this will probably need to be rebased on top of these patches:

https://patchwork.codeaurora.org/patch/415877/
https://patchwork.codeaurora.org/patch/415879/

With that, the first patch should be able to be removed because the above 
patches already define the ARM error types:

+#define CPER_ARM_CACHE_ERROR            0
+#define CPER_ARM_TLB_ERROR            1
+#define CPER_ARM_BUS_ERROR            2
+#define CPER_ARM_VENDOR_ERROR            3

Thanks,
Tyler

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.

  parent reply	other threads:[~2018-01-25 17:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-27 12:50 Xie XiuQi
2017-09-27 12:50 ` [PATCH v4 1/4] ACPI, CPER: add arm error info type definition Xie XiuQi
2017-09-27 12:50 ` [PATCH v4 2/4] arm64/ras: support sea error recovery Xie XiuQi
2017-09-27 12:50 ` [PATCH v4 3/4] GHES: add a notify chain for process memory section Xie XiuQi
2017-09-27 12:50 ` [PATCH v4 4/4] arm64/ras: save error address from memory section for recovery Xie XiuQi
2018-01-25 17:11 ` Tyler Baicar [this message]
2018-01-26  2:09   ` [PATCH v4 0/4] arm64/ras: support sea error recovery Xie XiuQi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d6fb667b-402c-00df-fc56-1252261fbbe1@codeaurora.org \
    --to=tbaicar@codeaurora.org \
    --cc=Dave.Martin@arm.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=bp@suse.de \
    --cc=catalin.marinas@arm.com \
    --cc=cj.chengjian@huawei.com \
    --cc=gengdongjiu@huawei.com \
    --cc=guohanjun@huawei.com \
    --cc=hanjun.guo@linaro.org \
    --cc=huawei.libin@huawei.com \
    --cc=james.morse@arm.com \
    --cc=julien.thierry@arm.com \
    --cc=lijinyue@huawei.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=shiju.jose@huawei.com \
    --cc=stephen.boyd@linaro.org \
    --cc=takahiro.akashi@linaro.org \
    --cc=wangkefeng.wang@huawei.com \
    --cc=wangxiongfeng2@huawei.com \
    --cc=will.deacon@arm.com \
    --cc=xiexiuqi@huawei.com \
    --cc=zhengqiang10@huawei.com \
    --cc=zjzhang@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®