Re: [PATCH 3/3] hwrng: Don't default to HW_RANDOM when UML_RANDOM is the trigger

[Dragan Simic <dsimic@manjaro.org>]

On 2025-02-09 10:54, Herbert Xu wrote:
> On Sun, Feb 09, 2025 at 10:37:52AM +0100, Dragan Simic wrote:
>> 
>> Could you, please, clarify why we need(ed) the defaults at all?
>> Also, I'm a bit puzzled about what would be the defaults that are
>> actually needed?  Are you actually referring to what I proposed
>> in my earlier response? [1]  I'd appreciate a clarification.
> 
> In general there shouldn't be any default.  The only exception
> would be perhaps for embedded boards where the RNG is always
> present given the dependencies.  But in that case the default
> should be conditional on the dependency (or perhaps the whole
> config should become unconditional).
> 
> The current defaults are mostly there for historical reasons.

Thanks for the clarification.

I think it would be the best to get rid of the current defaults
in the drivers/char/hw_random/Kconfig file entirely, together with
updating as many of the affected arch/*/configs/*_defconfig files
as possible to select the relevant HW_RANDOM_* config option(s)
whenever that's a sane thing to do.

Such an approach should be both proper and least disruptive.