From: "André Draszik" <andre.draszik@linaro.org>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: linux-kernel@vger.kernel.org, krzysztof.kozlowski@linaro.org,
alim.akhtar@samsung.com, gregkh@linuxfoundation.org,
jirislaby@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v2] tty: serial: samsung_tty: remove dead code
Date: Wed, 25 Oct 2023 12:22:03 +0100 [thread overview]
Message-ID: <d6fdf664bd18eee581a2644e376124e830633045.camel@linaro.org> (raw)
In-Reply-To: <20231024215509.ak4jbbahw2vsahs6@zenone.zhora.eu>
Hi Andi,
On Tue, 2023-10-24 at 23:55 +0200, Andi Shyti wrote:
> Hi Andre,
>
> On Thu, Oct 19, 2023 at 11:09:01AM +0100, André Draszik wrote:
> > When support for various old platforms was removed in commit
> > 1ea35b355722 ("ARM: s3c: remove s3c24xx specific hacks"),
> > s3c24xx_serial_ops also became unused here because nothing sets
> > port
> > type TYPE_S3C24XX anymore.
> >
> > Remove s3c24xx_serial_ops and all the code that's unreachable now.
> >
> > Fixes: 1ea35b355722 ("ARM: s3c: remove s3c24xx specific hacks")
>
> is this really a fix? Or is it a cleanup?
I guess from my position it's fixing the issue of dead code, introduced
in the commit referenced. Which is of course also a cleanup :-)
Not sure...
Cheers,
Andre
prev parent reply other threads:[~2023-10-25 11:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 10:09 André Draszik
2023-10-19 14:30 ` Sam Protsenko
2023-10-24 21:55 ` Andi Shyti
2023-10-25 11:22 ` André Draszik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6fdf664bd18eee581a2644e376124e830633045.camel@linaro.org \
--to=andre.draszik@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=andi.shyti@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®