From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D85A31770E for ; Tue, 9 Sep 2025 10:56:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757415363; cv=none; b=aOrNttmjN14FrjFygrAYgHpLQAOVYvabucdhxU0LFVsv/+XywaqpBF2fBmBKIwCPAayBdxyQZSJC8YL/5LNVu9/GVN3a1siLb+zgdFvGwZUk18HF1IVznmEgzCOsirXwuI3vZf+8dCnL6I9ALXRkJdlSA+qBhX2JOcG0MW0q4H4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757415363; c=relaxed/simple; bh=P+FQuJhA1PrMmXPlKv+nsJEpTrgwiKcfidU0cZC6Aa4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fmhTuIo32bG5qMjE4l/9H1xlQ/SjKl6BRWgdhfN1xdVoYvTL4c6x8//O9YzSXpdLq3ALSJmWuQaYseWhattKiGwjP76O4F5G8Skzw9wRtJaHocyPbY5whiv3MGAFxhq8H+aUp0pWK9GmZiS9aI91zZLz8AxSzs/VRRXUTt4eAsg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Qoq4x5pF; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Qoq4x5pF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757415361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9T1K7vaX+eZEVLfGul1pBfoS3Sr2T++RNF7So0hyGuo=; b=Qoq4x5pFUGU1DykoFGTXoEO2idhvA2xzWejA//KVtC1m3k7lmMMrjEfxCOath5aZGXAP4v kK8DPAj+J0KVpln3nIQLps5jqmMcX41I7cMvuuCr/SQIHUhV8BJEFnT+dkdnlnqOULffOB cuoixur8veIJNZfK4w2EsFj3yT7VUK0= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-658-Pp9S4I42McKxWfjJ4APQCQ-1; Tue, 09 Sep 2025 06:55:59 -0400 X-MC-Unique: Pp9S4I42McKxWfjJ4APQCQ-1 X-Mimecast-MFC-AGG-ID: Pp9S4I42McKxWfjJ4APQCQ_1757415358 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3cf12498799so3257884f8f.2 for ; Tue, 09 Sep 2025 03:55:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757415358; x=1758020158; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9T1K7vaX+eZEVLfGul1pBfoS3Sr2T++RNF7So0hyGuo=; b=lOp6d5dzD7L2toDgWZVFFduT2O0zeigU+YIfd5PF5YLclGcZwJkypGpBZH0hrgDmoE QkQAj9GRzIYn/Pok1yIYo17wcYZqkVdXRU2frpYLMZ4fW5Zjq0+dl82NasW6Q3eoLU15 wOSe+gdhV+u1V55bT2cXfcSSLi1gaiV6DNPzenJlSjwQxzh7mb4SNF58czdvkfduHG9i m34r16kKWLwYeo9R2xdskRdZ+fJSwL7cJeKCRW/t8TyqrQyE5ddNHlR8vL3gmYLfnXKR cCAhOKTWkfXwK8lysoC8Gf0xyAbzjHrUqJqzZrmbQ7zfs8xsuO1oZf5JD9CSYPM2NnAS uf3g== X-Forwarded-Encrypted: i=1; AJvYcCW8J61H8wEaURKApI4XWyuub94r1BY8p5s3lcYBz0XHjqOU8oG4DHN8LGMd2ceUOTn23EELZm+finl9l5s=@vger.kernel.org X-Gm-Message-State: AOJu0YzgS+4N4sAYuwCAVNzQY/NKr1AwLpLLqckTvuH7K0cKOxDZCPIe AKbn8MFDMDjasqIMMJPOAaD91Z7Baz98q0+JphoTZrj/qhhiTZz+VZlwhCRzwTf8F2yPVlxWOwC hK48+hQTiP6n0IlNy7M1UE2UeMmCip95dAhHUkggyVM7T0lrSyFve1tHlXQGWKlPcrg== X-Gm-Gg: ASbGncvmW5uuuxR+NmZyLff0ZJMjJDEzGw6YIOwpf7nmFfBQyetvojLMneNJQsHOrPz eINdsdMpWsAHxlD0IXWTPabb91qAENTZq9CnKcH8vrwSsPh3/8KttymdwMFcOzW1bNWvENETZNq WQmB/chMXoPfc49wCxq5vR46kkOAI8+i4bSYK6JvG1Xql7F9mmzX4mj2Ql4SxACnoOuQQlnZAZx 9D4JHMNpCUdOZWEumdnEnXOoA7NhZ2jZfmgaXCk7ecn4ysCTvHSINOPC6a+N8xPo20BaIegE1aI JYqhMMcpsViqGXOYKei1bQTtB4FPIm6l2Ewkd4O0BRmP/vUf0CiIDlpogz3HJi++esTDqws22JB Z1L1KkdDTxTw= X-Received: by 2002:a05:6000:2383:b0:3d9:70cc:6dce with SMTP id ffacd0b85a97d-3e641e3ac00mr9036207f8f.12.1757415357956; Tue, 09 Sep 2025 03:55:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEnmvFRwe+aQHJSfIB96YNcsk+I5KT04KIyycuSAFbcSbi1qXb6O4cvvbjLLpNmJLmEpECY3Q== X-Received: by 2002:a05:6000:2383:b0:3d9:70cc:6dce with SMTP id ffacd0b85a97d-3e641e3ac00mr9036184f8f.12.1757415357529; Tue, 09 Sep 2025 03:55:57 -0700 (PDT) Received: from ?IPV6:2a0d:3344:2712:7e10:4d59:d956:544f:d65c? ([2a0d:3344:2712:7e10:4d59:d956:544f:d65c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e75224eb27sm2177631f8f.62.2025.09.09.03.55.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Sep 2025 03:55:57 -0700 (PDT) Message-ID: Date: Tue, 9 Sep 2025 12:55:55 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v2] rds: ib: Increment i_fastreg_wrs before bailing out To: =?UTF-8?Q?H=C3=A5kon_Bugge?= , Allison Henderson , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Simon Horman Cc: stable@vger.kernel.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org References: <20250904115030.3940649-1-haakon.bugge@oracle.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20250904115030.3940649-1-haakon.bugge@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 9/4/25 1:50 PM, Håkon Bugge wrote: > We need to increment i_fastreg_wrs before we bail out from > rds_ib_post_reg_frmr(). > > Fixes: 1659185fb4d0 ("RDS: IB: Support Fastreg MR (FRMR) memory registration mode") > Fixes: 3a2886cca703 ("net/rds: Keep track of and wait for FRWR segments in use upon shutdown") > Cc: stable@vger.kernel.org > Signed-off-by: Håkon Bugge whoops, I replied to v1 by mistake: https://lore.kernel.org/netdev/d918e832-c2ef-4fc8-864f-407bbcf06073@redhat.com/T/#mb92f279c773d443313f9e0951a2107060078802c But the comments apply here as well. Thanks, Paolo