From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 337991F9F70 for ; Thu, 9 Oct 2025 09:45:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760003135; cv=none; b=dFfo8Wn7yilZ9Ecr4+NsHMfIGbvb27mGAZyr0qF2q/GvQJ5vBwJYcaBBEXq2w9UFiEG3lR2ShmNbwIqh91KSwbuPT6lsBBNLoJVl8X16FEV/8lxZYi5pMX59ta5TEfkNShtq0s2rwxCsA4fbGTrSpgDDk4jLSsHF+HHhkP2sCAc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760003135; c=relaxed/simple; bh=+WuDGN8PwcdrONCswSpy1/6ukiYeOjoibZ5/S2bBspg=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=gvZ+DSCJpRbyZNoZd/fVroLi7/sR1r8c/Ndofgnwb/hKnAoQgDXN+fctahN0XWbPI8EO5Z7oyRljHAoZGS3nt8GzynLi2CyoxsgPoLZzbEQX09VFT4z44CWKS18qfaXdQjQaxY1y2i5XaGyTyDnUVlM3MZmK0JR9f7JKLbYNIME= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=UxUQai9i; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UxUQai9i" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-46e6ba26c50so3890835e9.2 for ; Thu, 09 Oct 2025 02:45:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760003130; x=1760607930; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=kbUfqJ5j71TBp7MjjYEvcsqbYwQhLnnJoyZYmO0oJ5k=; b=UxUQai9iq93UYEy41EkcG5ATrh5c0sEfQTlsHTCiJBy4C0lpiEeXXh47K2ybloq0dm F/I9ddMEPBHVtDbAJOlXznJyV3XFnnobXmhbuRhwFdtfblYBDWAacu2EQmmFBf4AsNA5 6RvkDufSOyzkazZgkrPNuPu/2fX9lfionzW551Qwp54/QPjHcugo+1HjRIsZRtOuEO5I ZKBunuAK2MmTacqZSKEmi40onuw7D8qjRtXyY5x6cmOVM15RKZNmz9hePCPejHmI4R6l kfeAaKzaBeU6ojwvyyU7aXqYjUF19/WGnWNLGr9QufysHxHmWrNdPSuB+lFAnVlC1p5J eNhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760003130; x=1760607930; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=kbUfqJ5j71TBp7MjjYEvcsqbYwQhLnnJoyZYmO0oJ5k=; b=qDIF/VaIQwFUP2SE0Or0l5S7WJCnlmxUBIGR/HNprDuLHVJxENdNR+JnBbQFCVPI7w jMxYfLWVM87RyMPrwCCWAXXCykqoFLiPvom3gRAUpHJhUrqn83Bl9l7uOSrO9+eSnady lKukJh+GPBVvhCg47GdLHB0oiYVxIAOOc1p5x/cp50KAwi+1Zj9yX+XV0yIlfXITc9AS NRDIlqe9Jc16wQcYVJf4ef/LxJYzFm8MUOayF70P2cJenmgDmhDza2qhYOPU0oSxSOp0 cI5U8Z1IC0HdFVuQMzisug7cLwQyQZmUFqnNNhcJ28fUKqo8n/0GE9BXM3eB9TBrs+Kr JaGA== X-Forwarded-Encrypted: i=1; AJvYcCXND6FozI+vx04d9J50N7172vhxU9mZoggU6/Ik1ZR2tVpw9ciUYG/QxyyVulj/hOYWUIr0AFBsLQ5w8to=@vger.kernel.org X-Gm-Message-State: AOJu0YwR7NqRkr67UO4ae1u23c8LIdj7hAyY5WNOMYmC5ojhpzD3TqJ8 6Gay50G1tuYUb+RtHXBTEAin72p0gRN8ymgtDt0Etj/M2wW0y12K1Fpks7+dAL2tAtw= X-Gm-Gg: ASbGncurWVQqP1/mapZw2uW/wKB8jDdFgISCmHulf4OQPq93j/aekE6YKGjkVt1rW12 UMfFBVgGuE+1K2fE6vmyGBZvBdeVEJ6HVWsw0AlY8RhPZiWB0SMDIdm7s0DZaFOJ7D+2IjhTg86 wQyz27LzFXinrdBMVbip981YkyfuZdO4WnVMmaz9S2jjz1Y526FWtXVCridtZtDYdfl0/lWWMD3 QulEsbIgjy5tIByo4BMIRSrPCk+WXG9hJG6cxopcraGtkg2dhmAmz0NyqNPzGldy2W3EpBsLmLy Pka6iEkVsn+ycmhN0UN7zKyIpWCGgAiTxhNwHG7PqIgUVSa8Vi49blgZBgUM6kIpRKdihCRpb9X wzTylcD0DWRKs3kUbCa56PUs2EtP0jmn2nv4f9v2NKH35RjhWzFKZzLMjqfX8d1TLwkyLCH5h63 6Y1P0aESGOXvbouypr7A6e4XciIfU= X-Google-Smtp-Source: AGHT+IFO8IRDk5imUegHSmbnk/EmeFggjgdJn5I9b3H8USmPMbWmI4oj5AxEVR/9edpf44w240UrcQ== X-Received: by 2002:a05:600c:1d1a:b0:46e:3978:ba71 with SMTP id 5b1f17b1804b1-46fa9aefedemr45680875e9.21.1760003130336; Thu, 09 Oct 2025 02:45:30 -0700 (PDT) Received: from ?IPV6:2a01:e0a:3d9:2080:7a0c:da2f:6591:67ee? ([2a01:e0a:3d9:2080:7a0c:da2f:6591:67ee]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46fa9b622cdsm76319065e9.0.2025.10.09.02.45.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Oct 2025 02:45:29 -0700 (PDT) Message-ID: Date: Thu, 9 Oct 2025 11:45:28 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH RFC v2 3/6] ASoC: soc: qcom: sc8280xp: add support for I2S clocks To: Konrad Dybcio , Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20251008-topic-sm8x50-next-hdk-i2s-v2-0-6b7d38d4ad5e@linaro.org> <20251008-topic-sm8x50-next-hdk-i2s-v2-3-6b7d38d4ad5e@linaro.org> <630bb2b0-0ab4-4083-96a2-9aa485041797@oss.qualcomm.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <630bb2b0-0ab4-4083-96a2-9aa485041797@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/9/25 11:41, Konrad Dybcio wrote: > On 10/8/25 8:56 PM, Neil Armstrong wrote: >> Add support for getting the I2S clocks used for the MI2S >> interfaces, and enable/disable the clocks on the PCM >> startup and shutdown card callbacks. >> >> The rate can be easily calculated since the card forces 48Hz, >> 2 channels at 16bit slot size. >> >> Signed-off-by: Neil Armstrong >> --- > > [...] > >> +static int sc8280xp_snd_i2s_index(struct snd_soc_dai *dai) >> +{ >> + switch (dai->id) { >> + case PRIMARY_MI2S_RX...PRIMARY_MI2S_TX: > > I have mixed feelings about the range syntax here.. it's only 2 entries > per and it's quite error-prone (no errors in this case, but it > encourages the thinking that things are always contiguous).. > > [...] > >> switch (cpu_dai->id) { >> case PRIMARY_MI2S_RX...QUATERNARY_MI2S_TX: >> case QUINARY_MI2S_RX...QUINARY_MI2S_TX: > > whereas e.g. here we see that it's not really the case, but it's > tempting for someone trying to 'clean up' the code to change it to: > > case PRIMARY_MI2S_RX...QUINARY_MI2S_TX > > and the reviewers may not catch it I understand your point, but I just took what was already in the file... Is my change correct, yes, is the style of the code improvable, yes. I'll do my best to fix the style issue later on. Neil > > Konrad