From: Daniel Golle <daniel@makrotopia.org>
To: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "Benny (Ying-Tsan) Weng" <yweng@maxlinear.com>,
Avinash Jayaraman <ajayaraman@maxlinear.com>,
Bing tao Xu <bxu@maxlinear.com>,
Juraj Povazanec <jpovazanec@maxlinear.com>,
"Fanni (Fang-Yi) Chan" <fchan@maxlinear.com>,
"Livia M. Rosu" <lrosu@maxlinear.com>,
John Crispin <john@phrozen.org>
Subject: [PATCH net-next] net: phy: intel-xway: workaround stale LEDs before link-up
Date: Thu, 15 Jan 2026 23:40:38 +0000 [thread overview]
Message-ID: <d70a1fa9b92c7b3e7ea09b5c3216d77a8fd35265.1768432653.git.daniel@makrotopia.org> (raw)
Due to a bug in some PHY internal firmware, manual control as well as
polarity configuration of the PHY LEDs has no effect until a link has
been detected at least once after reset. Apparently the LED control
thread is not started until then.
As a workaround, clear the BMCR_ANENABLE bit for 100ms to force the
firmware to start the LED thread, allowing manual LED control and
respecting LED polarity before the first link comes up.
In case the legacy default LED configuration is used the bug isn't
visible, so only apply the workaround in case LED configuration is
present in the device tree.
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
---
drivers/net/phy/intel-xway.c | 28 +++++++++++++++++++++++++++-
1 file changed, 27 insertions(+), 1 deletion(-)
diff --git a/drivers/net/phy/intel-xway.c b/drivers/net/phy/intel-xway.c
index 9766dd99afaa0..37150115c8edb 100644
--- a/drivers/net/phy/intel-xway.c
+++ b/drivers/net/phy/intel-xway.c
@@ -4,6 +4,7 @@
* Copyright (C) 2016 Hauke Mehrtens <hauke@hauke-m.de>
*/
+#include <linux/delay.h>
#include <linux/mdio.h>
#include <linux/module.h>
#include <linux/phy.h>
@@ -286,8 +287,33 @@ static int xway_gphy_config_init(struct phy_device *phydev)
return err;
/* Use default LED configuration if 'leds' node isn't defined */
- if (!of_get_child_by_name(np, "leds"))
+ if (!of_get_child_by_name(np, "leds")) {
xway_gphy_init_leds(phydev);
+ } else {
+ /* Due to a bug in some PHY internal firmware, manual control
+ * as well as polarity configuration of the PHY LEDs has no
+ * effect until a link has been detected at least once after
+ * reset. Apparently the LED control thread is not started
+ * until then.
+ *
+ * Workaround: clear the BMCR_ANENABLE bit to force the firmware
+ * to start the LED thread, allowing manual LED control and
+ * respecting LED polarity before the first link comes up.
+ *
+ * In case the default LED configuration is used the bug isn't
+ * visible, so only apply the workaround in case LED
+ * configuration is present in the device tree.
+ */
+ phy_clear_bits(phydev, MII_BMCR, BMCR_ANENABLE);
+ /* 100ms was found to be required by experimentation.
+ * A shorter delay causes other (serious) bugs...
+ */
+ msleep(100);
+ /* It turns out BMCR_ANENABLE *has* to be set when removing
+ * BMCR_PDOWN for not facing yet different bugs
+ */
+ phy_set_bits(phydev, MII_BMCR, BMCR_ANENABLE);
+ }
/* Clear all pending interrupts */
phy_read(phydev, XWAY_MDIO_ISTAT);
--
2.52.0
next reply other threads:[~2026-01-15 23:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 23:40 Daniel Golle [this message]
2026-01-16 1:23 ` Andrew Lunn
2026-01-16 2:06 ` Daniel Golle
2026-01-18 2:29 ` [net-next] " Jakub Kicinski
2026-01-18 2:31 ` Jakub Kicinski
2026-01-18 2:33 ` Daniel Golle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d70a1fa9b92c7b3e7ea09b5c3216d77a8fd35265.1768432653.git.daniel@makrotopia.org \
--to=daniel@makrotopia.org \
--cc=ajayaraman@maxlinear.com \
--cc=andrew@lunn.ch \
--cc=bxu@maxlinear.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fchan@maxlinear.com \
--cc=hkallweit1@gmail.com \
--cc=john@phrozen.org \
--cc=jpovazanec@maxlinear.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lrosu@maxlinear.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yweng@maxlinear.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®