From: "Simon Wang (王传国)" <wangchuanguo@inspur.com>
To: SeongJae Park <sj@kernel.org>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"hannes@cmpxchg.org" <hannes@cmpxchg.org>,
"david@redhat.com" <david@redhat.com>,
"mhocko@kernel.org" <mhocko@kernel.org>,
"zhengqi.arch@bytedance.com" <zhengqi.arch@bytedance.com>,
"shakeel.butt@linux.dev" <shakeel.butt@linux.dev>,
"lorenzo.stoakes@oracle.com" <lorenzo.stoakes@oracle.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"damon@lists.linux.dev" <damon@lists.linux.dev>
Subject: Re: [PATCH 0/2] add a knob to control whether to use other nodes at the same tier of the target node in DAMON
Date: Thu, 29 May 2025 03:14:00 +0000 [thread overview]
Message-ID: <d70d2cc058fc4a588720076200c81214@inspur.com> (raw)
> Thank you for sending this patch series!
>
> On Wed, 28 May 2025 19:10:36 +0800 wangchuanguo
> <wangchuanguo@inspur.com> wrote:
>
> > In DAMON's migrate_hot and migrate_cold features, the code was
> > intended to migrate pages only to the node specified by target_nid.
> > However, during testing, it was observed that memory allocation and
> > migration could occur on any nodes, which is a BUG.
> > The first patch in this PR fix this issue.
> >
> > A use_nodes_of_tier file has been added under the directory
> > /sys/kernel/mm/damon/admin/kdamonds/<N>/contexts/<N>/schemes/<N>/
> > to control whether to use other nodes in the same tier as the target
> > node for migration.
>
> I left a few comments on the patches. Looking forward to discussions on
> each sub-thread :)
>
> >
> > wangchuanguo (2):
>
> I believe your name is Wang Chuanguo? Sorry if I read/wrote it wrongly.
> But we disallow[1] anonymous contributions, and prefer more formal
> Signed-off-by:
> if possible. Could you please use such formal Signed-off-by: identity, say,
> "Wang Chuanguo <wangchuanguo@inspur.com>" from next time?
I'm sorry, this was my mistake. I will be more careful next time.
> [1]
> https://docs.kernel.org/process/submitting-patches.html#developer-s-certifica
> te-of-origin-1-1
>
>
> Thanks,
> SJ
>
> [...]
next reply other threads:[~2025-05-29 3:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-29 3:14 Simon Wang (王传国) [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-05-28 11:10 wangchuanguo
2025-05-28 22:39 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d70d2cc058fc4a588720076200c81214@inspur.com \
--to=wangchuanguo@inspur.com \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@kernel.org \
--cc=shakeel.butt@linux.dev \
--cc=sj@kernel.org \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®