From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6987B17A30A for ; Wed, 10 Dec 2025 04:26:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765340804; cv=none; b=mTjdX96WBqNlSU4WfiiBUfFWloz6ETgbj1q1MVZVF2T8+oOOMIlFTlWcwyY2gCVqq40Lv5ZMzu+YREh0Zb6tztCREFinVVHlC3m2ybtDI6URcYlNEiEKiS3Z9HJG9BhYQGVzNsmqga0Z0LKZKwDukqaNtarr5YFWdxitzLl3lCI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765340804; c=relaxed/simple; bh=sj+TFlLPqZ+s1w+yvXLn+DhvC+eXwCs89D5IuNhjqs4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TCpApeODq1Nnop24z4oGI/mBrhaFY3eVnw+r2+A27jhaD8W0Hq6AxaPa+zDlDCTrXB+u3rh1aXKrTKRFagCQyEInMerxQRzQOpnvEaO+S8jsRK9vQd4J0FXeaBcAwmGJUU6y4g6rcVacj4yuSJLCq0yHjq+nxRmOojpsdQzuFuE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=K3yDQEYn; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K3yDQEYn" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-3436cbb723fso5477744a91.2 for ; Tue, 09 Dec 2025 20:26:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765340803; x=1765945603; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tk/No+Mm3I+u10bIGMU4QecHhYZtSqoq4vJuDZr7ifY=; b=K3yDQEYnu9nAEUfOoQ4xYesBmvWT7Gex4NgUgyG4vwMxJ7RiJi6qwyu8NMZ8Ri0H2s HDUpyEeLvGryDc2mQg6/CSAn9xJGAhcoqkm6dobD9/tWS++tMyo8DJ1XayEG094Bllel dJxxwO+U/qxhtNQlTGor7JKaYXspfqDAo4CZ1ppVn98om8DIaENX5Z78bbcGCTTIjq3H Mr7dD17pnnuyZba8i1fUFDICYl4tbX4oI9MXWPAOKR0b+I0K06Stw8vcwnJKxHMtTHFA SIMFZ4ub0wan1+dT+6i/keL9+MGReqAug1NC7T4O7ypZxGwS+asikd9rH+4q3c8WxruH Vnwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765340803; x=1765945603; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tk/No+Mm3I+u10bIGMU4QecHhYZtSqoq4vJuDZr7ifY=; b=FIkwilMPsYuWDd40uBm+p6kkHfJfJeAsZjr+8TWf2f7x6EFBph2sLcVFjrC35LvPi2 jKDCM/Jqs+BZDBzWoBGoSM3mmIHWauO0/V6Q40fpEpYwfpgGJuTY8j1zHFERO//fXvkb MViZsup4Kpj0LMIfaz15kNQ4rwnqa6juZnsqB7FRqyJE98isdzGFWnG9gBy8jXgUlg7+ BxK8bojM4VRWKDVeUGGVgYJnekUpe0Wbo8mRicROaIAW1OwmP6J9bhKxzdtLTaL5JWm8 Ts5jg/iL7eUS3BYoLTgvF+Qx9j7rFRd8NlQri3OgXCAqsEP2f8kNj0D1stw0onu+ujXs rY0A== X-Forwarded-Encrypted: i=1; AJvYcCW+oMTnNrTxu8kBK/qYcPJlNNc3BIX3T9k3nJs4W8bzFke4KS3oHr5Ky2o6mKYIFwcopWe3q4rn71q3E5c=@vger.kernel.org X-Gm-Message-State: AOJu0Yzm9Bt4bLxnd5EVotfjEWDsW8w7I7m2WaX3gJg066tumRdQJNPV 0zxBGkoDPujSTzmWW9C5fURH9l09pWH91RFGwCUwTYzbxR4GomNiUjxp X-Gm-Gg: AY/fxX4ulUuCKiEVxjATCuarFaVLUpW891WZF0Odqs6OjGTajdMyPACSnZPjqlQ7mwH vHyEk9qCfPMqr04/IxvtLrzVf4R0Fi/uRlhzB02Ge0uidgKQHUA5QY0xBcTt7j3F/A875DmmALp gQ5qoP4WxWs96LtVWGiXHaQ0KhMP1gWIdnqQppoa8tIjFJ3V9nGt2GDDAuuEekGoHB5fUIi3E0V p9dw5Fc+09oVMNddlD7jjm24pSjMjHcj7RfXTIloaI43GzYKu/bzPtAA5kd/unCWcioXURkBI0l k5ftxeFaBAKUX/YTPFE96DcyRMycyp0NLHnj7OZKKhXg2vUwD1C9JopUMzbP8M1QCFIWpJ1c3K+ 0wK8UYusya7p0+LKgngb9tlpQ3qto2xTD0tlRTzNw/cVUTC/tkTI8N2pvSaUn9sq5RKFBYABxVc QQkOBa1EZGsgLLuS9lsUBFPi4baG/xn1ogJYQlKhvqQsZO4ey8nznFGtGvBqfpTNkZQ8oDfX0= X-Google-Smtp-Source: AGHT+IEkCPOkyg0imXvpe+yjarzV/1sk/8YYfqF82dhTlKcX5BeBSLcY5y7rsJgrq/q2KnhrIhD0uw== X-Received: by 2002:a17:90b:5252:b0:343:684c:f8ad with SMTP id 98e67ed59e1d1-34a72808b72mr1162287a91.4.1765340802654; Tue, 09 Dec 2025 20:26:42 -0800 (PST) Received: from ?IPV6:2601:1c0:5780:9200:b90d:2938:bd7a:289f? ([2601:1c0:5780:9200:b90d:2938:bd7a:289f]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34a70926cd8sm971106a91.12.2025.12.09.20.26.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Dec 2025 20:26:42 -0800 (PST) Message-ID: Date: Tue, 9 Dec 2025 20:26:41 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] fbdev: Guard sysfs interfaces under CONFIG_FB_DEVICE To: Andy Shevchenko , Helge Deller Cc: Thomas Zimmermann , linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, andy@kernel.org, gregkh@linuxfoundation.org References: <20251209042744.7875-1-chintanlike@gmail.com> <19e8a1b0-75e3-4c8d-911a-15fd70f60bea@suse.de> Content-Language: en-US From: Chintan Patel In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 12/9/25 06:25, Andy Shevchenko wrote: > On Tue, Dec 9, 2025 at 10:23 AM Helge Deller wrote: >> On 12/9/25 08:27, Thomas Zimmermann wrote: > > ... > >> This whole series adds a whole lot of ifdef'ery, which I think is the >> worst approach. It makes the code less readable and leads to two code >> paths, which may trigger different build errors depending on the config. >> >> I'm sure it must be possible to do the same without adding more #ifdefs, >> e.g. by introducing a function like dev_of_fbinfo(fbinfo) which >> simply returns NULL for the FB_DEVICE=n case. Then, that value can be tested >> like >> if (dev_of_fbinfo(fbinfo)) >> {...do-the-things...} >> For the FB_DEVICE=n case this will then be optimized out by the compiler, >> while you still have full compiler syntax checking. >> >> Thoughts? > > I second you. I am also not a fan of ifdeffery when it can be avoided. > Thank you for the review! Will do the change.