From: "Chang S. Bae" <chang.seok.bae@intel.com>
To: Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>
Cc: <x86@kernel.org>, Paolo Bonzini <bonzini@gnu.org>,
Fenghua Yu <fenghua.yu@intel.com>,
Tony Luck <tony.luck@intel.com>
Subject: Re: [patch 0/7] x86/fpu: Cure supervisor mode (ENQCMD) fallout
Date: Mon, 28 Mar 2022 05:39:02 -0700 [thread overview]
Message-ID: <d723e20a-b461-f63e-2fd1-eea91b0dddf1@intel.com> (raw)
In-Reply-To: <20220324134548.432837672@linutronix.de>
On 3/24/2022 6:47 AM, Thomas Gleixner wrote:
>
> It builds, boots on host and guest, but is not yet extensively tested.
> Testing with a AMX + PASID enabled machine has not been done at all as I
> don't have easy access to such a beast.
The AMX tests [1][2] went well on both host and guest. Also dmesg logs
look to be okay:
On host,
$ sudo dmesg | grep fpu
[ 0.000000] x86/fpu: Supporting XSAVE feature 0x001: 'x87 floating
point registers'
[ 0.000000] x86/fpu: Supporting XSAVE feature 0x002: 'SSE registers'
[ 0.000000] x86/fpu: Supporting XSAVE feature 0x004: 'AVX registers'
[ 0.000000] x86/fpu: Supporting XSAVE feature 0x020: 'AVX-512 opmask'
[ 0.000000] x86/fpu: Supporting XSAVE feature 0x040: 'AVX-512 Hi256'
[ 0.000000] x86/fpu: Supporting XSAVE feature 0x080: 'AVX-512 ZMM_Hi256'
[ 0.000000] x86/fpu: Supporting XSAVE feature 0x200: 'Protection Keys
User registers'
[ 0.000000] x86/fpu: Supporting XSAVE feature 0x400: 'PASID state'
[ 0.000000] x86/fpu: Supporting XSAVE feature 0x20000: 'AMX Tile config'
[ 0.000000] x86/fpu: Supporting XSAVE feature 0x40000: 'AMX Tile data'
[ 0.000000] x86/fpu: xstate_offset[2]: 576, xstate_sizes[2]: 256
[ 0.000000] x86/fpu: xstate_offset[5]: 832, xstate_sizes[5]: 64
[ 0.000000] x86/fpu: xstate_offset[6]: 896, xstate_sizes[6]: 512
[ 0.000000] x86/fpu: xstate_offset[7]: 1408, xstate_sizes[7]: 1024
[ 0.000000] x86/fpu: xstate_offset[9]: 2432, xstate_sizes[9]: 8
[ 0.000000] x86/fpu: xstate_offset[10]: 2440, xstate_sizes[10]: 8
[ 0.000000] x86/fpu: xstate_offset[17]: 2496, xstate_sizes[17]: 64
[ 0.000000] x86/fpu: xstate_offset[18]: 2560, xstate_sizes[18]: 8192
[ 0.000000] x86/fpu: Enabled xstate features 0x606e7, context size is
10752 bytes, using 'compacted' format.
On guest,
(AMX is available with the upstream Qemu [3].)
$ sudo dmesg | grep fpu
...
[ 0.000000] x86/fpu: Supporting XSAVE feature 0x200: 'Protection Keys
User registers'
[ 0.000000] x86/fpu: Supporting XSAVE feature 0x20000: 'AMX Tile config'
[ 0.000000] x86/fpu: Supporting XSAVE feature 0x40000: 'AMX Tile data'
...
[ 0.000000] x86/fpu: xstate_offset[9]: 2432, xstate_sizes[9]: 8
[ 0.000000] x86/fpu: xstate_offset[17]: 2496, xstate_sizes[17]: 64
[ 0.000000] x86/fpu: xstate_offset[18]: 2560, xstate_sizes[18]: 8192
[ 0.000000] x86/fpu: Enabled xstate features 0x602e7, context size is
10752 bytes, using 'compacted' format.
Thanks,
Chang
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git/tree/tools/testing/selftests/x86/amx.c?h=x86/fpu
[2]
https://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git/tree/tools/testing/selftests/kvm/x86_64/amx_test.c?h=x86/fpu
[3]
https://git.qemu.org/?p=qemu.git;a=commit;h=3d31fe4d662f13c70eb7e87f29513623ccd76322
next prev parent reply other threads:[~2022-03-28 12:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 13:47 Thomas Gleixner
2022-03-24 13:47 ` [patch 1/7] x86/fpu: Remove redundant XCOMP_BV initialization Thomas Gleixner
2022-03-31 9:01 ` [tip: x86/urgent] " tip-bot2 for Thomas Gleixner
2022-03-24 13:47 ` [patch 2/7] x86/fpu: Remove unused supervisor only offsets Thomas Gleixner
2022-03-31 9:00 ` [tip: x86/urgent] " tip-bot2 for Thomas Gleixner
2022-03-24 13:47 ` [patch 3/7] x86/fpu/xsave: Initialize offset/size cache early Thomas Gleixner
2022-03-31 9:00 ` [tip: x86/urgent] " tip-bot2 for Thomas Gleixner
2022-03-24 13:47 ` [patch 4/7] x86/fpu: Cache xfeature flags from CPUID Thomas Gleixner
2022-03-31 9:00 ` [tip: x86/urgent] " tip-bot2 for Thomas Gleixner
2022-03-24 13:47 ` [patch 5/7] x86/fpu/xsave: Handle compacted offsets correctly with supervisor states Thomas Gleixner
2022-03-31 9:00 ` [tip: x86/urgent] " tip-bot2 for Thomas Gleixner
2022-03-24 13:47 ` [patch 6/7] x86/fpu/xstate: Handle supervisor states in XSTATE permissions Thomas Gleixner
2022-03-31 9:00 ` [tip: x86/urgent] " tip-bot2 for Thomas Gleixner
2022-03-24 13:47 ` [patch 7/7] x86/fpu/xstate: Consolidate size calculations Thomas Gleixner
2022-03-28 18:43 ` [patch V2 " Thomas Gleixner
2022-03-31 9:00 ` [tip: x86/urgent] " tip-bot2 for Thomas Gleixner
2022-03-28 12:39 ` Chang S. Bae [this message]
2022-03-28 22:30 ` [patch 0/7] x86/fpu: Cure supervisor mode (ENQCMD) fallout Fenghua Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d723e20a-b461-f63e-2fd1-eea91b0dddf1@intel.com \
--to=chang.seok.bae@intel.com \
--cc=bonzini@gnu.org \
--cc=fenghua.yu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®