From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Ram Kumar Dwivedi <ram.dwivedi@oss.qualcomm.com>
Cc: mani@kernel.org, alim.akhtar@samsung.com, avri.altman@wdc.com,
bvanassche@acm.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, James.Bottomley@hansenpartnership.com,
martin.petersen@oracle.com, anjana.hari@oss.qualcomm.com,
linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 2/4] dt-bindings: ufs: Document bindings for SA8255P UFS Host Controller
Date: Wed, 31 Dec 2025 08:53:14 +0100 [thread overview]
Message-ID: <d724c6d3-0dff-43a3-827b-fdf8be2a6a0d@kernel.org> (raw)
In-Reply-To: <4mq5a4lhboymigbaruphlhip4zvmxl6xusvqrqb57bhx3yirt4@mgxdlr5onl6l>
On 31/12/2025 06:19, Dmitry Baryshkov wrote:
> On Wed, Dec 31, 2025 at 10:25:51AM +0530, Ram Kumar Dwivedi wrote:
>> Document the device tree bindings for UFS host controller on
>> Qualcomm SA8255P platform which integrates firmware-managed
>> resources.
>>
>> The platform firmware implements the SCMI server and manages
>> resources such as the PHY, clocks, regulators and resets via the
>> SCMI power protocol. As a result, the OS-visible DT only describes
>> the controller’s MMIO, interrupt, IOMMU and power-domain interfaces.
>>
>> The generic "qcom,ufshc" and "jedec,ufs-2.0" compatible strings are
>> removed from the binding, since this firmware managed design won't
>> be compatible with the drivers doing full resource management.
>>
>> Co-developed-by: Anjana Hari <anjana.hari@oss.qualcomm.com>
>> Signed-off-by: Anjana Hari <anjana.hari@oss.qualcomm.com>
>> Signed-off-by: Ram Kumar Dwivedi <ram.dwivedi@oss.qualcomm.com>
>> ---
>> .../bindings/ufs/qcom,sa8255p-ufshc.yaml | 62 +++++++++++++++++++
>> 1 file changed, 62 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/ufs/qcom,sa8255p-ufshc.yaml
>>
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>> +
>> + soc {
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>
> This didn't really improve. You don't need 'soc' node at all. Please
> drop it.
>
It was already asked by Bjorn, then I reminded that. So I wonder if
repeating three times will work?
Feels like a waste of our time if same feedback has to be repeated three
times.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-12-31 7:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-31 4:55 [PATCH V3 0/4] ufs: ufs-qcom: Add support firmware managed platforms Ram Kumar Dwivedi
2025-12-31 4:55 ` [PATCH V3 1/4] MAINTAINERS: broaden UFS Qualcomm binding file pattern Ram Kumar Dwivedi
2025-12-31 4:55 ` [PATCH V3 2/4] dt-bindings: ufs: Document bindings for SA8255P UFS Host Controller Ram Kumar Dwivedi
2025-12-31 5:19 ` Dmitry Baryshkov
2025-12-31 7:53 ` Krzysztof Kozlowski [this message]
2026-01-06 13:43 ` Ram Kumar Dwivedi
2025-12-31 4:55 ` [PATCH V3 3/4] scsi: ufs: core Enforce minimum pm level for sysfs configuration Ram Kumar Dwivedi
2025-12-31 4:55 ` [PATCH V3 4/4] ufs: ufs-qcom: Add support for firmware-managed resource abstraction Ram Kumar Dwivedi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d724c6d3-0dff-43a3-827b-fdf8be2a6a0d@kernel.org \
--to=krzk@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=alim.akhtar@samsung.com \
--cc=anjana.hari@oss.qualcomm.com \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ram.dwivedi@oss.qualcomm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®