From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753342AbeAZOx3 (ORCPT ); Fri, 26 Jan 2018 09:53:29 -0500 Received: from esa3.dell-outbound.iphmx.com ([68.232.153.94]:64980 "EHLO esa3.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753251AbeAZOx1 (ORCPT ); Fri, 26 Jan 2018 09:53:27 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2EBAQDDPGtah8mZ6ERdGQEBAQEBAQEBA?= =?us-ascii?q?QEBAQcBAQEBAYQYgQQnB4NWmQ+CAokTkEgKhTsCGoIDVxUBAQEBAQEBAQIBAhA?= =?us-ascii?q?BAQEKCwkIKC+COCKCSgEBAQQjEUUMBAIBCBEEAQEBAgIjAwICAh8lAQgIAgQBD?= =?us-ascii?q?QUIihUDFbBpgieHPg2DDAEBAQEBAQEBAQEBAQEBAQEBAQEBAR2BD4NDghWGbYJ?= =?us-ascii?q?rRASBdhAjgl2CZQWSTYdFiUQ9kGCEfZQxjiaJOYE8NYF0cIJ8gmWBc3gBjRSBF?= =?us-ascii?q?wEBAQ?= X-IPAS-Result: =?us-ascii?q?A2EBAQDDPGtah8mZ6ERdGQEBAQEBAQEBAQEBAQcBAQEBAYQ?= =?us-ascii?q?YgQQnB4NWmQ+CAokTkEgKhTsCGoIDVxUBAQEBAQEBAQIBAhABAQEKCwkIKC+CO?= =?us-ascii?q?CKCSgEBAQQjEUUMBAIBCBEEAQEBAgIjAwICAh8lAQgIAgQBDQUIihUDFbBpgie?= =?us-ascii?q?HPg2DDAEBAQEBAQEBAQEBAQEBAQEBAQEBAR2BD4NDghWGbYJrRASBdhAjgl2CZ?= =?us-ascii?q?QWSTYdFiUQ9kGCEfZQxjiaJOYE8NYF0cIJ8gmWBc3gBjRSBFwEBAQ?= From: X-LoopCount0: from 10.166.132.187 X-IronPort-AV: E=Sophos;i="5.46,416,1511848800"; d="scan'208";a="119590265" X-DLP: DLP_GlobalPCIDSS To: , CC: , , , , Subject: RE: [PATCH] platform/x86: dell-laptop: Add 2-in-1 devices to the DMI whitelist Thread-Topic: [PATCH] platform/x86: dell-laptop: Add 2-in-1 devices to the DMI whitelist Thread-Index: AQHTljDD8vcoWiwSCkebc086GnZFbaOFmmaAgACge0A= Date: Fri, 26 Jan 2018 14:42:19 +0000 Message-ID: References: <20180125224857.3622-1-alexander.n.abrosimov@gmail.com> <20180125230239.GA3736@fury> <20180125230615.akr2nvmmrqzfo53q@pali> In-Reply-To: <20180125230615.akr2nvmmrqzfo53q@pali> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.143.242.75] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id w0QErZlU022263 > -----Original Message----- > From: Pali Rohár [mailto:pali.rohar@gmail.com] > Sent: Thursday, January 25, 2018 5:06 PM > To: Darren Hart > Cc: Alexander Abrosimov ; Matthew Garrett > ; Limonciello, Mario ; Andy > Shevchenko ; platform-driver-x86@vger.kernel.org; linux- > kernel@vger.kernel.org > Subject: Re: [PATCH] platform/x86: dell-laptop: Add 2-in-1 devices to the DMI > whitelist > > On Thursday 25 January 2018 15:02:39 Darren Hart wrote: > > On Fri, Jan 26, 2018 at 01:48:57AM +0300, Alexander Abrosimov wrote: > > > SMBIOS 3.0.0 Specification introduced new Chassis Types field values for > > > 2-in-1 devices like tablets, convertibles and detachables. Dell's > > > Inspiron 2-in-1 and XPS 2-in-1 fall into this category and they have to > > > be added to the DMI whitelist, so rfkill and backlight can be controlled > > > for them as for other laptops. > > > > > > Signed-off-by: Alexander Abrosimov > > > > Thanks Alexander. Looks good - just going to give Pali and +Mario a chance to > > respond before merging... > > I have no comments for this. This should be confirmed by Mario or > somebody else from Dell, which DMI names are used for a new products. Yes these chassis types from SMBIOS 3.0 are covered by Dell specs and used for some products. This patch looks good to me. Reviewed-by: Mario Limonciello > > > > --- > > > drivers/platform/x86/dell-laptop.c | 18 ++++++++++++++++++ > > > 1 file changed, 18 insertions(+) > > > > > > diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell- > laptop.c > > > index cd4725e7e0b5..23fc94d70ea1 100644 > > > --- a/drivers/platform/x86/dell-laptop.c > > > +++ b/drivers/platform/x86/dell-laptop.c > > > @@ -110,6 +110,24 @@ static const struct dmi_system_id dell_device_table[] > __initconst = { > > > }, > > > }, > > > { > > > + .matches = { > > > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > > > + DMI_MATCH(DMI_CHASSIS_TYPE, "30"), /*Tablet*/ > > > + }, > > > + }, > > > + { > > > + .matches = { > > > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > > > + DMI_MATCH(DMI_CHASSIS_TYPE, "31"), /*Convertible*/ > > > + }, > > > + }, > > > + { > > > + .matches = { > > > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > > > + DMI_MATCH(DMI_CHASSIS_TYPE, "32"), /*Detachable*/ > > > + }, > > > + }, > > > + { > > > .ident = "Dell Computer Corporation", > > > .matches = { > > > DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer > Corporation"), > > > -- > > > 2.13.6 > > > > > > > > > > -- > Pali Rohár > pali.rohar@gmail.com