From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932596AbcK2TjB (ORCPT ); Tue, 29 Nov 2016 14:39:01 -0500 Received: from mail-by2nam03on0057.outbound.protection.outlook.com ([104.47.42.57]:42016 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752668AbcK2Tiw (ORCPT ); Tue, 29 Nov 2016 14:38:52 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Subject: Re: [PATCH v3] kvm: svm: Use the hardware provided GPA instead of page walk To: Thomas Gleixner References: <148044248179.29544.16863706762469812354.stgit@brijesh-build-machine> <148044249174.29544.4194514184644021170.stgit@brijesh-build-machine> CC: , , , , , , , , , , From: Brijesh Singh Message-ID: Date: Tue, 29 Nov 2016 13:38:42 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: MWHPR22CA0052.namprd22.prod.outlook.com (10.171.142.14) To SN1PR12MB0670.namprd12.prod.outlook.com (10.163.208.28) X-MS-Office365-Filtering-Correlation-Id: 28bbdbb1-3cfd-4113-7611-08d4188f57a9 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:SN1PR12MB0670; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0670;3:EVLtwZ2jquGmHvpnuJ/KkI+1xxfplMil5TWFHVDNMn/7UMPBTVR/qJUKnNtaztQJqgMxm4vOhxdOYq8xY3EZy/IHPbBobmSdlJ4DZPH1q+SRAIC13MW5dGhaw1+w5B62FtdNLd4wtkW3A3NvH0+Y4MmbCPWHnNRyDDQbbf2Jn2J7R1q97gHQ9dFZb9sQvl36S7nEBIfSUUnVRS3n/843PLPEZM66hgfN1BUjBrdo6jEZTR77PBrFzSmszPaowaAqYJWaDmDHY+f219W2urb3CA==;25:4YbfUpoFQKgOpTcE4PG+vjqP43WFRvrpoe9xX0HqsoyruxoRi7RJfFgt880QhMLgw0Iuwxjp8pBdADsKQ2XQdG2GjLXabRxZXxMupwjyPYaCEFxcXi5GvHO9+xmsEpyhNuDcu7uQddktw3YNZo7VJSv45qVndrvy/lC7LpPAuQTTvNLhMPRI+n/kXCbpUL48t98rTpMWSALtFK86ZPY2PZEpmZ7P3KtymE9aG6pNUsdpAutLVa+u+bzbX07Fzdm6sQ73hgBd1ubzuS7LK0ofLKKR4+BmJqct0DG6B7zUGEVaxm8XzbriijotfRLz/WVjaU1y2GmXUGHMqjdEpF5p8UiH+BF3V7qhGuuUdgE9YBI1r8Ri5ck60zWIK4jzSM2AOBhJwsgDt5rq3th3o46utmlHbQD/HEY+VhGW/MNL4R5CW0APdThsN/omiXj7nOrBUj7jblpRue5K+nuSL7JPkQ== X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0670;31:AQ7pRvaVjRVmpGMAinFdreCZufNtkQb5nLsxTHaLMiu+1+ZSyGdVFytdTKB8lPxvecE3VLYykgVjJ+TXbI6nw8TfDVUCp4gtYjbIgYdg5rt1TC0g6j2h2QxUBqIYl75i45Qj8Mtr1NQl/HupMMEGCTEp/GQeK5LB0ftScrXFx4yqZj2EGikce9Klp5Lxoqgo7uKUiAGiPm2qBWjlgZwuXC7/fkxSnwiryZoQnE+vxlT+Y7Yd+f/oIaMa53kR2SJJxmUMsxljtUIc/KkWCUFQTw==;20:hNHPthJL68jBadugggelkqp/G5ZbgiBASEOtcVYxaZ1y6Qsug4YXsfp5D4ib8efr3j1Eh2KJKgA/S7Z2wMtxxbOqoRcETVvAakGBqBYTAZiF4rBDpM5op/NG2TnfmM8j4GbjpH2yd8TwcSfqv4ikaxGxg/jaCgZ6joeg2cbvtQHkPGK+OV3Hm2UqveN7ki3WkIh/a4Le22wr9kfP7G/0/kBcCbHtPgeLHrteBQs4qOxtb30Wvrd+o8FpDMnmC4jv5+ZLHQVhuttX56mrHkYE6enzkPwX74kkXc2k0Rnss4p+4nbiUN88sDcMBci7+U8SurGrlvnbXd0vaci7GFed1dedglO7JzbYBJozHkY6+2kmD69H8N66AND1pMsMCflwHzHV0uhMjCZH2Rsst1hWrA03YgGWuIFYMGM57q+xc6Qy4eNsP99ryA9zjwnaiMSMxZwv/YExMqbFPTptWd2ARfMv3JehH6jo1eNExjMpJ2HqIS2B0tjo7M27rdPHPNhA X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(17755550239193); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6060326)(6040361)(6045199)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6041248)(6061324)(20161123562025)(20161123564025)(20161123560025)(20161123555025)(20161123558021)(6072148);SRVR:SN1PR12MB0670;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0670; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0670;4:6YO59cVXAdVf1Wj60tdGKVwonei08BvztC/iRVeoq2+H44+Nd9yjz7CM0wnmIcYcc6H4RalNbcUmFYMNZ9SHBRXGu7Rtw1n5RsQxHapwcvKGU/LVGdvleyYisEBaJdVXJSVTSxoneYY/NgKYxayxF3qkLTPf1SmrPlRltXm+QIv3qux+r38FPE1hyWKSvryAoO85EgNZUqA9tImkQmHgt69kaZ4uRQ8DFcM/KKZEiy4mg2CGypPdb7m1kmqEE02iF01cl+yFEw1vskZutHw1nce+gqetfMmtdQtWV+o50P4GGvrxR+SrmO8cuqKjiBzDGZm297NCosEovGr7PDXb6ETjZmfd/Ibcts+HCUS3knNijGiFz55J89Q6pCDtpiZsGRg32mBZMWIjfpbkSoHgM+FLnReNeRY4zbnTelA425a0aTwO25O8u244MvsqEEQ/Te1tb+/L2liSywVWEQ6+JU8RFD4Dw9YJMrdUlTcUYITuZKHKmgX+SfzR/WhimVWJw2x8GVx/nQJncS3FGu4g6SpVFX6YwLHgSTgpHKV1nJiFjU8ilCp3f8rpzypfZdOpw3BR8E1M47RJ4m9gG1MinpAWbmfj0N4tNb3zajTEDyHsqN8ofPA2L7OuN3CGRjyPevLlYrTD/9H27FJO/u7/dtckiXchuQDftdaJHMlQYz7zg7Z1JjRpvtFlfvtN9YR+5VOPMDgPvmrYMmzLNlpbMw50/8ZENrkinzZ4YXzu8II= X-Forefront-PRVS: 01415BB535 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(7916002)(24454002)(377454003)(199003)(189002)(106356001)(50466002)(101416001)(64126003)(36756003)(8676002)(38730400001)(86362001)(81166006)(33646002)(42186005)(81156014)(230700001)(39400400001)(6486002)(31696002)(83506001)(105586002)(23746002)(229853002)(77096006)(39450400002)(39380400001)(68736007)(733004)(39410400001)(305945005)(189998001)(97736004)(7846002)(4001350100001)(76176999)(50986999)(110136003)(5660300001)(2906002)(54356999)(31686004)(7416002)(7736002)(66066001)(65806001)(65956001)(4326007)(47776003)(6916009)(65826007)(2950100002)(6666003)(6116002)(3846002)(92566002);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR12MB0670;H:[10.236.136.62];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;SN1PR12MB0670;23:t+lcp4/K6M8TlpJSfUwlA2j1Jx7cwpOmYYZin?= =?Windows-1252?Q?4GQ1D1A+pnh5r8Em+hLfs5bKZzq4h4iZBGoGQpi+U+6KDA58YnwtwI3A?= =?Windows-1252?Q?t4qr5ri599LUHW2p8eQVmFWLJfOdoE/9cGJ7kbNlJ3n9IRAYf6Hia8Jq?= =?Windows-1252?Q?TbcUgpci23ZMbfzTqaYl6v5f1gshu3kqDqEm5EAs+Qz/OkgUXdtpXDks?= =?Windows-1252?Q?UmYJvHGy8zXd/RJ5+/XROPtxVHCe4Z1esXUxPCn3TWCWp6NfX6yPD3Vw?= =?Windows-1252?Q?C3hGEkS9V3FeUSV9Mw6gE3vu09TGQg9aqmHcK+wG9NUcQAnNVjZQhkn6?= =?Windows-1252?Q?UdILOF75Otaqo/3vedB6rzLdVLlc6sVzipmSBWo+n1aAzMYFznkiEHtn?= =?Windows-1252?Q?fbgwrTnTOd9tAGoh9MZFTgabhJ7gbQd2E9wBNMr3lg+Kk7YHdaG1d/as?= =?Windows-1252?Q?UOlaQ9LDWObi3vEnZT/JzutbHj/oBHXqgThn8xWqVtWThM7VJxdu7sDC?= =?Windows-1252?Q?vgPFtd9G3FDyMQAFPIgfLuelQgKFIp5tNt0cY/g1bnVh59ScLjO42YOo?= =?Windows-1252?Q?fGsX6KcvWz+1IcrnYVO5As3wJsfTq00QsBBU5oE75RKfZzRSux0DYh1D?= =?Windows-1252?Q?FJ0zoCS6b82fFFNhBPjqMWAxSfeLGLiu2h58u8bKCEs3Aai5DdkAREFU?= =?Windows-1252?Q?VwXtqXj2JP3d3i08tqTUf/VeS63FJ70YV35anJIkd9ZY2RopzJQfrXm6?= =?Windows-1252?Q?HQnN0jsnamwUtjexsDPKx0JcrL4B74kIYBWBXJyc58lRAVy6RmzKXL76?= =?Windows-1252?Q?cJIH+N2oBaMSUt5sU5GBHvO2oYX7b8w5JsNdVBX8RcUKo7M9Yfvl+us+?= =?Windows-1252?Q?OdBmJ1EMheXPobQmf24iq/uuUdbOrw79gDw5LFUJhNdhQz4Ru/NhdfTD?= =?Windows-1252?Q?ueG1qtf5XITGL/SR8TrMnZZZEA5OgASO30GzLJLZqLtVylW+Fo/mt4yv?= =?Windows-1252?Q?XSY812I3YuV+RG4gVT0mBof2+ouVeQQqirbl9PkLDkrAuS1KA4dDvDqr?= =?Windows-1252?Q?Jsa9PT7xwPW8NIOtBWBf2dJSUMy4ogG7xXHBxwuOEidQIopykfLCg2Fk?= =?Windows-1252?Q?oAkIJ080a9Uxg3hoGvBhAkLS9Wmo9CytGNWTQbUDvmRznrHIAOakFQCg?= =?Windows-1252?Q?vCZvdVScadO7ckhOB73nmLptkkRHj73nsZ6ELwIwWlvhZaY8bQ/yXdUE?= =?Windows-1252?Q?OtR2B5vd/vMm+QZz4YKcrvT+l75Db44JhwkwH2L/FqQTFtwjY5qfsr9Q?= =?Windows-1252?Q?L9GVGlc9RUbz5founHen1s/mb1sXloWRdd5kS+4EsiukepgBotMeY7C6?= =?Windows-1252?Q?Nnq+2k2HP/4+J/MRlrCraxLQctZmgn+9hfC/y3+x4V9zH4XcqU4tQoUj?= =?Windows-1252?Q?TCH9SCJhZv4yp6nfeYR9kodqJbIG6LXUirvQqMCCEuWRtt5M4RVJgysB?= =?Windows-1252?Q?SK7eb15KKD2DWlcecUpSLkKCD+eGO67c0QY+APCLV4CoKpCLEpbr5FmL?= =?Windows-1252?Q?QZ2M4C2q3DrtG4=3D?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0670;6:IPVp1HZda2iUaioK0lf0TqxVZRCgYBuwtW7Ff0p7sO77zCgutCyyyUZ7OO/Dsgtexdgz1ArwDj5XxwEnoIXVBl6odG1tqFzEOS/NhvrDYLC8Ahdc0nWr4ujv+zz8b84gyeIIOgTdOkih/OaZTCxmqaK1hZG7yCsLrgaWRIYf8+xdUe2OqXSotuAqrwsW5fD+BDorI0wEvQ60/VnU4c0h/GbNKA/lAmhgAg1aoNTy4Yqwk+UGQq/vAZ6MI3UnH6IGKTs8vL6UQKz3rR+bDKFX3CepxCPh41H/TLEDFmDzB3SMPpZYuervHwycYTfhdFCv0kbK06xEh3IRB14/V7iJvbSyubVtzkxQi+YshjPUa9k5L8uq1voe0omSVCMrRFUzCIplzzOxly5JSopJ4xeBApi0T3FusNp01/BLHIbV/MuCwihfA5LIk6geY7cMyhqsAE7uBLsyACtzt267h3bV7YGiZLz+Hm0CglB1MqMv/epVspnnaTu+kZI0p/RnQKaD;5:4ZnqUZIuGbbT6TG3bOcrRgVWUb6ozZU83mYmSa5Cxyyh+N9+oRsECRnXPrUZcTHjoLwap8BBJvSKKjAuFrlEYGgIQI1DzO+hZiEZh77WSqtXpF7xUEnpXbUF4xC7CT9xTKkNkedQLaXVaxnMrXoNYQ==;24:GdoiNVunh42wWIDWMHBg8QaiO0ulVYfYizf18fGG4STDGXdBj6uBcerMLuwwLDVuxAVZdXGDc5JAbrsYIE9+7Cm6TI0abH7wFsCSC/6Oph4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0670;7:kMtfnV5hRQwgjNyo3bsYfwBfJ2twKfRGdV7PWkzJ2rJ745xiEneOJtp+SSX+Jq0UAAFcee/pjvMxbGgk86u9/P9cs6vTf/6ZOXiyysf1l943XEK3QcOiHov5vIrjKGDRGjEtJiEQqFpEj0mUzL+7BgJKgj1AiNYUwdciMMJMlmpa9ml1ZOdd5Dcbt8lJPCLAQtekMKqCyoieYkDB0COcpVQXPh15TNM1fWkZsAqHEBTsJKGQi33yA8VSyVDi2s0ZiDKp7QxzTzeYA0byCSHwWizrCzaB763aX7oMyrfNWu/SsMy+9dMPmPH/ARDxs2oDVjC/W1k/t9dM9bBy/qPqFSrh6By0oZ/YH1tgkkDWHMrMlPgSMO1i1QMz/W5cdUkrUumg+Ye9XXk41JZ3ldqmFuXMzpJGTiKf/rnbB7m909VBp9ela36kwTZLEltkqMBc4PCQa9br9vWWG/AFQhxY6w==;20:kG1b/QNFJMR+P2pU/OiJGdDyhACXC8U2k9bcCsrKMX8lOpvqtLCpi7NYQyiQfwwkCn2prDgjTVWrA9AqKSBdKYFJ7LtlUj6PkmVESFB646X8SI0UfHtw9Hki3gvalNuLW8eOKWf63K0457xDwZsRRNz2ReEZmd3Z5Xa0WqM9bwROZCYLbmsUJ79pI82yJ3x9bnxWGBQo5c/JMxLZc79slMdH0srnxHjXoEoKPGoG5poba5M4X6423Uj+q6kxJ6A/ X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2016 19:38:48.2204 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0670 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/29/2016 12:20 PM, Thomas Gleixner wrote: > On Tue, 29 Nov 2016, Brijesh Singh wrote: >> --- a/arch/x86/kvm/emulate.c >> +++ b/arch/x86/kvm/emulate.c >> @@ -5483,3 +5483,11 @@ void emulator_writeback_register_cache(struct x86_emulate_ctxt *ctxt) >> { >> writeback_registers(ctxt); >> } >> + >> +bool emulator_is_string_op(struct x86_emulate_ctxt *ctxt) >> +{ >> + if (ctxt->d & String) >> + return true; >> + >> + return false; >> +} > > Do we really need a full function call for this simple thing? Just because > this horrible CamelCase constant is in emulate.c? > > What's wrong with moving that thing into a header and make it a trivial > inline: > > #define INS_STRING (1 << 13) > > static inline bool emulator_is_string_op(struct x86_emulate_ctxt *ctxt) > { > return ctxt->d & INS_STRING; > } > > Hmm? One of the recommendation from previous review feedback was to move the check inside emulator.c. I am fine with inlining it into kvm_emulate.h Hi Paolo, Do you want me to spin a new version ? -Brijesh > > tglx >