From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8DAA3BC696 for ; Fri, 10 Jul 2026 12:10:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783685456; cv=none; b=YFJatz9JSpKFOobqNdeiIQhDM/3M8WBMQ1pFm3MMhNuAjYNIb1gbxmg4I9jNhhgghLoVzt1r80k62amsXgjaYf25VHaJxYNtV88j/Mx7cGftmul7nKOALPwOVcUGROlAX5ymKLK/vHvQZFcfQMswQm9ph1CCMgZiAK8f+vM+z4Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783685456; c=relaxed/simple; bh=LQuqMBiMfznhd5njKcRFfwpGiKCYjugLtkhtU7uU7rM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RpxLVil0QIAP0vOKMZXYie2rDBusFsjsC+4wQUG8umBCSjHrL2FxJ8ODpNRqJxdrrdD8N3dm2ZpNBGKle52NFyjAenNPC5BvdcYm1tkBxU8ItjFS33ePixbwE3THCBJ4i2F0TwAscDiJvxRbT1DnFRQqnqEssp7GeuSnZI9GHyw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cjdqP+yv; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eG+Ad/CQ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cjdqP+yv"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eG+Ad/CQ" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66AAnLHF617199 for ; Fri, 10 Jul 2026 12:10:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= BMHYD3IApt7H3j1PjH1ywGPQU4YgKE9uns8OQVgsLG0=; b=cjdqP+yvsqtn6gPc W+muhRwpAEjb8KOgdYqYgcyr9oh7YA3nxxu/lmn6zEvw/C8I2oicRSES4ZQQBep8 u22fp53QKB3BGmePM0prjkBOpPuHkc8W0uHr2yBIlapcZ0FphrPBtDeViTQAMs3n +H0UZx0wRm9P4XM2eHbln7299wzAI6WFA6s8oE9ssdEoK+a9+zhdbC0/F2EFrmJZ C7S6OY2rgHWvD9uPInMbCQBTm3qSv0C5KPf5YmcfNGbhPXaRM3HjirQFJBiaUG/Y IoNP6alu/Byf8pt25HOABSpN96pox1tbMPE4UsL1l4k4kwNMctXY0XG82VJPi+IC E2y5KQ== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fas6n1rt2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 10 Jul 2026 12:10:53 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51c08e9c344so2755651cf.3 for ; Fri, 10 Jul 2026 05:10:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783685452; x=1784290252; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=BMHYD3IApt7H3j1PjH1ywGPQU4YgKE9uns8OQVgsLG0=; b=eG+Ad/CQRqAWo2z/mxzOUoY0Iewu+f51JLlWOgPDWiFp4qmJR9e00c8J8fWh3rAYV3 26DsbecVSFmaOg/7kQ3liyuXpfmtH2XvJjxKwpEs0gc7tV/B4fZuCMPNSYiQABsc3wRc ihGu1s9B9W7LaUw/phI/2Qk9C+W71MCzHGVuRarS9ngOdnhepD3FHdE338XNJjRa2mAR rOEleev08DTc6issSCyhFwLSL7EGfiFGvZPd6eviYZsCbDaAjMq0q4v3l269GcJ0EYLr cZSCADdOFQwZV0Pno2Aym/KQKgalqwi7Ff76T0o0eSil/DYOjTxVaASkC7+6OskLwmk2 tHqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783685452; x=1784290252; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=BMHYD3IApt7H3j1PjH1ywGPQU4YgKE9uns8OQVgsLG0=; b=hKajIL7eu9o3uV581C76YF0rUOfGd0Exdou4zQoaRNwwCwBrLMbskz5zbLxmbxtLWL xxwigi1LSJ3WzYAYKKzlLa/KsENidrDk2jEVe/+A+aTXsfVW2k8vyWYQp24SgPo2oQik 3h4jhmA83i9zU+df3H1cl+eJAtVM+sPlK+TzMvtbStRZ7epZHnY1JkSwA1weqXkotdLL mktyuDfqf7nn5QR0exikPW0bLmePBKwc3FQbs2/MTM4g44bE6UoY/RfLxudF9rmO8uq8 bkJot3ws068yObycyBpzvV/nt3uEs20JRsGk/E20BqzMSuNg9nbPgNA6KaqLJduHv9UG /Zvw== X-Forwarded-Encrypted: i=1; AHgh+Rq5Xk8EZZP2faxwTwG5KfNyewi4YaDugiydwsbgVrPXSfB6CY5i56nc+Fw5UycCzOkaY6lRZnFak9z+7bk=@vger.kernel.org X-Gm-Message-State: AOJu0YyPang5dA5WGTIGMfVd07nQ4Qii7c3UMu6+/GYnnjvAgRECtVL9 yUd/M0gsSyVFO9nTkjQ4AQjDI6VPumLN9ioURruFhU4lfS2VAYq7LG5MN39/dgHRdE0QaZVMnSb qW14wTx4pXhTsv18xiGWLBKZ+qW36ZombBZkpbexUon/f4LFpFBmSuu1lAPJLIzgWAHu833pfOC Q= X-Gm-Gg: AfdE7ckWKpXNNwVc+AuylPMxbSfBlGf/+EhIchpmbRxku5Mk2OrgvdUWFTR3dczaHff fQVLkDYtwXt9VkwysuJQZkwiyPt4z2E23uVvinMe9Q+EmazLyfEme/m/b14hqkV4USKUeto2dM7 s1Z+qbP7Yizg6efxc4/abm+dv082Hp/7DerQGJGq4ZuCgHsa0/JHuJNpC9XI/qc20gBPM1VcLKw xfRETj2nKpfctWiO+wJ8Uo7BBFo2Plo09TEpnGz+T1sTgOJw15EqVr1mQ69Gaml37TIl/kwWtKX TEvpIp3Uon4qeexYbHNitJcE/2hAKcI+cjKEexGOaTIkW70HhhCuZzJw3+br1E2Z1haqakF+GBQ yxywh9Cuq5UIMwAe2/vUhr78lpDPFmI5sCkk= X-Received: by 2002:ac8:5d91:0:b0:51a:8d32:f796 with SMTP id d75a77b69052e-51c964037f9mr69730111cf.0.1783685452025; Fri, 10 Jul 2026 05:10:52 -0700 (PDT) X-Received: by 2002:ac8:5d91:0:b0:51a:8d32:f796 with SMTP id d75a77b69052e-51c964037f9mr69729851cf.0.1783685451645; Fri, 10 Jul 2026 05:10:51 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c15c3f5ca3fsm437597666b.51.2026.07.10.05.10.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jul 2026 05:10:50 -0700 (PDT) Message-ID: Date: Fri, 10 Jul 2026 14:10:48 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili7807s panel To: Arpit Saini , Nabige Aala , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260706-shikra-dt-changes-v2-0-56fcd1659ea4@oss.qualcomm.com> <20260706-shikra-dt-changes-v2-2-56fcd1659ea4@oss.qualcomm.com> <8a3cc857-0b1c-4bd5-a5ce-a564823ca614@oss.qualcomm.com> <6f8d8cf5-1e35-4d45-b2c1-6f36ac51ad4a@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <6f8d8cf5-1e35-4d45-b2c1-6f36ac51ad4a@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEwMDEyMCBTYWx0ZWRfX3wbdbzRA4GcX YTYDxEUm13J1XJCu0XQvduFOaMCGLQaVQfRNbP8Q5anNmAz/vZ81N1NXBVIx2ceEDiPVXUZNZPs mIam5Lz6S0GtE1vyn0J0evjS9Bg0cJE= X-Authority-Analysis: v=2.4 cv=DYgnbPtW c=1 sm=1 tr=0 ts=6a50e14d cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=7g_QvTktBp9WSWir8t8A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-ORIG-GUID: k_2PbDYsHOxtQSCK9uVZtp4Xs_mjvoFX X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEwMDEyMCBTYWx0ZWRfXyumdqX01p4H5 tZFmX5WfnTbGSn9qmUThKf3JJFoXktTMbZm4S6KJttWg3M0D04az0TYqOFhpwhRFl5ToyPlEgIk ufbSTNUUs9E5AxgWmUM8BtyVaR0ebI91MEBPRZyqWJ3V8L0HZiGOf5f/JWqICeXoPZOYAl9LCqx 1PrI0608+W+nfevw0IpFvSAslIaQxKK/jA3NID8iUqh6xK8sOlCZluR8qAzKHJE3sZetkp1AH96 WA2uqIsDrNNbg1yv+FTTXgIwo8zehUprRBAYr4EGmTkHXWlbhpDdZgGf1lj8QVi80tscVECLEhM O9+IX8qEUIhtralFtyfy7oDEATYjWDVwqfaxHTUeVnOYmb9sv2T0DGNtQnlChOg7OZxuLwej8v5 YkaUZ1gg7fNjD8L37We9Eq2tYFQ0Sw3EeYXaCzA43Oh3txo8OpTfiT00lYFmz+UkqCMK0ljDI6S oj8CJV1HfyCFau0oZWw== X-Proofpoint-GUID: k_2PbDYsHOxtQSCK9uVZtp4Xs_mjvoFX X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-10_03,2026-07-09_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 suspectscore=0 bulkscore=0 clxscore=1015 phishscore=0 malwarescore=0 spamscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607100120 On 7/10/26 1:58 PM, Arpit Saini wrote: > Hi Konrad, > > On 7/10/2026 2:31 PM, Arpit Saini wrote: >> Hi Konrad, >> >> On 7/6/2026 3:33 PM, Konrad Dybcio wrote: >>> On 7/6/26 8:04 AM, Nabige Aala wrote: >>>> From: Arpit Saini [...] >>>> +    panel_bl_en_suspend: panel-bl-en-suspend-state { >>>> +        pins = "gpio91"; >>>> +        function = "gpio"; >>>> +        drive-strength = <2>; >>>> +        bias-pull-down; >>>> +        output-low; >>>> +    }; >>> output-foo isn't necessary, the panel driver will assert it as >>> necessary >>> >>> Konrad >> >> Ack, thanks for pointing out. >> >> Arpit >> > I just checked, > > Normally the backlight EN pin is controlled by a backlight driver. > > However, this panel uses MIPI DCS based backlight control with no > > separate backlight driver. Since there is no driver to assert gpio91, > > we control it via the panel's pinctrl default state.. > > So this is platform specific pin , we need this to enable/disable > > the backlight. Why would the backlight state be so tightly defined by the panel? Disabling or adjusting the backlight level without shutting down the panel is a perfectly valid use case. Take a look at pwm-backlight or gpio-backlight. Konrad P.S. Set `mailnews.wraplength = 0` in your thunderbird config - it currently inserts an extra \n between every single line