mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: broonie@kernel.org
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	patches@opensource.cirrus.com
Subject: Re: [PATCH v2 1/2] ASoC: cs35l56: Use reg_base to offset addresses on SoundWire
Date: Tue, 19 May 2026 14:20:07 +0100	[thread overview]
Message-ID: <d732483b-cb5e-4733-9ab6-04cf6ac16884@opensource.cirrus.com> (raw)
In-Reply-To: <20260519113703.393210-2-rf@opensource.cirrus.com>

On 19/05/2026 12:37 pm, Richard Fitzgerald wrote:
> Set the reg_base member of regmap_config for SoundWire so that
> the regmap core will apply the 0x8000 offset to addresses, instead
> of doing it within our low-level regmap read/write callbacks.
> 
> Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
> ---

STOP!
This also needs an update to the cs35l56 KUnit test for the changed
addresses being passed to the dummy bus driver.

(This patch was written before the KUnit test existed)


  reply	other threads:[~2026-05-19 13:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-19 11:37 [PATCH v2 0/2] ASoC: cs35l56: Replace open-coded SoundWire regmap with generic regmap-sdw Richard Fitzgerald
2026-05-19 11:37 ` [PATCH v2 1/2] ASoC: cs35l56: Use reg_base to offset addresses on SoundWire Richard Fitzgerald
2026-05-19 13:20   ` Richard Fitzgerald [this message]
2026-05-19 11:37 ` [PATCH v2 2/2] ASoC: cs35l56: Use standard SoundWire regmap implementation Richard Fitzgerald

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d732483b-cb5e-4733-9ab6-04cf6ac16884@opensource.cirrus.com \
    --to=rf@opensource.cirrus.com \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®