From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: block device direct I/O fast path
Date: Tue, 1 Nov 2016 12:22:42 -0600 [thread overview]
Message-ID: <d7350267-e3ec-958f-3c52-db219e424b80@kernel.dk> (raw)
In-Reply-To: <20161101175437.GC9797@kernel.dk>
On 11/01/2016 11:54 AM, Jens Axboe wrote:
> On Tue, Nov 01 2016, Christoph Hellwig wrote:
>> On Tue, Nov 01, 2016 at 11:00:19AM -0600, Jens Axboe wrote:
>>> #2 is a bit more problematic, I'm pondering how we can implement that on
>>> top of the bio approach. The nice thing about the request based approach
>>> is that we have a 1:1 mapping with the unit on the driver side. And we
>>> have a place to store the timer. I don't particularly love the embedded
>>> timer, however, it'd be great to implement that differently. Trying to
>>> think of options there, haven't found any yet.
>>
>> I have a couple ideas for that. Give me a few weeks and I'll send
>> patches.
>
> I'm not that patient :-)
>
> For the SYNC part, it should be easy enough to do by just using an
> on-stack hrtimer. I guess that will do for now, since we don't have
> poll support for async O_DIRECT right now anyway.
>
> http://git.kernel.dk/cgit/linux-block/commit/?h=for-4.10/dio&id=e96d9afd56791a61d463cb88f8f3b48393b71020
>
> Untested, but should get the point across. I'll fire up a test box.
http://git.kernel.dk/cgit/linux-block/commit/?h=for-4.10/dio&id=b879a97d749c5c1755d1e2f20c721eb6fde0c291
Now tested, inadvertently used the absolute timer instead of the
relative. Works for me.
--
Jens Axboe
prev parent reply other threads:[~2016-11-01 18:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-31 17:59 Christoph Hellwig
2016-10-31 17:59 ` [PATCH 1/2] block: add bio_iov_iter_get_pages() Christoph Hellwig
2016-11-01 1:05 ` Ming Lei
2016-11-01 14:19 ` Christoph Hellwig
2016-10-31 17:59 ` [PATCH 2/2] block: fast-path for small and simple direct I/O requests Christoph Hellwig
2016-10-31 23:19 ` Omar Sandoval
2016-11-01 14:18 ` Christoph Hellwig
2016-11-01 17:00 ` block device direct I/O fast path Jens Axboe
2016-11-01 17:06 ` Christoph Hellwig
2016-11-01 17:54 ` Jens Axboe
2016-11-01 18:22 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7350267-e3ec-958f-3c52-db219e424b80@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome