Re: [PATCH] erofs: Do not select tristate symbols from bool symbols

[Gao Xiang <hsiangkao@linux.alibaba.com>]

Hi Greet,

On 2025/7/30 20:44, Geert Uytterhoeven wrote:
> The EROFS filesystem has many configurable options, controlled through
> boolean Kconfig symbols.  When enabled, these options may need to enable
> additional library functionality elsewhere.  Currently this is done by
> selecting the symbol for the additional functionality.  However, if
> EROFS_FS itself is modular, and the target symbol is a tristate symbol,
> the additional functionality is always forced built-in.
> 
> Selecting tristate symbols from a tristate symbol does keep modular
> transitivity.  Hence fix this by moving selects of tristate symbols to
> the main EROFS_FS symbol.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Triggered by noticing that commit 5e0bf36fd156b8d9 ("erofs: fix build
> error with CONFIG_EROFS_FS_ZIP_ACCEL=y") caused CONFIG_CRYPTO_DEFLATE
> and CONFIG_ZLIB_DEFLATE to change from m to y in m68k/allmodconfig.
> 
> Unfortunately Kconfig cannot be changed easily to detect this
> automatically, as it cannot distinguish between a "bool" symbol
> representing a configurable option in a module, and a driver that cannot
> be a module.
> ---

Thanks, it looks good to me, will upstream in this cycle:

Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>

Thanks,
Gao Xiang