From: Philippe Schenker <philippe.schenker@toradex.com>
To: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>
Cc: Max Krummenacher <max.krummenacher@toradex.com>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Luka Pivk <luka.pivk@toradex.com>,
"festevam@gmail.com" <festevam@gmail.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Stefan Agner <stefan.agner@toradex.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"linux-imx@nxp.com" <linux-imx@nxp.com>
Subject: Re: [PATCH v1 1/2] arm: dts: imx*(colibri|apalis): add missing recovery modes to i2c
Date: Wed, 16 Oct 2019 16:42:36 +0000 [thread overview]
Message-ID: <d75236512937052dfd532d228a6fbd84824a12ed.camel@toradex.com> (raw)
In-Reply-To: <20191016162833.1893-1-philippe.schenker@toradex.com>
On Wed, 2019-10-16 at 16:28 +0000, Philippe Schenker wrote:
> This patch adds missing i2c recovery modes and corrects wrongly named
> ones.
>
> Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>
That went too fast... Will send a v2 shortly.
> ---
>
> arch/arm/boot/dts/imx6qdl-apalis.dtsi | 26 +++++++++++++++++++++--
> ---
> arch/arm/boot/dts/imx6qdl-colibri.dtsi | 6 +++---
> 2 files changed, 24 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> index 7c4ad541c3f5..7baf4a6f04eb 100644
> --- a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> @@ -205,8 +205,9 @@
> /* I2C1_SDA/SCL on MXM3 209/211 (e.g. RTC on carrier board) */
> &i2c1 {
> clock-frequency = <100000>;
> - pinctrl-names = "default";
> + pinctrl-names = "default", "gpio";
> pinctrl-0 = <&pinctrl_i2c1>;
> + pinctrl-1 = <&pinctrl_i2c1_gpio>;
> status = "disabled";
> };
>
> @@ -216,8 +217,9 @@
> */
> &i2c2 {
> clock-frequency = <100000>;
> - pinctrl-names = "default";
> + pinctrl-names = "default", "gpio";
> pinctrl-0 = <&pinctrl_i2c2>;
> + pinctrl-1 = <&pinctrl_i2c2_gpio>;
> status = "okay";
>
> pmic: pfuze100@8 {
> @@ -372,9 +374,9 @@
> */
> &i2c3 {
> clock-frequency = <100000>;
> - pinctrl-names = "default", "recovery";
> + pinctrl-names = "default", "gpio";
> pinctrl-0 = <&pinctrl_i2c3>;
> - pinctrl-1 = <&pinctrl_i2c3_recovery>;
> + pinctrl-1 = <&pinctrl_i2c3_gpio>;
> scl-gpios = <&gpio3 17 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> sda-gpios = <&gpio3 18 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> status = "disabled";
> @@ -646,6 +648,13 @@
> >;
> };
>
> + pinctrl_i2c1_gpio: i2c1gpiogrp {
> + fsl,pins = <
> + MX6QDL_PAD_CSI0_DAT8__GPIO5_IO26 0x4001b8b1
> + MX6QDL_PAD_CSI0_DAT9__GPIO5_IO27 0x4001b8b1
> + >;
> + };
> +
> pinctrl_i2c2: i2c2grp {
> fsl,pins = <
> MX6QDL_PAD_KEY_COL3__I2C2_SCL 0x4001b8b1
> @@ -653,6 +662,13 @@
> >;
> };
>
> + pinctrl_i2c2_gpio: i2c2gpiogrp {
> + fsl,pins = <
> + MX6QDL_PAD_KEY_COL3__GPIO4_IO12 0x4001b8b1
> + MX6QDL_PAD_KEY_ROW3__GPIO4_IO13 0x4001b8b1
> + >;
> + };
> +
> pinctrl_i2c3: i2c3grp {
> fsl,pins = <
> MX6QDL_PAD_EIM_D17__I2C3_SCL 0x4001b8b1
> @@ -660,7 +676,7 @@
> >;
> };
>
> - pinctrl_i2c3_recovery: i2c3recoverygrp {
> + pinctrl_i2c3_gpio: i2c3gpiogrp {
> fsl,pins = <
> MX6QDL_PAD_EIM_D17__GPIO3_IO17 0x4001b8b1
> MX6QDL_PAD_EIM_D18__GPIO3_IO18 0x4001b8b1
> diff --git a/arch/arm/boot/dts/imx6qdl-colibri.dtsi
> b/arch/arm/boot/dts/imx6qdl-colibri.dtsi
> index 019dda6b88ad..4ed7ae57030d 100644
> --- a/arch/arm/boot/dts/imx6qdl-colibri.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-colibri.dtsi
> @@ -312,9 +312,9 @@
> */
> &i2c3 {
> clock-frequency = <100000>;
> - pinctrl-names = "default", "recovery";
> + pinctrl-names = "default", "gpio";
> pinctrl-0 = <&pinctrl_i2c3>;
> - pinctrl-1 = <&pinctrl_i2c3_recovery>;
> + pinctrl-1 = <&pinctrl_i2c3_gpio>;
> scl-gpios = <&gpio1 3 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> sda-gpios = <&gpio1 6 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> status = "disabled";
> @@ -516,7 +516,7 @@
> >;
> };
>
> - pinctrl_i2c3_recovery: i2c3recoverygrp {
> + pinctrl_i2c3_gpio: i2c3gpiogrp {
> fsl,pins = <
> MX6QDL_PAD_GPIO_3__GPIO1_IO03 0x4001b8b1
> MX6QDL_PAD_GPIO_6__GPIO1_IO06 0x4001b8b1
prev parent reply other threads:[~2019-10-16 16:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 16:28 Philippe Schenker
2019-10-16 16:28 ` [PATCH v1 2/2] arm: dts: vf-colibri: add recovery mode " Philippe Schenker
2019-10-16 16:42 ` Philippe Schenker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d75236512937052dfd532d228a6fbd84824a12ed.camel@toradex.com \
--to=philippe.schenker@toradex.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luka.pivk@toradex.com \
--cc=marcel.ziswiler@toradex.com \
--cc=mark.rutland@arm.com \
--cc=max.krummenacher@toradex.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stefan.agner@toradex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®