From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD125C5519A for ; Mon, 27 Apr 2020 08:03:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 92AE1214D8 for ; Mon, 27 Apr 2020 08:03:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="JOJcf3DC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726685AbgD0IDc (ORCPT ); Mon, 27 Apr 2020 04:03:32 -0400 Received: from mail-mw2nam10on2074.outbound.protection.outlook.com ([40.107.94.74]:31425 "EHLO NAM10-MW2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726003AbgD0IDc (ORCPT ); Mon, 27 Apr 2020 04:03:32 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kd8ihO8ufh3dd+aQa379CafF5LbUFV3KRtK/fmtqwXClld9LWqdftSYRJ+4qO7Kpkr4tND5FDNssUGqUdCodyDu+dz/s8bh+3lYt6kbhXn/oOUR0vrnl5uM8HcfFpZRz0IXdy+dPVPv+1Ozli9EcJu8IO5EZKPZiG+ncQL3ZD/DbNjEf7EAE9uoL1IGe3p5WoEXpTmirUQG5NbqUk1sPGd1a3yEq81YSWLandMLVO+U3LftL18nBPc7oDtRPJJCJKB3MYQRIKPQ6VKEUlrzZPWd4RnD1Go48koZ+zipnFvWdqCPpaTnDJKPcJtzxdVsr8EVvYcfLtZHfiXyyXRU2aQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8uOBREzV+JpRFrnzhXP6qrDXJeMxIcrPYvMmZ1F7gnw=; b=ROYpGu3GSA7jheK9oO0oLEoa4/tgXJgtcnS46dVdmMpfk9FJK20R7PoHSAPU0FfY3VOiJQwHPAoFhvBKOaKmbIbftI1O4oAEQ2SJ2ac3ygFgD95xQoSX5/pP3+ZWjV5M5VEHK19JwHgHaXxPP980w4xFi9oRGrekWPH8vcqB25cNmGNBdRWSVlxw1lOwrVFz+zjp2LqXKTl88s23Q2UIlmYzKp77t12GnqSBTMmJeeGtxilRo6cCSoSRh5pt2sz/9Zm5emJPTy+q7QjFSXvXp2Zj6fzcEtZkWWUJ/lHDThk5gukt95i5akyeit5T1Bb8msplXPYDFNisCQjF9+OCIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8uOBREzV+JpRFrnzhXP6qrDXJeMxIcrPYvMmZ1F7gnw=; b=JOJcf3DCkT61yHqsyN1m7Z92O8lcDzQlAhtPfIZ9NE2FXilzdFI67neff6eGWDUSnL0kA/yBTTgpLqEmtBahbFN85DaH9WRUoqsSk/MWywcd9ZFUUnpgnF002RAa7k6FmoxCRmZvsqKUmwg1G4LRvwlCiUdV2TQRF56ZPF/ecjY= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Christian.Koenig@amd.com; Received: from DM6PR12MB4401.namprd12.prod.outlook.com (2603:10b6:5:2a9::15) by DM6PR12MB4564.namprd12.prod.outlook.com (2603:10b6:5:2a9::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13; Mon, 27 Apr 2020 08:03:30 +0000 Received: from DM6PR12MB4401.namprd12.prod.outlook.com ([fe80::7949:b580:a2d5:f766]) by DM6PR12MB4401.namprd12.prod.outlook.com ([fe80::7949:b580:a2d5:f766%3]) with mapi id 15.20.2937.023; Mon, 27 Apr 2020 08:03:30 +0000 Subject: Re: [PATCH] drm/amd/display: remove conversion to bool in dc_link_ddc.c To: Jason Yan , harry.wentland@amd.com, sunpeng.li@amd.com, alexander.deucher@amd.com, David1.Zhou@amd.com, airlied@linux.ie, daniel@ffwll.ch, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20200427063726.21363-1-yanaijie@huawei.com> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: Date: Mon, 27 Apr 2020 10:03:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 In-Reply-To: <20200427063726.21363-1-yanaijie@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-ClientProxiedBy: AM0PR05CA0083.eurprd05.prod.outlook.com (2603:10a6:208:136::23) To DM6PR12MB4401.namprd12.prod.outlook.com (2603:10b6:5:2a9::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2a02:908:1252:fb60:be8a:bd56:1f94:86e7] (2a02:908:1252:fb60:be8a:bd56:1f94:86e7) by AM0PR05CA0083.eurprd05.prod.outlook.com (2603:10a6:208:136::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13 via Frontend Transport; Mon, 27 Apr 2020 08:03:28 +0000 X-Originating-IP: [2a02:908:1252:fb60:be8a:bd56:1f94:86e7] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 94ddf153-171c-4a47-8eb2-08d7ea817942 X-MS-TrafficTypeDiagnostic: DM6PR12MB4564:|DM6PR12MB4564: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1923; X-Forefront-PRVS: 0386B406AA X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB4401.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(396003)(136003)(39860400002)(346002)(366004)(376002)(81156014)(6486002)(31696002)(8676002)(8936002)(2906002)(66574012)(36756003)(86362001)(316002)(6666004)(31686004)(2616005)(186003)(5660300002)(16526019)(66476007)(52116002)(478600001)(66946007)(66556008)(921003);DIR:OUT;SFP:1101; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8A9n2qtL/UNZYLxGc1cbOOFgpXB6ln12RBQc302TYu6vzO4W6zKL4eUQjJtJ0krckhK4rzAdacKWJnSp5u9i8/Ocp6/Auo6NffKZ8Bg7TUTnL/0cBuVE9gsRmbDMfz21Pxbigs14IID8DgSIP9Qoqzkea74K/wIAfEOC1TPNiKIY8ypUBeGLZxFzxCfUHvSxseFcPJTkGhPYL3p1spWxXBlDfXF7CFsij+u886wDEZK2RVr21eL4iPijojzf9FA0PCBLCPCNpyF6rjl0YkyQZ9AX4zR1Nh8PPTbpAJs4U0BdlttL2JhUfMxCjzgjiar8Kg7s8RAK0GGbDzD2nH1Sk7LTGmrIKYbFVEzDptglexvfSMFi009FWx3WsG8CBdjGp2arLlo175+kza21aiCCMSrKxKLISHfJPB3uS6FjPzhAwtjiv7gdRVd8xzSkLFNkVFsbh1HDmjOEuEJaiCObEWxG3oM4Ec7cFBEluFnN8Vc= X-MS-Exchange-AntiSpam-MessageData: YN9SriQVKpha0XN/7+/INhEN/ili7MSWG04091jWZPDbsYi5Zebc0zysIz7avvWNa5EBeUQnQVK/mcU+xdOKgpcAjmpe1RRF5APQNlS/crtO9j3g4pp65WnDy+R/mxzEGZuFX5ZYfddZWEWkQwqA1iT3N5uPGKTzPaDISLPiNsOUz5ZkhfmOLfw7qswTEByq8dyky6ciw+xJ1s8SXs8ZO7A7l2n/uT5zNHdXdokKFc4P2ZhHbJoIoFnq9ZFQ8xc19+W3fAvxEs8shEG9jKEPZxPzlCJeLNg0JNIBPoZmgYzHDTQgoldeT3EcZZJkslM0kdlJ3L9pw4ZAoyBgJz0zhJO92Bxi6Fq9ulGMD79IeXhy1TkMn/uT9rL177R3RKNZDCpuYjcRol1THMF1Dy7OEsWcJvkftuDbiuRAi8DXLp2TUw0TxrdAC0QpTN3kOLT2/M0YNFGcDA+K3JC6LeGLM/RE2F52tl9DGUyNm1m3HNdvNpkknZKBleBYl2ie1xB7RPXOmeF8oHHj7BWG9eHsu8D3I15ssNfcOCRvswoSYv3ikCN6MHZbB9pQIqrYk0JSp3QhP3sxvPVF1pOEy/DQavmb0dn7JIUz0jxHvfh7HYVBz6L4eghocotHu2bxV/lJwE1B+6Td80NnkNBVzimtqmjq9vmhAfV9Sl1G4PPjU6h4QlrzAbvpOKXCWwtTGFE/KH0mtR816po7nH3F/c1FUUssXn0e4yOc1ojMniNHzu9BWEE6uCsw6272Vf9A4+ExziC0kYFJU/wHUdD0QR6Nd8465Vk6BdUknKhhJobT8GPY/8rAHy4rLgouiDLfWsUupbZI+3CzU5Ct6CexuUV0XJB5ir70DidfrjiOu3k1GA0= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 94ddf153-171c-4a47-8eb2-08d7ea817942 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2020 08:03:30.3793 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NRi7ArVtqAvv+y3iujiNfwU/oD/OsvguhTfr3mdxpPz1L42NMg0AOWSDlSpOQnym X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4564 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 27.04.20 um 08:37 schrieb Jason Yan: > The '>' expression itself is bool, no need to convert it to bool again. > This fixes the following coccicheck warning: > > drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c:602:28-33: WARNING: > conversion to bool not needed here > > Signed-off-by: Jason Yan Reviewed-by: Christian König > --- > drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c > index 256889eed93e..aefd29a440b5 100644 > --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c > +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c > @@ -599,7 +599,7 @@ bool dal_ddc_submit_aux_command(struct ddc_service *ddc, > do { > struct aux_payload current_payload; > bool is_end_of_payload = (retrieved + DEFAULT_AUX_MAX_DATA_SIZE) > > - payload->length ? true : false; > + payload->length; > > current_payload.address = payload->address; > current_payload.data = &payload->data[retrieved];