From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6975CC43461 for ; Fri, 11 Sep 2020 22:22:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 05DF321D7E for ; Fri, 11 Sep 2020 22:22:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="zRHFg11f" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725890AbgIKWW2 (ORCPT ); Fri, 11 Sep 2020 18:22:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725846AbgIKWWX (ORCPT ); Fri, 11 Sep 2020 18:22:23 -0400 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D20DC061573 for ; Fri, 11 Sep 2020 15:22:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=oH4+VZ5qNTrxbXD6qZNE4hi3fUey1bDby/KSt3LE3hA=; b=zRHFg11fPZXt8J8CzVGvX13pok aUbQTklTiyP49IKV5wJPwFdE9fgXNKZ8Icd81H1KlhyiFwYLd258VjGRmfvPN7SoSTtUY292wyrUV y8HsZMc/b049GqfjN+b5cyk4+Tqf7RSWEqQWEGHbjjdS3id0nvvOjAB/n95nRNwYFWxFoKcp42IgI S3rpPfaU7+McwFjUSqlatYtrBLD10zZZSlMAi+AXdl0qtml4sChYWcYaj/NHKIENXfGd+N1LKAjP7 rZZTCtyrLROm8Mr1WtPzTDpMS0r1LQYjRG6Bgs/jaU1wNhDgo5xX4sD/0bkaTj8AmbS2MRvRGu9Fd 6+x0f+7Q==; Received: from [2601:1c0:6280:3f0::19c2] by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGrQy-0000D4-IG; Fri, 11 Sep 2020 22:22:20 +0000 Subject: Re: first bad commit: [5795eb443060148796beeba106e4366d7f1458a6] scsi: sd_zbc: emulate ZONE_APPEND commands To: Borislav Petkov , Johannes Thumshirn , Damien Le Moal Cc: Christoph Hellwig , "Martin K. Petersen" , Hannes Reinecke , Jens Axboe , lkml References: <20200911195312.GA4110@zn.tnic> <20200911221759.GA2869@nazgul.tnic> From: Randy Dunlap Message-ID: Date: Fri, 11 Sep 2020 15:22:15 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200911221759.GA2869@nazgul.tnic> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/11/20 3:17 PM, Borislav Petkov wrote: > On Fri, Sep 11, 2020 at 09:53:12PM +0200, Borislav Petkov wrote: >> Now, looking at that patch: >> >> 5795eb443060 ("scsi: sd_zbc: emulate ZONE_APPEND commands") >> >> yeah, that doesn't revert cleanly. But it talks about zoned-something >> devices and that rings a bell because you guys broke my zoned device >> once already: > > Ok, so Johannes and I poked a bit on IRC and here it is: > > # CONFIG_BLK_DEV_ZONED is not set. > > Enabling it, fixes the issue. > Uh, you are not saying that enabling that CONFIG_ is the final fix, are you? If so, do I need to enable it, even if I don't have a zoned block device? -- ~Randy