From: Paolo Bonzini <pbonzini@redhat.com>
To: "Radim Krčmář" <rkrcmar@redhat.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: Cornelia Huck <cohuck@redhat.com>
Subject: Re: [PATCH] Revert "KVM: doc: Document the life cycle of a VM and its resources"
Date: Tue, 30 Apr 2019 21:31:12 +0200 [thread overview]
Message-ID: <d75827f2-5334-8bb0-23d0-e507cad7917b@redhat.com> (raw)
In-Reply-To: <20190429132535.8302-1-rkrcmar@redhat.com>
On 29/04/19 15:25, Radim Krčmář wrote:
> This reverts commit 919f6cd8bb2fe7151f8aecebc3b3d1ca2567396e.
>
> The patch was applied twice.
> The first commit is eca6be566d47029f945a5f8e1c94d374e31df2ca.
>
> Reported-by: Cornelia Huck <cohuck@redhat.com>
> Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
> ---
> Documentation/virtual/kvm/api.txt | 17 -----------------
> 1 file changed, 17 deletions(-)
>
> diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt
> index b62ad0d94234..26dc1280b49b 100644
> --- a/Documentation/virtual/kvm/api.txt
> +++ b/Documentation/virtual/kvm/api.txt
> @@ -69,23 +69,6 @@ by and on behalf of the VM's process may not be freed/unaccounted when
> the VM is shut down.
>
>
> -It is important to note that althought VM ioctls may only be issued from
> -the process that created the VM, a VM's lifecycle is associated with its
> -file descriptor, not its creator (process). In other words, the VM and
> -its resources, *including the associated address space*, are not freed
> -until the last reference to the VM's file descriptor has been released.
> -For example, if fork() is issued after ioctl(KVM_CREATE_VM), the VM will
> -not be freed until both the parent (original) process and its child have
> -put their references to the VM's file descriptor.
> -
> -Because a VM's resources are not freed until the last reference to its
> -file descriptor is released, creating additional references to a VM via
> -via fork(), dup(), etc... without careful consideration is strongly
> -discouraged and may have unwanted side effects, e.g. memory allocated
> -by and on behalf of the VM's process may not be freed/unaccounted when
> -the VM is shut down.
> -
> -
> 3. Extensions
> -------------
>
>
Applied, thanks.
Paolo
prev parent reply other threads:[~2019-04-30 19:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 13:25 Radim Krčmář
2019-04-29 13:31 ` Cornelia Huck
2019-04-30 19:31 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d75827f2-5334-8bb0-23d0-e507cad7917b@redhat.com \
--to=pbonzini@redhat.com \
--cc=cohuck@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®