From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f99.google.com (mail-pj1-f99.google.com [209.85.216.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B25730E859 for ; Mon, 15 Jun 2026 18:22:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.99 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781547740; cv=none; b=aQUYlww/Li2S+ex4PEtJyQAsX3Md/6s0mbGtFlZ7nivWN2hRKVQR7kemNQFHqBU6uN/lseQgqalBFIZG1fQbX3aLYu3/c65rbr3Brq68ijWLGTDMXYvDPatH1r2W/zIru7VKAz8XJrXLYME47nvdqReGt6OKk+yvK0fuDlqBdYs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781547740; c=relaxed/simple; bh=8/38Op5eKRc+J+pvdmtc1cvgA2P7BmNwHD44ocXR4w0=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=lnWl3nj8VP2ZJ9w80f6gxvTgQBosjKitISAmQ60ayU3xea/WCj7eYTnerNNLbhycgKfPKreQQuXuuGQkeHBi35LDmUXoeI7EmfkIeDMwxRk9fisH1JT/pU3v2qBIJkJZHiRE0gf2G+0Z/aFay/AhI64o7qlALV2R4sDm4lWqQe0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=dd/ahJmo; arc=none smtp.client-ip=209.85.216.99 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="dd/ahJmo" Received: by mail-pj1-f99.google.com with SMTP id 98e67ed59e1d1-36da8439078so3132677a91.2 for ; Mon, 15 Jun 2026 11:22:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781547739; x=1782152539; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :dkim-signature:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TdTrLX22CnEkWs+gNLjILAm9hmOCrcbz0wPqLfmfk1c=; b=lOaNOKaSA2wSMrPf2HmWuHBY3k9de28h4g99iSRKfhe50ytbwszK25Y1fQM1LvF5OZ zzS+g1hkTit2scsK5gjRgrbPzRSBFQyKgr8uUWPUPFX+rFb3kncd3eInyG8PTls5/LAO PfFhFRPdQpxcx3XPGup0L0SjKbDbxhonvO3uv6cNIbK7cL/41lPeveIiPYzLTxS5aErr 8LyPbmIlQwkpaoNjcPjjmfZrYPoJbH1UluVjuKt9N1emRdtbzhmEXKWyNKNUeBn1XZSz qmVyUAGMvXu2M1q/hgXzbs3VHQGkfsVyxZnUSpFJ1umNQPlTAKNuf8kLgQZvNILX2Ffy tSUw== X-Forwarded-Encrypted: i=1; AFNElJ/so1cDnqEMiWsfy4dztm40s9NGsn9hBxSuHsaIuy4z2EoYLlaoaOagJMU7bosw61r5k7n3QdpwZ11VbCU=@vger.kernel.org X-Gm-Message-State: AOJu0YypVmRSh45CI2ah+RPgaUFQgbdtN+SkvbhA20h7bVIepgZBlK7p fnxwEESHBXWD5aOmhOdYafIvZfhc4OvHRuGGufVPAbZbY1KjzBkrOak5gLOCsswO+pUKy2ykK7y 7ZOoBHRJJjzJpqH3EfxcvgAraALWg31iCnLVlEf7IzJisVmBdvlBRfmj5SIxzCAkJN87XwS7EPO i2+lynsNie+ciz/+S6n4ePs9R5IrQZRSZhdODDjsDihpyV/uc3mTgrptVRtpK8gQcO165K6/w8V Da4TZXbQb34xR8Ncw== X-Gm-Gg: Acq92OEGBp7MPprgFCgN1CysCMX67LHA7VeAas6/d/Zeas1nFGCu9L+MnT1VF17KD6D neUqY69J7ntC2DDwjrLewxCiSNZ8Vi3dtceJzdrSOYN47domGRV1TMjNBV67QiX+r/S5RrttEZU i920k+dRQbfFzbYoERmX4FFfgViMAKsWeDZLGqF6xpliQt8djglX6k7kKT72KbxPXlwYQd4Tlgv yGYFKhoI10p3yG20OzzqS/1wFH7DwOT18BYR8PZV4CGFe6uEzlq7hd2BLmbrReDIdMQAtLbkvq0 +txq1QQqE7rvGMuk0izY8LBI+AHuL+kuILSEtMKNgFUKf0IXMry7wADJXJrrSNuCKEuULzfcrvs HZiGjJsUMcvHTKuhoBSOSTcVcd4ky9IaA9kN4KVuOqQwMxxlNtRLfSzXfyGuB3x64n7/06YL3gG VX8wmK3YgrjIdCOo1oy/+pMAWMBkxk0vn5XxcrE/WTxPq743T4Jmp+mdGlcQ== X-Received: by 2002:a17:90b:1fce:b0:36a:ee1:fc24 with SMTP id 98e67ed59e1d1-37c52840801mr438262a91.8.1781547738753; Mon, 15 Jun 2026 11:22:18 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-117.dlp.protect.broadcom.com. [144.49.247.117]) by smtp-relay.gmail.com with ESMTPS id 98e67ed59e1d1-37c52099db6sm40733a91.0.2026.06.15.11.22.18 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Jun 2026 11:22:18 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-dl1-f71.google.com with SMTP id a92af1059eb24-139553dd8acso3524698c88.0 for ; Mon, 15 Jun 2026 11:22:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1781547737; x=1782152537; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=TdTrLX22CnEkWs+gNLjILAm9hmOCrcbz0wPqLfmfk1c=; b=dd/ahJmo9AvjxtMAR/hqTiRTvyZxK13NoTWmQ9/P1tpdIiHNr+fksSCwMtDSN+kTnq D2R3hpObND3UidOwohzHrMqpmsdpsxlXeK+MBJbxLG7ZgKPAw4ZNDoRURsB5u25k9elC scEddXl285HqKWliFntc78yftBGNHoZdYlqnw= X-Forwarded-Encrypted: i=1; AFNElJ9eInJJmaLou3e+lDglVURqoIHD7e9XdEHKM1jcywyJ+H8IJuufObK+6s20x0oP5gQYM5rZumGUmGyBIRc=@vger.kernel.org X-Received: by 2002:a05:7022:23a5:b0:137:ae1d:5b58 with SMTP id a92af1059eb24-13985f0558amr104279c88.20.1781547736950; Mon, 15 Jun 2026 11:22:16 -0700 (PDT) X-Received: by 2002:a05:7022:23a5:b0:137:ae1d:5b58 with SMTP id a92af1059eb24-13985f0558amr104254c88.20.1781547736357; Mon, 15 Jun 2026 11:22:16 -0700 (PDT) Received: from [10.14.5.238] ([192.19.161.248]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1384b96d6c4sm11427504c88.9.2026.06.15.11.22.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jun 2026 11:22:15 -0700 (PDT) Message-ID: Date: Mon, 15 Jun 2026 11:22:14 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] phy: broadcom: brcm-usb: unwind late probe failures To: Pengpeng Hou , Al Cooper , Broadcom internal kernel review list , Vinod Koul , Neil Armstrong , linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org References: <20260615070123.51155-1-pengpeng@iscas.ac.cn> Content-Language: en-US From: Justin Chen In-Reply-To: <20260615070123.51155-1-pengpeng@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 6/15/26 12:01 AM, Pengpeng Hou wrote: > brcm_usb_phy_probe() registers a PM notifier and may create a sysfs group > before registering the OF PHY provider. If provider registration fails, > probe returns the error with those resources still active. > > Track which optional resources were installed and remove them on the late > provider-registration failure path. Use the same state in remove() so > cleanup matches probe progress. > > Signed-off-by: Pengpeng Hou Reviewed-by: Justin Chen