From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] arm64: dts: exynos8895: Add camera hsi2c nodes
Date: Mon, 16 Dec 2024 09:46:02 +0100 [thread overview]
Message-ID: <d75a63c9-5bfe-48b7-bb8f-bae415897f3b@kernel.org> (raw)
In-Reply-To: <20241214220750.723354-1-ivo.ivanov.ivanov1@gmail.com>
On 14/12/2024 23:07, Ivaylo Ivanov wrote:
> Add nodes for hsi2c1-4 (CAM0-3), which allows using them.
>
> Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
> ---
> arch/arm64/boot/dts/exynos/exynos8895.dtsi | 44 ++++++++++++++++++++++
> 1 file changed, 44 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos8895.dtsi b/arch/arm64/boot/dts/exynos/exynos8895.dtsi
> index 90b318b2f..36657abfc 100644
> --- a/arch/arm64/boot/dts/exynos/exynos8895.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos8895.dtsi
> @@ -292,6 +292,50 @@ pinctrl_peric1: pinctrl@10980000 {
> interrupts = <GIC_SPI 430 IRQ_TYPE_LEVEL_HIGH>;
> };
>
> + hsi2c_1: i2c@10990000 {
> + compatible = "samsung,exynos8895-hsi2c";
There is no such compatible. Your changelog part or cover letter must
always explain where the missing bindings are.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-12-16 8:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-14 22:07 Ivaylo Ivanov
2024-12-16 8:46 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d75a63c9-5bfe-48b7-bb8f-bae415897f3b@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ivo.ivanov.ivanov1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®