mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Maíra Canal" <mcanal@igalia.com>
To: Henry Zhang <henryzhang62@gmail.com>,
	Maxime Ripard <mripard@kernel.org>,
	Dave Stevenson <dave.stevenson@raspberrypi.com>
Cc: Raspberry Pi Kernel Maintenance <kernel-list@raspberrypi.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/5] drm/vc4: dsi: Make failed reads visible and recoverable
Date: Wed, 18 Nov 2026 11:35:12 -0300	[thread overview]
Message-ID: <d76571d7-6c5e-4a36-85e3-db5a5b0cc2aa@igalia.com> (raw)
In-Reply-To: <20261028164539.3471833-1-henryzhang62@gmail.com>



On 28/10/26 13:45, Henry Zhang wrote:
> DSI reads on the Raspberry Pi 4 (vc4, DSI1) can fail in two ways that
> the caller cannot handle:
> 
> - A peripheral that detected an error answers a read with an
>    Acknowledge and Error Report. vc4 copies its two bytes into the
>    caller's buffer and returns success, so the error bits look like
>    register contents (patch 2). An HSTX timeout can be reported as a
>    success as well (patch 1).
> 
> - After a read whose bus turnaround times out, every following DSI
>    transfer times out as well, until the display is switched off and on
>    (patch 5).
> 
> [...]
Applied the first patch (1/5) to drm-misc-fixes, thanks!

I'll leave the review of the rest of the patches for Dave, as he has
more expertise on the DSI side. Anyway, you should consider addressing
Sashiko's comment on 4/5.

Best regards,
- Maíra

      parent reply	other threads:[~2026-11-18 14:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-28 16:45 Henry Zhang
2026-10-28 16:45 ` [PATCH v4 1/5] drm/vc4: dsi: Set the transfer result before completing the transfer Henry Zhang
2026-10-28 16:45 ` [PATCH v4 2/5] drm/vc4: dsi: Don't return error reports as read data Henry Zhang
2026-10-28 16:45 ` [PATCH v4 3/5] drm/vc4: dsi: Rate-limit error interrupt messages Henry Zhang
2026-11-18  0:11   ` Henry Zhang
2026-10-28 16:45 ` [PATCH v4 4/5] drm/vc4: dsi: Serialize host transfers Henry Zhang
2026-10-28 16:45 ` [PATCH v4 5/5] drm/vc4: dsi: Recover from a timed-out transfer Henry Zhang
2026-11-18 14:35 ` Maíra Canal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d76571d7-6c5e-4a36-85e3-db5a5b0cc2aa@igalia.com \
    --to=mcanal@igalia.com \
    --cc=airlied@gmail.com \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=henryzhang62@gmail.com \
    --cc=kernel-list@raspberrypi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®