From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1D8BC6FA83 for ; Tue, 27 Sep 2022 18:43:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231468AbiI0SnU (ORCPT ); Tue, 27 Sep 2022 14:43:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231290AbiI0SnR (ORCPT ); Tue, 27 Sep 2022 14:43:17 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C490F3736; Tue, 27 Sep 2022 11:43:15 -0700 (PDT) Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28RIHat5007239; Tue, 27 Sep 2022 18:43:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=gR4Pn4q136Weq5jaeUge3M1T4dRq5PIIMbxgLr4u+D4=; b=e4STaSNNclop8Rq4IRgHyCUI54isGrYHyOo4bxa02WzM8fAH+3r/mFragTkA/5cxp43H QWRpA8kzMYYmPiRJHQQ8/nr3teJt8AuUrcXFgd9WiZ34owRCeGkpKPtaNEnVIb2RZl9e oX0gG+FPO9OSClYFgzv8KYEq5BCt+YX+2zCet4whRkOPJGfB0HjQ18gVLDYyyIKBmkUq g8npiV71BChsUgCcuTP1g8RFdHVz6j3jTO7HIgJ/G9cbys+9QNhvz6UMu1lOPe1YmRJ4 lO6QOAnduxMImoMdsb1Nzl7703XYrUBIC7S4HTrSYq18CH7ZTWPqptPZIZ8QSZ5NOiRp 2Q== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3jsrwfqcuu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Sep 2022 18:43:00 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 28RIgxYj025366 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Sep 2022 18:42:59 GMT Received: from [10.111.168.84] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Tue, 27 Sep 2022 11:42:55 -0700 Message-ID: Date: Tue, 27 Sep 2022 11:42:53 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH v2 09/10] drm/msm/dp: drop modeset sanity checks Content-Language: en-US To: Johan Hovold CC: Johan Hovold , Douglas Anderson , Dmitry Baryshkov , "Rob Clark" , Andrzej Hajda , "Neil Armstrong" , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Daniel Vetter , Sean Paul , Stephen Boyd , Bjorn Andersson , "Manivannan Sadhasivam" , Kuogee Hsieh , Steev Klimaszewski , , , , References: <20220913085320.8577-1-johan+linaro@kernel.org> <20220913085320.8577-10-johan+linaro@kernel.org> From: Abhinav Kumar In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: Unl2EMpDkPDOs-OWU28xnutJtpITwt9V X-Proofpoint-GUID: Unl2EMpDkPDOs-OWU28xnutJtpITwt9V X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-27_09,2022-09-27_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 spamscore=0 malwarescore=0 adultscore=0 bulkscore=0 mlxscore=0 impostorscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 mlxlogscore=807 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2209270116 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/27/2022 12:14 AM, Johan Hovold wrote: > On Mon, Sep 26, 2022 at 11:17:20AM -0700, Abhinav Kumar wrote: >> On 9/13/2022 1:53 AM, Johan Hovold wrote: >>> Drop the overly defensive modeset sanity checks of function parameters >>> which have already been checked or used by the callers. >>> >>> Reviewed-by: Dmitry Baryshkov >>> Signed-off-by: Johan Hovold >> >> The change LGTM, hence >> >> Reviewed-by: Abhinav Kumar >> >> I think we can use below fixes tag so that we can pick up this entire >> series for the fixes cycle. >> >> Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driver support") > > Perhaps that's a requirement for drm, but I wouldn't add a Fixes tag for > this otherwise as it's not a bug. > > You also have to watch out for Sasha and his autosel scripts which will > probably try to backport this to stable if it finds a Fixes tag. > > Johan Discussed with Rob on IRC, we will apply everything except the last two patches of this series in the -fixes and take these two for the next kernel rev push.