From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6705221297 for ; Fri, 18 Jul 2025 11:45:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752839143; cv=none; b=vGRDAjshs8SVesOolhYeDXCb3MXZEOm/SuezT+WAHM+dMOXekZ0S/1r0bQfrqVU9rgF2jfvrG9LAt4SEBjfs1LaroHY6qziGIlEcTxfSwNcQ142W06WU6eD4V71s9DuebilBmGR+LVYT4J4o2O9tcMVylWyYFZWsuSJaKAHA40g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752839143; c=relaxed/simple; bh=/0TgAXFrJ3G9JZVLfywNJKFXbMtIAldNf+h11vvIcww=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SteI2l1TbNqSH9U5UQI9J7VQk43toLCHzpBSHbw3nonK1FNtITVil9MzfJzpXwWBpjdu3al1S8iUydK3dza+aCyHEWdaDn6uLZkwsfB9KS8hKHbHxKwkrSB0T4+R1+NoVtWS9XCu9NOPAHl9nKcBnerlcmRsY2YHSJus/rTheLk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ORdx3lTF; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ORdx3lTF" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56I9Hoet016243 for ; Fri, 18 Jul 2025 11:45:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= yUaV1HqBuNNURcq0v8sid0UGGjZ9IBb7QqFSuycdBC0=; b=ORdx3lTF8ULYQ2Ii uZ50eu9M/vGD7pOjMCUm7rWUdDEoVWCiRwtj7JKqxLvjKSZ7EcKUOTHiTP9qDf9p cXS74Yj1UjtzIECpy/xpWGrvKb9vvlCRvrhL+hVanPvaBhjyUzoIoEd+YbxWdkGb tMjsikc2hltx3584R6G06+x6XxsLmbZeTs9ueqRPJT904hP31CuVNdXDW579ih+2 ByxlRGH9Ac6SdenkyQY4zlvuvOu0bcYIz4J3Nh71Hr2+1P6eVwa84XRzl7ukp8f7 7mGakrAyeXUfTUY6v/XAObj6gDu4zxomX3s/q77pmTttAAR2+4p+jZRSa0DexNLp B9GiDg== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47y3tc37en-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 18 Jul 2025 11:45:40 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4ab5e4f4600so4130531cf.2 for ; Fri, 18 Jul 2025 04:45:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752839140; x=1753443940; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yUaV1HqBuNNURcq0v8sid0UGGjZ9IBb7QqFSuycdBC0=; b=GUx5ROXZ9sbgQwXgRssWU03X9K04NFGBMbqSB9N/POVqLNEpJe/mqLA1B3fADBtcXb MIfBwrBvnOqgZHxAQ8i3eZ1kHUFsi80SX0FZkfaAIys/3aObc6nGiQUOTm3JxmrqDneg IbP6l4/AB8fAlgRNgQl9CztNXMiMFXUWMS9Buq8tMUGHOnzJUh2Ls0TY7s+csk/+Gvj0 RCgqOyPpLeH/KOghxiCPsb+8VfnszastxF9aQFDTD7dTlzIXspRoj5fadFXeqAkIwTaA zlPyCbE3oDs3HqZyY/nRMhybTG86+IQSjfAPFcumGpcATnSCvlVtAQXZ1U49Y9O8tx+o DUdg== X-Forwarded-Encrypted: i=1; AJvYcCUie7A63dxJHP5HxJj4f5AJPI8TLMmQtlGthtahajKZdZSEDccKMpXl7pCcToqjPwyXvvZDT4vVJ6xQWhI=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0asULWoBPiPlPImuhrHVpuY4R5n9u0OT1XoiY0GjfEJfBNe2c ZG7q7OHPNb1E4LXFiIX01rNZVB5d0HwalTcdoJGMshkEDtQIA2Upl725r/vV5z53YPrx36pt8nr RahpjeRiCUOfmtIQFic+BZKawHluOJZj8pUe74tyinzwT6BLyYYlGb5ogqY7e1yY3hao= X-Gm-Gg: ASbGncvDPjwg6qfB05uRfA6mSCdvaVexZGQnBSZNMEb+WHL1D4N2UwodDmbtLDyOeVv wyHn6wlyEEFRf3kbbOCJQ7FuP5LbhUd+ZSiTdecL/4K3/0ZF2TPcQcC+yW6g+FgMX1gY1yNXGwl YkjWwPfXxhHRIukS5ggqN18NDbGGqokN+MWpsg0B80iTOSZH659rqmSI/ukTCtET5/mk0vH0lGf vSUK95kf5w1wOoOKG0ilVUS/e+OtAsg2ts7+Dq402J1CKApsHbeDZ5oAkY6FwysAegFUW9qhFy7 6VdNk0I2DODE0XwiSqLK5vW7WX/yeMCNOrxQt29sq+mAi9DRS08ONFF07AE8RNes14A4CCgCi4a MXrIRm4W77B5r3G+goZQ3 X-Received: by 2002:ac8:59d4:0:b0:4ab:723e:fba7 with SMTP id d75a77b69052e-4ab90abeff7mr67168271cf.7.1752839139602; Fri, 18 Jul 2025 04:45:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEeVattD6J0aqEqPEisHXQsvCa04VOP4L7XrZDnR309zipodefZf5SE1uSb44GBWau8neunmw== X-Received: by 2002:ac8:59d4:0:b0:4ab:723e:fba7 with SMTP id d75a77b69052e-4ab90abeff7mr67167661cf.7.1752839138049; Fri, 18 Jul 2025 04:45:38 -0700 (PDT) Received: from [192.168.143.225] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aec6c79a0basm108012266b.19.2025.07.18.04.45.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Jul 2025 04:45:37 -0700 (PDT) Message-ID: Date: Fri, 18 Jul 2025 13:45:34 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/6] arm64: dts: qcom: ipq6018: Add the IMEM node To: Kathiravan Thirumoorthy , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250708-imem-v2-0-692eb92b228e@oss.qualcomm.com> <20250708-imem-v2-3-692eb92b228e@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=Z5PsHGRA c=1 sm=1 tr=0 ts=687a33e4 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=EUspDBNiAAAA:8 a=IiJQ3bnfW8p6AAHgo9AA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-ORIG-GUID: u2GbDKArdOok4gBX54aZSBS5HWdzWS-j X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzE4MDA5MiBTYWx0ZWRfXx0Xop/C9u2TH fnc/ynP7f+7oZcWvM6/sopByy85CYMw8dmTIUeuwX0asyjQ4IYjEFoH2bsMCSiTyjCrBS/+dRf3 KtMJxpoC0MD4VIesATAmW+Ja0fh/qZTECR9IMqMu3xO3pE1+QuNfayHbKBz61yso9BThrwmCvIn 1E6es9aDGtoybrMCkxEkuknrKtlaKQRnYqz/5KsnvEzPKGuUcAu2KGtZ9/JaHYqJoQ9uO3+eCKE Re8ZFvXVeEnISMbrrFDBtKWKtD2oN73K2CBJt5jqBAP0pRXO+hTmrCP+15Ig0KoH7zbQxPGsc79 kvzGrAtxy9+D+8pi3h5E6+lCjZYVV9rqTM4iusW+M85ObyuRx7ClFWlSKvOFRtZjpL+27U2Gsmb rC96qyrHo6h3CmJvF8NIHQt9S6ReAlF25dRyeBDDCp6WYuUTDbAzECKa3Zf/sxwxCGdy275m X-Proofpoint-GUID: u2GbDKArdOok4gBX54aZSBS5HWdzWS-j X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-07-18_02,2025-07-17_02,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxlogscore=984 suspectscore=0 spamscore=0 clxscore=1015 mlxscore=0 malwarescore=0 phishscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 bulkscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507180092 On 7/9/25 6:28 AM, Kathiravan Thirumoorthy wrote: > > On 7/8/2025 7:49 PM, Konrad Dybcio wrote: >> On 7/8/25 7:39 AM, Kathiravan Thirumoorthy wrote: >>> Add the IMEM node to the device tree to extract debugging information >>> like system restart reason, which is populated via IMEM. Define the >>> IMEM region to enable this functionality. >>> >>> As described, overall IMEM region is 32KB but only initial 4KB is >>> accessible by all masters in the SoC. >>> >>> Signed-off-by: Kathiravan Thirumoorthy >>> --- >>> Changes in v2: >>> - Rounded off the size to 0x8000 (Konrad) >>> - Represent the reg's address space in hexadecimal format (Krzysztof) >>> --- >>> In 'ranges' property 0 is used instead of 0x0 to align with the existing >>> format. >>> --- >>>   arch/arm64/boot/dts/qcom/ipq6018.dtsi | 9 +++++++++ >>>   1 file changed, 9 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi >>> index bfe59b0208415902c69fd0c0c7565d97997d4207..3b9e40045906b26b94e2d2510b0570d3eaf084ce 100644 >>> --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi >>> @@ -659,6 +659,15 @@ qpic_nand: nand-controller@79b0000 { >>>               status = "disabled"; >>>           }; >>>   +        sram@8600000 { >>> +            compatible = "qcom,ipq6018-imem", "syscon", "simple-mfd"; >>> +            reg = <0x0 0x08600000 0x0 0x8000>; >>> +            ranges = <0 0 0x08600000 0x8000>; >>> + >>> +            #address-cells = <1>; >>> +            #size-cells = <1>; >>> +        }; >> On this platform, shouldn't it be 0x6860_0000? > > Actually, that's from the RPM perspective. From the ARM side, the address is 0x0860_0000. The hardware docs show the RPM view by default, so please switch to the ARM view. Right, this is an odd default.. Reviewed-by: Konrad Dybcio Konrad