From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4772C433B4 for ; Fri, 30 Apr 2021 07:15:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A8CF56143A for ; Fri, 30 Apr 2021 07:15:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231145AbhD3HQq (ORCPT ); Fri, 30 Apr 2021 03:16:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:37009 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229922AbhD3HQo (ORCPT ); Fri, 30 Apr 2021 03:16:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619766956; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=28TamhQnx/WTmTYJRRukTbFCMkH+GJB8ptneJQNf94c=; b=a/h2RXTz3elZH9Q3ky3ZB8QY6ojoZO1C8jAtL2ODlZwdfsEQGfd1V1h5broHEiLkAJt5O+ grj3CrbDaisb8PEJ9lHlQMr4weprWVBkAK0zCRu4SNVmK6Qe+JHYeHGlEgBvX44DFKcPnY JCGzXjl2uvlFxfNLg0oPTd40nxi9eDk= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-386-hoQI7sAhOwevpHpF1OZDrw-1; Fri, 30 Apr 2021 03:15:54 -0400 X-MC-Unique: hoQI7sAhOwevpHpF1OZDrw-1 Received: by mail-ej1-f72.google.com with SMTP id bi3-20020a170906a243b02903933c4d9132so3076626ejb.11 for ; Fri, 30 Apr 2021 00:15:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=28TamhQnx/WTmTYJRRukTbFCMkH+GJB8ptneJQNf94c=; b=BlsPyvKI8EP7mKDF8vcChCdcAdbPzTINZ0jkX4IJ3VS0nyck7k30ocCjoQqbis2afM PEmsrk5EZTYGUnM3bBhPOh9mPCkfq+OH+btdaA1Bo59qwbvwtP3X+6RzIJ84K26VnvCf UWOm5q4QMhe/lZi3WY1LEjFUkkRI0Kp8irMETBFknnlPLiWh6TTnqPTUlxzczAkHDEeB 1p1/ZOb/ZQ4qZ26/ZClBA4kCwXXcN6NqvDRinPFz1OM5HCpEusoX3MANT8ZQH/9T2r1l s1lNiTIkDEcqCbhRjY8ebN3CJntjGMDNWGZ4VZ088mbabtM51JfY/G0tkqXMedMnTWjO TWtA== X-Gm-Message-State: AOAM530Pb2RxYHMDdkiYaFx6WwrbU17xACPJKig12hpbABUG+jk37wZ/ 8VH+M2n7caAifW/q37hRM0QsdOp8jmEOvyNN3lJNujFaiRVPTkx58uYiQ5wI+aBY6q+dEl3toYt /5gD4fFQO5bvempUQ85z4VOEU X-Received: by 2002:a17:906:7d82:: with SMTP id v2mr2737698ejo.524.1619766953310; Fri, 30 Apr 2021 00:15:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyAQdeuZInXmsMkcogPQFLA3VeuUhCp7LSV5xe8bJEmH45eKyauY8xcO7cSejDdlfL6uAEUlg== X-Received: by 2002:a17:906:7d82:: with SMTP id v2mr2737676ejo.524.1619766953147; Fri, 30 Apr 2021 00:15:53 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id i19sm1367781ejd.114.2021.04.30.00.15.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Apr 2021 00:15:52 -0700 (PDT) Subject: Re: [PATCH 1/4] x86/xen/entry: Rename xenpv_exc_nmi to noist_exc_nmi To: Steven Rostedt , Lai Jiangshan Cc: linux-kernel@vger.kernel.org, Lai Jiangshan , Thomas Gleixner , Sean Christopherson , Andi Kleen , Andy Lutomirski , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, Josh Poimboeuf , Uros Bizjak , Maxim Levitsky , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Peter Zijlstra , Alexandre Chartre , Joerg Roedel , Jian Cai , xen-devel@lists.xenproject.org References: <20210426230949.3561-1-jiangshanlai@gmail.com> <20210426230949.3561-2-jiangshanlai@gmail.com> <20210428172714.53adac43@gandalf.local.home> From: Paolo Bonzini Message-ID: Date: Fri, 30 Apr 2021 09:15:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210428172714.53adac43@gandalf.local.home> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/04/21 23:27, Steven Rostedt wrote: > On Tue, 27 Apr 2021 07:09:46 +0800 > Lai Jiangshan wrote: > >> From: Lai Jiangshan >> >> There is no any functionality change intended. Just rename it and >> move it to arch/x86/kernel/nmi.c so that we can resue it later in >> next patch for early NMI and kvm. > > Nit, but in change logs, please avoid stating "next patch" as searching git > history (via git blame or whatever) there is no such thing as "next patch". Interesting, I use next patch(es) relatively often, though you're right that something like "in preparation for" works just as well. Yes, it's the previous in "git log", but you get what it's meant in practice. :) Paolo > Just state: "so that we can reuse it for early NMI and KVM." > > I also just noticed the typo in "resue". Or maybe both NMI and KVM should > be sued again ;-) > > -- Steve >