From: "Arnd Bergmann" <arnd@arndb.de>
To: "Kalle Valo" <kvalo@kernel.org>, "Arnd Bergmann" <arnd@kernel.org>
Cc: "Miri Korenblit" <miriam.rachel.korenblit@intel.com>,
"Johannes Berg" <johannes.berg@intel.com>,
"Emmanuel Grumbach" <emmanuel.grumbach@intel.com>,
"Gregory Greenman" <gregory.greenman@intel.com>,
"Daniel Gabay" <daniel.gabay@intel.com>,
"Benjamin Berg" <benjamin.berg@intel.com>,
"Ilan Peer" <ilan.peer@intel.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iwlwifi: work around -Wenum-compare-conditional warning
Date: Fri, 18 Oct 2024 19:07:05 +0000 [thread overview]
Message-ID: <d78b5354-b265-4e45-9a6a-996273026402@app.fastmail.com> (raw)
In-Reply-To: <87a5f1qtts.fsf@kernel.org>
On Fri, Oct 18, 2024, at 16:06, Kalle Valo wrote:
> Arnd Bergmann <arnd@kernel.org> writes:
>
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> This is one of only three -Wenum-compare-conditional warnings we get
>> in randconfig builds:
>>
>> drivers/net/wireless/intel/iwlwifi/mvm/sta.c:4331:17: error: conditional expression between different enumeration types ('enum iwl_fw_sta_type' and 'enum iwl_sta_type') [-Werror,-Wenum-compare-conditional]
>> 4331 | u32 type = mld ? STATION_TYPE_PEER : IWL_STA_LINK;
>> | ^ ~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~
>>
>> This is a false positive since the code works as intended, but the
>> warning is otherwise sensible, so slightly rewrite it in order to
>> not trigger the warning.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Is this and the other rtw89 patch for current release or -next?
Up to you, the warning has existed for a long time at W=1
level, so the patch applies to current and stable kernels
as well, but it's not a regression or particularly important.
It would be nice to turn on the warning by default in 6.13
once the three patches I sent get applied.
Arnd
next prev parent reply other threads:[~2024-10-18 19:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 15:18 Arnd Bergmann
2024-10-18 16:06 ` Kalle Valo
2024-10-18 19:07 ` Arnd Bergmann [this message]
2024-10-21 7:30 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d78b5354-b265-4e45-9a6a-996273026402@app.fastmail.com \
--to=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=benjamin.berg@intel.com \
--cc=daniel.gabay@intel.com \
--cc=emmanuel.grumbach@intel.com \
--cc=gregory.greenman@intel.com \
--cc=ilan.peer@intel.com \
--cc=johannes.berg@intel.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miriam.rachel.korenblit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®