From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752712AbdGYPiW (ORCPT <rfc822;w@1wt.eu>);
        Tue, 25 Jul 2017 11:38:22 -0400
Received: from esa6.microchip.iphmx.com ([216.71.154.253]:9095 "EHLO
        esa6.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752244AbdGYPiU (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 25 Jul 2017 11:38:20 -0400
X-IronPort-AV: E=Sophos;i="5.40,411,1496127600"; 
   d="scan'208";a="2526017"
Subject: Re: [PATCH v4 7/9] ASoC: atmel-classd: remove aclk clock from DT
 binding
To: Quentin Schulz <quentin.schulz@free-electrons.com>,
        <mturquette@baylibre.com>, <sboyd@codeaurora.org>,
        <robh+dt@kernel.org>, <mark.rutland@arm.com>, <lgirdwood@gmail.com>,
        <broonie@kernel.org>, <alexandre.belloni@free-electrons.com>,
        <linux@armlinux.org.uk>, <boris.brezillon@free-electrons.com>,
        <perex@perex.cz>, <tiwai@suse.com>
CC: <cyrille.pitchen@wedev4u.fr>, <thomas.petazzoni@free-electrons.com>,
        <linux-clk@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <alsa-devel@alsa-project.org>,
        <linux-arm-kernel@lists.infradead.org>
References: <cover.c8ce78c15296190b2aa5c452c0c4512528e28518.1500968090.git-series.quentin.schulz@free-electrons.com>
 <db5404c2be1d59603dd3770c5f95a065fe4c321f.1500968090.git-series.quentin.schulz@free-electrons.com>
From: Nicolas Ferre <nicolas.ferre@microchip.com>
Organization: microchip
Message-ID: <d78d2769-5e05-b1e7-dec8-9b2c86ee3459@microchip.com>
Date: Tue, 25 Jul 2017 17:38:19 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <db5404c2be1d59603dd3770c5f95a065fe4c321f.1500968090.git-series.quentin.schulz@free-electrons.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 25/07/2017 at 09:37, Quentin Schulz wrote:
> Since gclk (generated-clk) is now able to determine the rate of the
> audio_pll, there is no need for classd to have a direct phandle to the
> audio_pll while already having a phandle to gclk.
> 
> This binding is used by no board in mainline so it is safe to be
> modified.
> 
> Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>
> Acked-by: Mark Brown <broonie@kernel.org>
> Acked-by: Rob Herring <robh@kernel.org>

Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

> ---
>  Documentation/devicetree/bindings/sound/atmel-classd.txt |  9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/atmel-classd.txt b/Documentation/devicetree/bindings/sound/atmel-classd.txt
> index 549e701..8985510 100644
> --- a/Documentation/devicetree/bindings/sound/atmel-classd.txt
> +++ b/Documentation/devicetree/bindings/sound/atmel-classd.txt
> @@ -13,13 +13,11 @@ Required properties:
>  	Must be "tx".
>  - clock-names
>  	Tuple listing input clock names.
> -	Required elements: "pclk", "gclk" and "aclk".
> +	Required elements: "pclk" and "gclk".
>  - clocks
>  	Please refer to clock-bindings.txt.
>  - assigned-clocks
>  	Should be <&classd_gclk>.
> -- assigned-clock-parents
> -	Should be <&audio_pll_pmc>.
>  
>  Optional properties:
>  - pinctrl-names, pinctrl-0
> @@ -45,10 +43,9 @@ classd: classd@fc048000 {
>  			(AT91_XDMAC_DT_MEM_IF(0) | AT91_XDMAC_DT_PER_IF(1)
>  			| AT91_XDMAC_DT_PERID(47))>;
>  		dma-names = "tx";
> -		clocks = <&classd_clk>, <&classd_gclk>, <&audio_pll_pmc>;
> -		clock-names = "pclk", "gclk", "aclk";
> +		clocks = <&classd_clk>, <&classd_gclk>;
> +		clock-names = "pclk", "gclk";
>  		assigned-clocks = <&classd_gclk>;
> -		assigned-clock-parents = <&audio_pll_pmc>;
>  
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&pinctrl_classd_default>;
> 


-- 
Nicolas Ferre