From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEF134AD4A1 for ; Mon, 5 Oct 2026 14:37:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791211077; cv=none; b=lZoYQn4/x/buqhn22h1jhXr7rzy5hoqRh5NqrOyP7Qk1ah3ZQjHEP/27R5vaIMsQcnOFy+HhEOxU6ItUSmUy2JjpDnq7S7Aw10Uuw1u2kLLnKNFxZ7k51u8NMT+0ktlObvOx5uI+N1L49eepFpgw5K3PC/C3QUwf8EeUhp+s7fU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791211077; c=relaxed/simple; bh=2SzhxrWuyWL8OXijp7aZ7p5Wq1jUPOcr0yrxzKmNLyM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gsfy0kSEzmpPJa4ZSwCobQ0ULfzxwBJtpuppSz3+0Cu9S8HLAYvzJkPhYhsXuMZUqV1V7oRnqHwNWxmR0vxs60ZfoIxQ3XGbWqlWbkU7uvZxznYy8tdmqhafjDtI2Ifq//41cDl/04qYRcURJD3SaR24xBWyBoD8aFymL8rsDxU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JOW+uXb3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Zvx6oON0; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JOW+uXb3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Zvx6oON0" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 695EP4KV2015019 for ; Mon, 5 Oct 2026 14:37:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2eIAsOhaVPTC3xP3VsP6J8u+4Zt4CiPhaYh6vvOX53I=; b=JOW+uXb3RPBy2i2f k0Rq0bqa9hOX+IVfUvD9Hc15GGu/Shfe8BhdR12q0zA6YCSS3XOOc6qgbspcAAxX etRk7wp3EbCbLZm7VgWZNsoOQMND1Qz6cTqndtdcG8k6t4z6aMomDkQmcKbMiOgW aUjlNuZU6utIH9HRoTVqNxQPLhVE76omG/uGadDW6FW6XS+eCGsIiBALvxMnDChE 36WlmRAX7Ru0QtqhJ7eDOBp2uCZtlOiE2SCO4BPgrWAPWoNNl6gpN2nGep1SwiOp LvcRlmt3FdYmy8DhzMsDw+muG5wiaZNbEhqLy/JX7RLBoMSQXLrAR998KYFW8ZPR i70CXg== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4h3xhs2h7j-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 05 Oct 2026 14:37:50 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-3a7fa5e0442so1476068a91.0 for ; Mon, 05 Oct 2026 07:37:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1791211069; x=1791815869; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=2eIAsOhaVPTC3xP3VsP6J8u+4Zt4CiPhaYh6vvOX53I=; b=Zvx6oON0bfWFlX+u9Yl8Ma6aHmTWwBKrRRF3QW6/MCtpykVGhjdCWyrZ8AtTT0qjRQ O+X7h1tKaqsGGY5DT1aZYdQ0nR6wLE+0NXyX5IzHxPjNG5JBd3MbndVHqh7QpiCS7O9S /TokC+18TUw1al4Mig1Hk1SPcMDWyfkwah2d41qD/KJwcMTUFkJH6X1SaRxsj6JqVqRm u3wkHs1u1Xp76bAOU79fdekxa18fMV7HZDnYA+/T/kobfJeDu0bwqnG6LxQz1r4EpSPO SZ9VvidD65hR+kmOfJYFtV/e9ckQz+6dwp2Leem8XD42eS9Zk3qSF9rw4E/JgwHPH6ts 6QCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791211069; x=1791815869; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=2eIAsOhaVPTC3xP3VsP6J8u+4Zt4CiPhaYh6vvOX53I=; b=jAbwOMRMLFfW0+vx+DrlKbFHE4A3KRMgGpC814XjHZRSrNLaHxLSXr94o9XGr+lvAQ pZQ7FN+iaoLLgbEL9JVsjYpJP/zGbYe4YvLVKqFm1iNq84arDD+X2W5B77xadcqi3BkT 8LvmYvgciPSDveOVpMR7rGoeHYNstQJJzQ0ajHYiXph5/Mm/uP47y2yJ0Uofq2dXheyP mFlDrGJZ5SRLqACh68t6qnINowq+Qy62NsHPPleotDxfxyNn/ltM7Ss34gjoCA7Ive4H VRBabXkXWMttfL1sehF837Vpqk4limvPPcCwrS4C9pU40YtNDTaR9xdRwO1EVs2QPAIW 9U4g== X-Forwarded-Encrypted: i=1; AKwUvBxDEEDjrZVgK998vNvI3Sv9uZL1UvrQB/+wLgDf5Q9L9fSA5cBTaglXsUYWH+PnAmz3fE3rSTvg4IcIhlQ=@vger.kernel.org X-Gm-Message-State: AFq9FYKhtxO55ZJZKRkiHJ3hZg/kfyWkM5M0HlveRigxkHVkyibak/U1 gKAvQq0DplmlBKsGgqzBmQEAxJugNSxlvQOm1I/0qOitaruDpIo/uW5ewf94ZYhYyOu/T/nERsK TP+Zl33qMlnA9Au3afD5VXtTK5GOtK572xXBQ0HsyejnEwTr5kbzPGUsjTV+QLQPLE2k= X-Gm-Gg: AYBFou2aiygroozAIAiVdFmQ8S2A5G5lJLKquLHvbfdpMpDzHduzgwsF627kGZCR6TK rgzkeM4nN3XrEJLcCd+fzCBfR5mv0tWLvD7Q5XXvytX7T0ergkJ/AVSzruMnIDv9qLLVij3f+Z3 XgE5AT2z6GXERNsF8O+xIPRrPPQvTnGT19avo57az/yemG4BO0y0LZFqiJjqCIyiwDsMhsJaa2A BmuiWmCYEost7ZayrUOYFa+3OmJIztQW0ofaflGgTh70vwmWflxL/rIzrf0QB/C+TBgaOwdv9a3 YOdYVnwqEUOGALupPpHiaM9G/B2lSO9F9zhbgJyaChUWQ4n9U2YZlc9EFvSfptM6FHwtRErMJhc gG+8sM41uwSOiB4lLZoDr80LdrevBkjnw8T5IzjEDb0XspVUf+rfFOE9zpw== X-Received: by 2002:a17:90a:e7ce:b0:3a7:8c68:6446 with SMTP id 98e67ed59e1d1-3a78c687f95mr6625970a91.63.1791211069325; Mon, 05 Oct 2026 07:37:49 -0700 (PDT) X-Received: by 2002:a17:90a:e7ce:b0:3a7:8c68:6446 with SMTP id 98e67ed59e1d1-3a78c687f95mr6625943a91.63.1791211068860; Mon, 05 Oct 2026 07:37:48 -0700 (PDT) Received: from [192.168.1.20] (33.sub-75-218-193.myvzw.com. [75.218.193.33]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3a6dcbdd97fsm7594125a91.0.2026.10.05.07.37.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Oct 2026 07:37:48 -0700 (PDT) Message-ID: Date: Mon, 5 Oct 2026 07:37:46 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] wifi: ath12k: skip hardware rfkill setup on Microsoft Surface Pro 11 To: =?UTF-8?Q?Fran=C3=A7ois_Roux?= , Jeff Johnson Cc: Manivannan Sadhasivam , Krzysztof Kozlowski , Konrad Dybcio , Bjorn Andersson , =?UTF-8?Q?J=C3=A9r=C3=B4me_de_Bretagne?= , Dale Whinham , ath12k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20261004165132.4313-1-franzelfranzel@gmail.com> From: Jeff Johnson Content-Language: en-US In-Reply-To: <20261004165132.4313-1-franzelfranzel@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: sty63Vt6Yf_r8SI-aoT3PrJnj9kO56tV X-Proofpoint-GUID: sty63Vt6Yf_r8SI-aoT3PrJnj9kO56tV X-Proofpoint-Spam-Info: AW1haW4tMjYxMDA1MDA1NyBTYWx0ZWRfX6ZkbunTiU/1F JG0p0D/PU4u1jO3/M8uKuxw+4Wdg2gR/yy9Nnz7wK2gjQeRRi0tlMh0jQVFWkLjrb7G+ZuHaCkT /oNXlCLShyPAdwZ7xO/rtb1BakNs4+o= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDA1MDA1NyBTYWx0ZWRfX4cfXZExasrqj 8fjSl8NGufHjNfmu1Rmb+JKdhH9s/JSLUQrBD/okNtPg/WlnHOgeRq2uMb4rF+1coYmIVP3HmyE XPYm7Dh/ApgBU2Zd6XF8UT84MmORn4pjyqIHo5nRZnwDOevS/YL2VMB0/jqXQUNBOtZVm3KZ1Oa 8tMhzYLlTTtns+yjqXuKsKRGlLmwo7vUcZk5nJ7fCCBgmtxfLKwxOjMicBFwLGAUz1mCc3rjvNb CkJtx+p5ZtaBQtu+ffs3HpOZHPeZ7r2TSWsgzxkdRnzURyY0YFqYXzhao2JWYPKJUKbWcOkh1oR UhdfDqOjnborIyO8rjpuSUS7qUDPKbKZmuKPogBy7qM6uhPNspd4gux+JKbxeU/4Z6eQQbnXRBW 6vda6P8JVlsek0xat5Q1Hkl6zfjmAv/CkGEPeoktRLzpEvS8fowTplDmsCINYF4+Y5x3w14Puiz yKWAnN1/zIBmlcuANVg== X-Authority-Analysis: v=2.4 cv=Q6tHcI2a c=1 sm=1 tr=0 ts=6ac3b63e cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=AnolQpdaNwb4XK4FG+QP+g==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=VwQbUJbxAAAA:8 a=pGLkceISAAAA:8 a=7PQHMOqyCB17KHk-lU0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-05_04,2026-10-05_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 bulkscore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 malwarescore=0 impostorscore=0 suspectscore=0 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2610050057 On 10/4/2026 9:51 AM, François Roux wrote: > On the Microsoft Surface Pro 11 (X1E80100, "microsoft,denali"), the > WCN7850 hardware rfkill input reads as "radio off" and the OS has no > way to control it. ath12k enables hardware rfkill handling, so Wi-Fi > stays hard-blocked: > > iwd: Error bringing interface 4 up: Operation not possible due to RF-kill > > ACPI platforms can opt out through ath12k_acpi_get_disable_rfkill(), > but DT platforms cannot. A DT property was proposed for this and > rejected, because it describes what the OS should do rather than the > hardware. The suggested alternative was to handle this machine in the > driver, keyed on the board compatible and the device ID, until a > connector binding can describe a broken rfkill line. Do that. > > Tested on a Surface Pro 11 with next-20260929, booted with the > unmodified mainline DTB: the interface is no longer blocked and > connects. > > Link: https://lore.kernel.org/all/2ixwny6hzumlqmok5cjwutvtk7nzmx4t3dhxc44ao4l2u755pj@n6m7jyxf2o62/ > Suggested-by: Manivannan Sadhasivam > Assisted-by: LLM > Signed-off-by: François Roux > --- > This replaces my RFC series "Allow DT boards to disable WCN7850 hardware > rfkill", which duplicated the disable-rfkill DT property already proposed > and rejected in the Surface Pro 11 series: > > https://lore.kernel.org/all/20261003091509.4822-1-franzelfranzel@gmail.com/ > https://lore.kernel.org/all/20251220-surface-sp11-for-next-v5-2-16065bef8ef3@gmail.com/ > > The code is Manivannan's suggestion from that thread. Jérôme reported > there that the Surface Laptop 7 (microsoft,romulus13/15) has the same > problem. I left it out because I cannot test it. > > drivers/net/wireless/ath/ath12k/core.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/net/wireless/ath/ath12k/core.c b/drivers/net/wireless/ath/ath12k/core.c > index 0c72948f3..dc41a2a7d 100644 > --- a/drivers/net/wireless/ath/ath12k/core.c > +++ b/drivers/net/wireless/ath/ath12k/core.c > @@ -83,6 +83,16 @@ static int ath12k_core_rfkill_config(struct ath12k_base *ab) > if (ath12k_acpi_get_disable_rfkill(ab)) > return 0; > > + /* > + * TODO: On the Microsoft Surface Pro 11, the OS cannot control the > + * WCN7850 hardware rfkill input, which reads as "radio off". Keep > + * hardware rfkill disabled there. Ideally this would come from the > + * connector node of the board DT, but that binding does not exist > + * yet, so handle it in the driver for now. > + */ > + if (of_machine_is_compatible("microsoft,denali") && ab->id.device == 0x1107) > + return 0; > + my preference would to to break this out into a separate table-driven function so that if other devices have this issue they would just need to add to the table. reference ath11k_core_get_usecase_firmware() as a table-driven solution for a different device-specific problem (selects different firmware for specific compatibles). > for (i = 0; i < ab->num_radios; i++) { > ar = ab->pdevs[i].ar; > > > base-commit: 6474fa070f2b8013b4b87350b775b8c3be6e8aac > prerequisite-patch-id: aafe3fac38f4020441979665509928f8cc832095