From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 778AB3FB15 for ; Thu, 1 Feb 2024 22:08:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.97.179.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706825304; cv=none; b=qQAaVFBIG1FrGq52eo/SU0TS8sUh8kehxUDFOfYc64n2Ts87tMc60oBVNKsX84I+sPLocdQ4jn6deXUe/IDPSq+LImFyqXK6lbMkI+sQGImllUzFya+yzmLN6X5jfTutiZ93dAqj62g7QN2wjNcqWXGB5OgBJkdwsBctwJBBjuI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706825304; c=relaxed/simple; bh=6YAHG4MQf+rb00gsyySS7oIc38nKwQqCV7/QAXgkLzc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EZ6rP21VOjfwEGehQYnOTGveSKiDjJenamTJhiChare05FOk7VDcT0VfsM3N6qSn9PE+Nq6gVHpPCFP10XcHmLbA9W8cNsNdUAhKBVeUhxcez6yKeWhRnrcOdmivWMzCGi8y6iazWmRpFKe7goj9zI0C1dRMGtLJSze9E6/onFU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=igalia.com; spf=pass smtp.mailfrom=igalia.com; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b=qgd8L0pE; arc=none smtp.client-ip=213.97.179.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=igalia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=igalia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="qgd8L0pE" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=barmD5HdTQ3beqlmh4xJBK3WrVzCnDQhsfFyVRQ0csM=; b=qgd8L0pElYUnJq+8e4PUiPtatB fFgkpsMUKxNOKHewfE0BEt07yjnL+gotMk0zeTYMFejBuOMrv3IP7sdklBQzku22cZpDV3DjJbOl0 ayFRJZm6JjSwWUWcMr2M0oBwE4+CdYVghEr2sZ2pRc0UP/enfENscJ2O6Kae6T8ZNLamkwrkFlNDH AaV098dgwxs2yJ7Y4pIgAQR3AwKcvINpAen3CoH3CFQGmu6vpVvnDkovG6iDOCBEqqTur7exBEQLm ZaOI5K8d0zFLT9tuZQLDvHdALfEZ4swZ0W5hSqLLUVmXiZo2lh/uU8VwoPxpeM6dOMF6e1csPBgGv PgOV7GXA==; Received: from [179.234.233.159] (helo=[192.168.1.212]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1rVfDs-00CkLQ-4L; Thu, 01 Feb 2024 23:07:52 +0100 Message-ID: Date: Thu, 1 Feb 2024 19:07:43 -0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] Better support for complex pixel formats Content-Language: en-US To: Louis Chauvet , Rodrigo Siqueira , Melissa Wen , =?UTF-8?Q?Ma=C3=ADra_Canal?= , Haneen Mohammed , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , marcheu@google.com, seanpaul@google.com, nicolejadeyee@google.com Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, miquel.raynal@bootlin.com References: <20240201-yuv-v1-0-3ca376f27632@bootlin.com> From: Maira Canal Autocrypt: addr=mcanal@igalia.com; keydata= xjMEZIsaeRYJKwYBBAHaRw8BAQdAGU6aY8oojw61KS5rGGMrlcilFqR6p6ID45IZ6ovX0h3N H01haXJhIENhbmFsIDxtY2FuYWxAaWdhbGlhLmNvbT7CjwQTFggANxYhBDMCqFtIvFKVRJZQ hDSPnHLaGFVuBQJkixp5BQkFo5qAAhsDBAsJCAcFFQgJCgsFFgIDAQAACgkQNI+cctoYVW5u GAEAwpaC5rI3wD8zqETKwGVoXd6+AbmGfZuVD40xepy7z/8BAM5w95/oyPsHUqOsg/xUTlNp rlbhA+WWoaOXA3XgR+wCzjgEZIsaeRIKKwYBBAGXVQEFAQEHQGoOK0jgh0IorMAacx6WUUWb s3RLiJYWUU6iNrk5wWUbAwEIB8J+BBgWCAAmFiEEMwKoW0i8UpVEllCENI+cctoYVW4FAmSL GnkFCQWjmoACGwwACgkQNI+cctoYVW6cqwD/Q9R98msvkhgRvi18fzUPFDwwogn+F+gQJJ6o pwpgFkAA/R2zOfla3IT6G3SBoV5ucdpdCpnIXFpQLbmfHK7dXsAC In-Reply-To: <20240201-yuv-v1-0-3ca376f27632@bootlin.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Louis, Thanks for your patches! Could you please rebase them on top of drm-misc-next? It would make it easier for me to review and test the patches. Best Regards, - Maíra On 2/1/24 14:31, Louis Chauvet wrote: > This patchset aims to solve issues I found in [1], and at the same time > simplify the composition algorithm. > > I sent more igt-gpu-tools test [2] to cover more things and detect the > issues in [1]. > > This patchset is based on [1]. > > Patch 1/2: This patch is a no-op, but make the code more readable > regarding the pixel_read functions. > > Patch 2/2: This patch is more complex. My main target was to solve issues > I found in [1], but as it was very complex to do it "in place", I choose > to rework the composition function. > The main two advantages are: > - It's now possible to create conversion function for packed & grouped > pixels. Some pixel formats need absolute x/y position and not only an > offset in the buffer to extract the correct value. This part also solve > the issues I found in [1]. > - The rotation management is now way easier to understand, there is no > more switch case in different places and instead of copy/pasting rotation > formula I used drm_rect_* helpers. > > [1]: https://lore.kernel.org/dri-devel/20240110-vkms-yuv-v2-0-952fcaa5a193@riseup.net/ > [2]: https://lore.kernel.org/igt-dev/20240201-kms_tests-v1-0-bc34c5d28b3f@bootlin.com/T/#t > > Signed-off-by: Louis Chauvet > --- > Louis Chauvet (2): > drm/vkms: Create a type to check a function pointer validity > drm/vkms: Use a simpler composition function > > drivers/gpu/drm/vkms/vkms_composer.c | 97 ++++++++----- > drivers/gpu/drm/vkms/vkms_drv.h | 32 ++++- > drivers/gpu/drm/vkms/vkms_formats.c | 254 ++++++++++++++++++----------------- > drivers/gpu/drm/vkms/vkms_formats.h | 2 +- > drivers/gpu/drm/vkms/vkms_plane.c | 13 +- > 5 files changed, 236 insertions(+), 162 deletions(-) > --- > base-commit: 5d189d57bb335a87ec38ea26fe43a5f3ed31ced7 > change-id: 20240201-yuv-1337d90d9576 > > Best regards,