mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Henry Martin <bsdhenrymartin@gmail.com>, linux-ide@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
	Damien Le Moal <dlemoal@kernel.org>,
	Niklas Cassel <cassel@kernel.org>
Subject: Re: [PATCH] [ARM] pata_pxa: Fix null-ptr-deref in pxa_ata_probe()
Date: Thu, 3 Apr 2025 09:33:27 +0200	[thread overview]
Message-ID: <d795a7e3-1558-49c9-85c8-4139c7699304@web.de> (raw)
In-Reply-To: <20250403034520.59597-1-bsdhenrymartin@gmail.com>

…
> Add NULL check after devm_ioremap() to prevent this issue.

Can a summary phrase like “Prevent null pointer dereference in pxa_ata_probe()”
be a bit nicer?


…
> +++ b/drivers/ata/pata_pxa.c
> @@ -223,11 +223,16 @@ static int pxa_ata_probe(struct platform_device *pdev)
>
>  	ap->ioaddr.cmd_addr	= devm_ioremap(&pdev->dev, cmd_res->start,
>  						resource_size(cmd_res));
> +	if (!ap->ioaddr.cmd_addr)
> +		return -ENOMEM;

Can a blank line be desirable after such a statement?

Regards,
Markus

  reply	other threads:[~2025-04-03  7:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-03  3:45 [PATCH v1] " Henry Martin
2025-04-03  7:33 ` Markus Elfring [this message]
2025-04-04  3:58 ` Damien Le Moal
2025-04-04  4:07   ` Damien Le Moal
2025-04-04  6:14     ` [PATCH v2] ata: pata_pxa: Fix potential NULL pointer dereference " Henry Martin
2025-04-04  9:22       ` Markus Elfring
2025-04-08  3:43       ` Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d795a7e3-1558-49c9-85c8-4139c7699304@web.de \
    --to=markus.elfring@web.de \
    --cc=bsdhenrymartin@gmail.com \
    --cc=cassel@kernel.org \
    --cc=dlemoal@kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®