From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f49.google.com (mail-dl1-f49.google.com [74.125.82.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 856AE3DDDDE for ; Fri, 10 Apr 2026 15:28:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775834919; cv=none; b=bGiR1ElhAbAs6rWW93A/HAnFuZS7AvCCdmDBdGEVcKfhFm5vB9khuVWLEINpK0sdub68GXmT7QR9vyCNAvaSMLAQX1hWEc7vsLnEbUM08L6iLnutVzxK4fVxtYV9LDDrSV2kuQjdzYi7/mbzhpo+u3O5MnWg2VwAN1amoyg+oOs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775834919; c=relaxed/simple; bh=kbA7PR4neyNPM4QG9vJCntSEbumLjaB3stBsnOiOhns=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hTQcq2pFmTxGIXxHvLx7OyB1+d5ZwnEX1rkzlpDzHBsIEsbJSYyaWhNs4hfBbjerFwmjblup+sen0TPBTkrNTTyeGh6dDOPkN+RBhaIeB1ECknphwubXdGrTIG3VvWYFRacb6mw0ldY0QHYzRq1lBJRzMFvv6LF7O85Mijt53Xo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kV1bw3Ch; arc=none smtp.client-ip=74.125.82.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kV1bw3Ch" Received: by mail-dl1-f49.google.com with SMTP id a92af1059eb24-12c25b90264so182052c88.1 for ; Fri, 10 Apr 2026 08:28:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775834918; x=1776439718; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=JghhKcmcjJXB0Gwm3GfsIN1qKN146rmMPnlKpn3tqi4=; b=kV1bw3ChPORis8x0QDRmnt/DRlSQac54ogHkkeHALFQpHq1NzqKSdKW4/ylBLjEjhw PuGZw3uLSfG8/IVHu2T0N3Ph7056tMoJumt4EHEqtX8OE6+YcrMS12MXGM8kjoQ+w+qa uPvo87inS3JolWjz8GUOvyrIEXLQy88bV5ayqjS5yJmv2hfze/skL/m2yfcEPW+gT3zI OM1wV3O96qsUpovSR7d5dZKxl+cPoV++qZKFunUrrUq+ovgcmc60TZI6cEXm5WlQIjaq T+V2M05i+c6FAjZYB8NKPWZQJ9/CkoZGFKjb8sZ7wDcoVlrRTn+Co1BhZcE1UmfUQN7g kvvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775834918; x=1776439718; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=JghhKcmcjJXB0Gwm3GfsIN1qKN146rmMPnlKpn3tqi4=; b=SUds9Mt0DEuDpn2tcQyUnxA0Qt2bJKMSFD1HkFJPHhB1VYefJEvETWRmQQIGPSglYu zUTmaqhb/dsokrAgfy7Md4UzwTjtTozLUBsZhghR4di3pQHxzRmDGDJSgXXxgHaVTZ4E ZPAY+EnDRuo3KZIMSjXZib0YiD7RvBqj6/7WxTne2+ZAMjUqg1O90TatOOGxtAomjfOm DX0xCvMB8s/dMSlekG1l5JlSuoeeykiknmBH4EkRgNQD2aDf39ci9h+aFA+u4mjy3bPp ywgf1KWU/KjN6Ystpp6I7piZft8CTrrXHJ0pPZCTafVBwf+p17DD4muBc/53dp9YRofR eXsw== X-Forwarded-Encrypted: i=1; AJvYcCWSKFDkh/NbuWCk6oz3TxmniDWBbKzTrzz/47rGVMVf4Lwzcl4iu1y8an6Ax07ckSpHO+hQe1SOr73W8fI=@vger.kernel.org X-Gm-Message-State: AOJu0YyfjquipxsxIZ9r32dnImylLd+EaYRdJoKjLWadgaX4flUFxyUf 9E/2hsKdQxxM5RigmGNRUl1ijAyIDEGxVgmApQMl7LTBA+jFaSV7oozJ X-Gm-Gg: AeBDiessOebf0U6G/UONv9KWi2W11rsz/mLqAkIWjM82AG8nbmKC3cONTV+iK6ciIGj RMAba6X3EHqZG40HDzRaQc6+6/xkJiPm4HDPdhAM2gGLVsqat4tiAu2bOSm8thnDaIJxbQTSmkl yUys7C7DXGtCo/DqFLSnZ69RJqSKomTiPLWE/F+j0++VnYFKLq3FPglQaGXYuFnZeN5DEfBJ5SK PJPRWdcNR7hqD7FnzQSQXOSm6QOMYc7q30OcF1XjYe4grByzwN1MVXxFonXBKg0G6jsZjxFORig vZCOAkIbjV0MAedkwt85SgWuOns7Xxtmzq7BnXM1devOgtenO11BW6SbtHbxWxe6klrOAb5IS6M ajZFc+9/grM3bKMugX/u4d1yV3ot3lMS/UlMmjqIxkZJl51KeT5wHS4fsbzen+7dw4JH5Ag3IDB eKM78XbpJQTQeLFfaoSVyK6bQssAcR77izHIrm X-Received: by 2002:a05:7300:3721:b0:2cc:2125:9332 with SMTP id 5a478bee46e88-2d58a494b40mr2196877eec.27.1775834917647; Fri, 10 Apr 2026 08:28:37 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2d561bde717sm4713751eec.19.2026.04.10.08.28.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 08:28:37 -0700 (PDT) Sender: Guenter Roeck Date: Fri, 10 Apr 2026 08:28:36 -0700 From: Guenter Roeck To: "Pradhan, Sanman" Cc: "linux-hwmon@vger.kernel.org" , "linux@weissschuh.net" , "linux-kernel@vger.kernel.org" , Sanman Pradhan , "stable@vger.kernel.org" Subject: Re: [PATCH v4 1/2] hwmon: (powerz) Fix use-after-free on USB disconnect Message-ID: References: <20260410002521.422645-1-sanman.pradhan@hpe.com> <20260410002521.422645-2-sanman.pradhan@hpe.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260410002521.422645-2-sanman.pradhan@hpe.com> On Fri, Apr 10, 2026 at 12:25:35AM +0000, Pradhan, Sanman wrote: > From: Sanman Pradhan > > After powerz_disconnect() frees the URB and releases the mutex, a > subsequent powerz_read() call can acquire the mutex and call > powerz_read_data(), which dereferences the freed URB pointer. > > Fix by: > - Setting priv->urb to NULL in powerz_disconnect() so that > powerz_read_data() can detect the disconnected state. > - Adding a !priv->urb check at the start of powerz_read_data() > to return -ENODEV on a disconnected device. > - Moving usb_set_intfdata() before hwmon registration so the > disconnect handler can always find the priv pointer. > > Fixes: 4381a36abdf1c ("hwmon: add POWER-Z driver") > Cc: stable@vger.kernel.org > Signed-off-by: Sanman Pradhan Applied. Thanks, Guenter