From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67F121EB5CE for ; Wed, 1 Apr 2026 13:14:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775049265; cv=none; b=HGrvGV/KZ7+4oiqT8syrfboRUQAij396Ztk4lsVUW5RBhMWGWlM8tna1E/it6+LQBVrzBQtnBMeYNAHoC1gPE+xChoF4/vyoXP8JyXMizzTTqgmg/uEx1leYyObKuNy/r6Bg5dnk+kZvm2HhdaBri/jpTKnPuYbQRISJaMXRvzY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775049265; c=relaxed/simple; bh=BCZENMs6a5vD9T1aT6LQerKSPAdXq37z9HQLG+stpAg=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=WHkPpBJzL6Stjr+oG7h9K5hmy/k/a4B+gvhUpr14mXH/WYDZr9BMwtePXbnDdJlmRKW5JwUbqZIChMu2V8fDHIHURM1oBQ3i1XGKtWlTm5RG1mj/A/MvqYJhMUTcIHbO5omYKwSUYxODV7mx1BpsskAIZpifcRelEJeEnHn3FsU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=C5xmVHg6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="C5xmVHg6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B6BC4C4CEF7; Wed, 1 Apr 2026 13:14:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775049265; bh=BCZENMs6a5vD9T1aT6LQerKSPAdXq37z9HQLG+stpAg=; h=Date:From:Subject:To:Cc:References:In-Reply-To:From; b=C5xmVHg6urPkJg/sDmE+IlccoyC+IHEzEsebmiefEZaw1ZZHC5+9IDkQiKdTH3jAb FtMpdbg7DzmITyaNNVmGYHyfiL3rqJ0dOL22DkvuRSZbDHHnbIv+AVKcoeUdXzci2d DHTpAjASF5mmKC7ryH2Zkcc4tyZsBZO1+QQjZ0FwxRbwez36kqqAgBKghUr8wdiAaw tdxed6iCwwVAGeknHa7BXVphUtOFqXp9vrlwxczG0OyjgorqsL534m8GEn2U+uw4NX 2C7TqppUOXQXqnwE/5f+HGaEkS2n2vtzGzeQR2jLqBGRoYSJCw/baQkdGIgwFqd8AS B/jnCOZbbG4AQ== Message-ID: Date: Wed, 1 Apr 2026 08:14:22 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: "Mario Limonciello (AMD)" Subject: Re: [PATCH v6 5/5] x86/CPU/AMD: Print AGESA string from DMI additional information entry To: Borislav Petkov , Jean Delvare Cc: Yazen Ghannam , linux-kernel@vger.kernel.org References: <20260307141024.819807-1-superm1@kernel.org> <20260307141024.819807-6-superm1@kernel.org> <20260401111701.536cfda1@endymion> <20260401102908.GAaczzdHIc_G0neoyr@fat_crate.local> <20260401114504.GCac0FQP1Hl9hRi8PJ@fat_crate.local> Content-Language: en-US In-Reply-To: <20260401114504.GCac0FQP1Hl9hRi8PJ@fat_crate.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/1/26 06:45, Borislav Petkov wrote: > On Wed, Apr 01, 2026 at 12:29:08PM +0200, Borislav Petkov wrote: >> On Wed, Apr 01, 2026 at 11:17:01AM +0200, Jean Delvare wrote: >>> Isn't "V9" going to become "V10" at some point in the future, and then >>> the AGESA string will no longer be displayed until the code is >>> adjusted? Or will AMD move the information to a more appropriate place >>> by then? >>> >>> Also, I know this was discussed before, but the current print strategy >>> omits "V9". Is this not something we are going to regret once more >>> versions are available and we may have to differentiate between them? >> >> Right, I think we should not be silly and simply dump the string that starts >> with "AGESA" and that's it. > > IOW, this: > > if (!strncmp(string_ptr, "AGESA", 5)) { > pr_info("AGESA: %s\n", string_ptr); > break; > } > > Mario, what's that additional "dance" you're doing there? Do we have other > strings which start with "AGESA"? > Right we did talk about this a little on the last iteration too [1]. The string_ptr + 9 will fail if we ever had a V10. Link: https://lore.kernel.org/all/20260126154037.GBaXeK9bxgPMdE2lFr@fat_crate.local/ [1] If you guys would prefer to stick to the simple strncmp() + pr_info() the whole thing that's fine by me. Do you want me to send out a new patch series, or will you just adjust while committing?