From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751184AbdFFFDH (ORCPT ); Tue, 6 Jun 2017 01:03:07 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:54982 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750738AbdFFFDF (ORCPT ); Tue, 6 Jun 2017 01:03:05 -0400 Subject: Re: [PATCH] perf: fix perf test case 14 result reporting To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, linux390-list@tuxmaker.boeblingen.de.ibm.com References: <20170601123441.24581-1-tmricht@linux.vnet.ibm.com> <20170601132038.GG2899@kernel.org> <20170601210451.GA5713@krava> <20170602140936.GO2899@kernel.org> <20170602141105.GP2899@kernel.org> From: Thomas-Mich Richter Organization: IBM LTC Date: Tue, 6 Jun 2017 07:02:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <20170602141105.GP2899@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-IE Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 17060605-0012-0000-0000-000005450C2A X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17060605-0013-0000-0000-000018B3C828 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-06-06_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1706060090 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/02/2017 04:11 PM, Arnaldo Carvalho de Melo wrote: [....] >> >> If you have specific patches in Jiri's branch that you think are good to >> go, just point me to them and I'll cherry-pick them. >> >> I'm looking now at the one you pointed out above (070b9644981e). > > Just looked, but the cset comment should state what is the problem and > how it is solved, right now it has just a one line summary :-\ > > - Arnaldo > Looks like a misunderstanding. When I clone Jiri's tree and checkout branch perf/attr_test: url = git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git oc2666213455 12 $ git branch master * perf/attr_test perf/stat oc2666213455 13 $ git show 070b9644981e commit 070b9644981e2dd160a6aae2723d0ec2d8b4c0b5 Author: Jiri Olsa Date: Fri Mar 3 15:59:45 2017 +0100 perf tests attr: Do not store failed events diff --git a/tools/perf/tests/attr.c b/tools/perf/tests/attr.c index 0dd7749..0f2b619 100644 --- a/tools/perf/tests/attr.c +++ b/tools/perf/tests/attr.c @@ -138,7 +138,7 @@ void test_attr__open(struct perf_event_attr *attr, pid_t pid, int cpu, { int errno_saved = errno; - if (store_event(attr, pid, cpu, fd, group_fd, flags)) + if ((fd != -1) && store_event(attr, pid, cpu, fd, group_fd, flags)) die("test attr FAILED"); errno = errno_saved; oc2666213455 14 $ I get this commit which is another fix for an issue I discovered last week while working on test case 14. -- Thomas Richter, Dept 3303, IBM LTC Boeblingen Germany -- Vorsitzende des Aufsichtsrats: Martina Koederitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294