From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751169AbdAaPay (ORCPT ); Tue, 31 Jan 2017 10:30:54 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:40247 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750898AbdAaPas (ORCPT ); Tue, 31 Jan 2017 10:30:48 -0500 Subject: Re: [RFC V2 05/12] cpuset: Add cpuset_inc() inside cpuset_init() To: Vlastimil Babka , Mel Gorman , Anshuman Khandual References: <20170130033602.12275-1-khandual@linux.vnet.ibm.com> <20170130033602.12275-6-khandual@linux.vnet.ibm.com> <20170130203003.dm2ydoi3e6cbbwcj@suse.de> <8f442e1d-6c4d-990b-74e7-6d9a16c4576f@suse.cz> Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.com, minchan@kernel.org, aneesh.kumar@linux.vnet.ibm.com, bsingharora@gmail.com, srikar@linux.vnet.ibm.com, haren@linux.vnet.ibm.com, jglisse@redhat.com, dave.hansen@intel.com, dan.j.williams@intel.com From: Anshuman Khandual Date: Tue, 31 Jan 2017 21:00:33 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <8f442e1d-6c4d-990b-74e7-6d9a16c4576f@suse.cz> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17013115-0012-0000-0000-000003AE4247 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17013115-0013-0000-0000-00001B2F50A0 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-01-31_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1701310133 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/31/2017 08:06 PM, Vlastimil Babka wrote: > On 01/30/2017 09:30 PM, Mel Gorman wrote: >> On Mon, Jan 30, 2017 at 09:05:46AM +0530, Anshuman Khandual wrote: >>> Currently cpusets_enabled() wrongfully returns 0 even if we have a root >>> cpuset configured on the system. This got missed when jump level was >>> introduced in place of number_of_cpusets with the commit 664eeddeef65 >>> ("mm: page_alloc: use jump labels to avoid checking number_of_cpusets") >>> . This fixes the problem so that cpusets_enabled() returns positive even >>> for the root cpuset. >>> >>> Fixes: 664eeddeef65 ("mm: page_alloc: use jump labels to avoid") >>> Signed-off-by: Anshuman Khandual >> >> Superficially, this appears to always activate the cpuset_enabled >> branch() when it doesn't really make sense that the root cpuset be >> restricted. > > Yes that's why root cpuset doesn't "count", as it's not supposed to be > restricted (it's also documented in cpusets.txt) Thus the "Fixes:" tag > is very misleading. Agreed, I have removed the "Fixes: " tag in the proposed RFC already posted on this thread where it puts it as a new enablement instead and an addition to the capability what we already have with cpuset. It will be great if you can please take a look and provide feedback.