From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93547C47082 for ; Wed, 26 May 2021 12:36:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 60B8E610CC for ; Wed, 26 May 2021 12:36:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233563AbhEZMi1 (ORCPT ); Wed, 26 May 2021 08:38:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:47709 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233595AbhEZMiR (ORCPT ); Wed, 26 May 2021 08:38:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622032602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vo3CFjgMiVFpDxJLQuQQeOIXjZuz9Jnetz8hQXS67No=; b=Yy2iOPvOQPOuCUbADZ8BLSpoEZ1Ylrystpzutw1Uo21w8pb2cksBGqBEKTViFzJY02VbV9 L0wpJD5S4mDh9UiDSfyY0EJR8m5jc5od2nvETuqdaUrkFYMZtxxN721SWcBZwqqElpZLiF ELcONW10UgPJmYy1NhStOoxG2gVJYE4= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-537-M6ygiTvkPDCIrl1Q-pm_VQ-1; Wed, 26 May 2021 08:36:40 -0400 X-MC-Unique: M6ygiTvkPDCIrl1Q-pm_VQ-1 Received: by mail-ej1-f69.google.com with SMTP id sd18-20020a170906ce32b02903cedf584542so344163ejb.9 for ; Wed, 26 May 2021 05:36:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vo3CFjgMiVFpDxJLQuQQeOIXjZuz9Jnetz8hQXS67No=; b=uW2dN6DzEYkC1adk9psf+Rki7JJ2UlaBncAr9w0XurCjLg81fOb5S1hui3MDIjqydD nF+TqPjVxD9JYXcXBJJgnPd51zmwry+m0e0ACJTtY2txxVSUsS3sYd9NPE1zRCTP1t7S 7raxm79Qo29xSlkhscFt/NjKJdaBN5B94v6rxEj1Hehmm7ufoXS7B4+8wnMJF4hUWHQ9 JQD2xA5YL68NyJqpvlmYjfzzpud/aVzYX/OfemR4EMKsnKJid6Bu2HFfXesH3Kngg/SO jmwkmt/ZwSrTQSrz8R8yTmpkRBVgwuMHkXRj04UIgp2xqVbOdL/qRE68BslYkA24n/IU ZYhg== X-Gm-Message-State: AOAM533TAyB1RDlI4CumkcD0DoKFn6JtrBlhcIkZhc5OkspfF3brwjdq YJ6C+fKhObqL/r/QaKdUWjnzeNBxGU0nwQUkcM2cGhzUF0E2G20ESvd10juLNQUQQXTwheK8usb HHPZA21P0oaFnP2vgDn5Vn01h X-Received: by 2002:a17:906:351a:: with SMTP id r26mr2036977eja.389.1622032599355; Wed, 26 May 2021 05:36:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzCzSG2YLjcyhKgm8r3o/LZqPgFxUK6ylJOFe2YCzql+M/THNIC19JLVSjVDkUJ82LC9sNhuQ== X-Received: by 2002:a17:906:351a:: with SMTP id r26mr2036951eja.389.1622032599157; Wed, 26 May 2021 05:36:39 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c1e-bf00-1054-9d19-e0f0-8214.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1054:9d19:e0f0:8214]) by smtp.gmail.com with ESMTPSA id y15sm284014ejc.48.2021.05.26.05.36.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 May 2021 05:36:38 -0700 (PDT) Subject: Re: [PATCH v4 0/8] Introduce intel_skl_int3472 module To: Daniel Scally , "Rafael J . Wysocki" , Andy Shevchenko , Wolfram Sang , Lee Jones , Maximilian Luz , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, platform-driver-x86@vger.kernel.org, devel@acpica.org Cc: Len Brown , Mika Westerberg , Russell King , Linus Walleij , Bartosz Golaszewski , Mark Gross , Robert Moore , Erik Kaneda , laurent.pinchart@ideasonboard.com, kieran.bingham@ideasonboard.com References: <20210520140928.3252671-1-djrscally@gmail.com> From: Hans de Goede Message-ID: Date: Wed, 26 May 2021 14:36:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 5/26/21 1:03 AM, Daniel Scally wrote: >> 3/8 and 5/8 seem to be nice cleanups, but not really necessary. IMHO it >> would be best to park these cleanups for later and for 3/8 add the following >> where necessary for now: >> >> /* FIXME drop this once the I2C_DEV_NAME_FORMAT macro has been added to include/linux/i2c.h */ >> #ifndef I2C_DEV_NAME_FORMAT >> #define I2C_DEV_NAME_FORMAT "i2c-%s" >> #endif >> >> This is not the prettiest but it reduces all the subsys cross-deps and things >> like this have been done before for similar reasons. >> >> Likewise it would be good if you can add if (foo) as condition before any >> clkdev_drop(foo) calls in this patch-set and then merge >> 5/8 "clkdev: Make clkdev_drop() null aware" independently of this and then >> once both are in Linux tree follow-up with a cleanup patch dropping the if (foo) >> guards. > > > This is fine by me if people are happy for it to go in like that; I'll > just fix it up later. I don't expect anyone to object against these 2 small fixes going in later, if you can drop these 2 for v5 that would greatly help with untangling all the subsys dependencies. Then I can just merge an ACPI + a gpiolib-acpi immutable branch and then merge the big drivers/platform/x86 patch. Regards, Hans