From: Jinjie Ruan <ruanjinjie@huawei.com>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: <peterz@infradead.org>, <mingo@redhat.com>, <acme@kernel.org>,
<namhyung@kernel.org>, <mark.rutland@arm.com>,
<alexander.shishkin@linux.intel.com>, <jolsa@kernel.org>,
<irogers@google.com>, <adrian.hunter@intel.com>,
<kan.liang@linux.intel.com>, <will@kernel.org>, <arnd@arndb.de>,
<afd@ti.com>, <linus.walleij@linaro.org>,
<akpm@linux-foundation.org>, <masahiroy@kernel.org>,
<eric.devolder@oracle.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-perf-users@vger.kernel.org>
Subject: Re: [PATCH v2] ARM: stacktrace: Add USER_STACKTRACE support
Date: Mon, 12 Aug 2024 14:45:40 +0800 [thread overview]
Message-ID: <d7b9116e-bddc-2ab2-06eb-6191612fe16b@huawei.com> (raw)
In-Reply-To: <ZqzHgFB2t+SWy5o9@shell.armlinux.org.uk>
On 2024/8/2 19:48, Russell King (Oracle) wrote:
> On Tue, Jul 30, 2024 at 10:15:32AM +0800, Jinjie Ruan wrote:
>> Currently, userstacktrace is unsupported for ARM. So use the
>> perf_callchain_user() code as blueprint to implement the
>> arch_stack_walk_user() which add userstacktrace support on ARM.
>> Meanwhile, we can use arch_stack_walk_user() to simplify the implementation
>> of perf_callchain_user().
>>
>> A ftrace test case is shown as below:
>> # cd /sys/kernel/debug/tracing
>> # echo 1 > options/userstacktrace
>> # echo 1 > options/sym-userobj
>> # echo 1 > events/sched/sched_process_fork/enable
>> # cat trace
>>
>> ......
>> sh-100 [000] ..... 51.779261: sched_process_fork: comm=sh pid=100 child_comm=sh child_pid=108
>> sh-100 [000] ..... 51.779285: <user stack trace>
>> => /lib/libc.so.6[+0xb3c8c]
>> => /bin/busybox[+0xffb901f1]
>>
>> Also a simple perf test is ok as below:
>> # perf record -e cpu-clock --call-graph fp top
>> # perf report --call-graph
>>
>> .....
>> [[31m 65.00%[[m 0.00% top [kernel.kallsyms] [k] __ret_fast_syscall
>>
>> |
>> ---__ret_fast_syscall
>> |
>> |--[[31m30.00%[[m--__se_sys_getdents64
>> | iterate_dir
>> | |
>> | |--[[31m25.00%[[m--proc_pid_readdir
>>
>> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
>
> Do you have a use case for this feature?
To my knowledge, user stack trace is used in both uprobes and ftrace.
>
> Given that userspace is free to do whatever it likes with stack frames,
> I think this is going to be hit and miss whether it works.
To be honest, I referred to the implementation of ARM64. Does anyone
have suggestions for improvements or modifications?
>
next prev parent reply other threads:[~2024-08-12 6:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 2:15 Jinjie Ruan
2024-08-02 11:48 ` Russell King (Oracle)
2024-08-12 6:45 ` Jinjie Ruan [this message]
2024-08-12 15:02 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7b9116e-bddc-2ab2-06eb-6191612fe16b@huawei.com \
--to=ruanjinjie@huawei.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=afd@ti.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=arnd@arndb.de \
--cc=eric.devolder@oracle.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=masahiroy@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®