From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EDCFC77B6C for ; Thu, 6 Apr 2023 18:53:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240148AbjDFSxw (ORCPT ); Thu, 6 Apr 2023 14:53:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229806AbjDFSxu (ORCPT ); Thu, 6 Apr 2023 14:53:50 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79E2A6EB8 for ; Thu, 6 Apr 2023 11:53:49 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id jw24so3713557ejc.3 for ; Thu, 06 Apr 2023 11:53:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680807228; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=r086pEvAwnkI+t+FrbVlMKVk0z/S6f7zvSW+2dtrwjk=; b=CkFwoMdvVZqf1/VDlfvYyP7FST6Dy/l5+WHIRC4ybBECyATtAgRJyFd2IuegQtD5n7 53KTTRc7l4ed/hdK8v77cJY3rwW+cBr9kHD7EME5p0UqxX3aw747/Q5L4VjLGMUtBoSX tGRnhvt5h3GtpVjh+t53YXZnmIXF+XFCsItoF3swoTouTcc2rqORGGUrPb+sfXqBOSrV q5ntg8v7CatGIMS9w5mVcBVXmiNUhc45fisNfBLavEXzRYZRJYQLSKdNtRRnifht6lR+ ngdMaBklQCijCdLZepNl8nlrKMUI6MJEucMnCN9WWi5xp+vYU3QXcm2tvT6wRV15GkEL TF/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680807228; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=r086pEvAwnkI+t+FrbVlMKVk0z/S6f7zvSW+2dtrwjk=; b=pHpEIuROzF3JIPYgx5voRkz1UfERPkLK7LLshKkkz5cN2uA1Arzcdcdq8+eWF0ktoF TbBsx7CEufYsYLMNGTf0jILCOd+8FNlgcfTnuMdDXRhw3K2LwoQEIdLJFL4HJEfROMcw yTc1R5/K7smkp2//3YVmyNknvc83v7eHGP9LCQS46+mGH7+tdvdaQzZoPNN6VbPjUdhS E3w2SwlJcp+8Hs5v2CAXuJuS/3uZdUGxgkzIo4lc3KFYfO/Bbm8BZvsQBQ6UGboAsVBN S3dh5bFt+rFHVWYpf61QqUwtpS41TpuX4Cj+DeIorNqNQtbw2M8f1M4aL6fEdDJaQACe Ah6g== X-Gm-Message-State: AAQBX9fe2TuaLTMyvMUcJ+qMI3V/X+QfQ5ZyYGhrdDW44EBBrjTHJtjd 0EMum2R6KCo9jirNTOzjD31bEw== X-Google-Smtp-Source: AKy350YUb7fLNNac3a4lGLU5X3AMFtj1+tmZriv1BqVg6ictVe76XvECQJL7Ts5JSvVOWs7gJpvVPg== X-Received: by 2002:a17:907:8b0a:b0:949:ab5c:f10c with SMTP id sz10-20020a1709078b0a00b00949ab5cf10cmr3796432ejc.63.1680807228014; Thu, 06 Apr 2023 11:53:48 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:49e6:bb8c:a05b:c4ed? ([2a02:810d:15c0:828:49e6:bb8c:a05b:c4ed]) by smtp.gmail.com with ESMTPSA id hs19-20020a1709073e9300b00949cb8d6904sm1011575ejc.201.2023.04.06.11.53.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Apr 2023 11:53:47 -0700 (PDT) Message-ID: Date: Thu, 6 Apr 2023 20:53:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v1 1/3] dt-bindings: PCI: brcmstb: Add two optional props Content-Language: en-US To: Florian Fainelli , Jim Quinlan , Stefan Wahren Cc: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Phil Elwell , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com, Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Rob Herring , Krzysztof Kozlowski , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list References: <20230406124625.41325-1-jim2101024@gmail.com> <20230406124625.41325-2-jim2101024@gmail.com> <5c6d0259-0fe2-4faa-5ecf-8621467533a1@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <5c6d0259-0fe2-4faa-5ecf-8621467533a1@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/04/2023 20:47, Florian Fainelli wrote: >>>>> + >>>>> + brcm,completion-timeout-msecs: >>>>> + description: Number of msecs before completion timeout >>>>> + abort occurs. >>>>> + $ref: /schemas/types.yaml#/definitions/uint32 >>>> >>>> According to the driver at least 0 is not allowed, maybe we should >>>> define minimum and maximum here and let dtbs_check take care of invalid >>>> values? >>> I'm not sure I follow what you mean about a zero value; the property >>> may have any value but the driver will clamp it >>> to a minimum of ~30msec. Regardless, I can add a "minimum: 30" line >>> to the YAML. >> >> If "completion" means Linux completion, then it is not suitable for DT >> and entire property should be removed. If it is something else, then >> explain here and commit msg. So far both refer to some completion... > > This is a PCIe root complex binding so completion needs to be understood > in the context of PCIe, that is the time needed for the root complex to > complete/finish/proceed with a PCIe transaction layer packet (TLP). OK, so I assume keyword "completion" is well known term in PCI (although for some reason no other bindings mention it). Best regards, Krzysztof