mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Waqar Hameed <waqar.hameed@axis.com>,
	Konrad Dybcio <konradybcio@kernel.org>
Cc: "Peter Griffin" <peter.griffin@linaro.org>,
	"André Draszik" <andre.draszik@linaro.org>,
	"Tudor Ambarus" <tudor.ambarus@linaro.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Alim Akhtar" <alim.akhtar@samsung.com>,
	"Sam Protsenko" <semen.protsenko@linaro.org>,
	"Ivaylo Ivanov" <ivo.ivanov.ivanov1@gmail.com>,
	kernel@axis.com, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/16] arm64: dts: exynos: Format with dtfmt
Date: Thu, 1 Oct 2026 11:06:21 +0200	[thread overview]
Message-ID: <d7bef9eb-144d-4476-b6bd-d4b14ec1059c@kernel.org> (raw)
In-Reply-To: <pndy0chstai.a.out@axis.com>

On 01/10/2026 10:45, Waqar Hameed wrote:
> On Tue, Sep 29, 2026 at 07:43 +0200 Krzysztof Kozlowski <krzk@kernel.org> wrote:
> 
>> On 29/09/2026 00:38, Waqar Hameed wrote:
>>> I was looking through the notes for the last Devicetree microconference
>>> at Linux Plumbers (LPC) 2025 [1], and realized that the tool I have been
>>> working on might be of interest here: dtfmt - a Devicetree Source
>>> formatter [2].
>>>
>>> dtfmt uses a parser with lexical grammar (tree-sitter) directly ported
>>
>> We do not use dtfmt. 
> 
> Not sure what you mean here. We couldn't have used dtfmt since it didn't

I mixed it up with dt-tools from Axel.


> exist until I published it? Are you maybe referring to "formatters" as
> in general?
> 
> I'm not going to argue _why_ formatters (for Devicetree Source) are good
> thing to have, Konrad Dybcio did a very good job of that during his
> presentation [1].
> 
>> I think you missed entire recent work and recent
>> commits, where `git log` would point you.
>>
>> https://lore.kernel.org/all/20260911-b4-dts-samsung-cleanup-strict-continued-v1-0-9aa55051c42b@oss.qualcomm.com/
> 
> I did a `git pull` on `master` and started from there. Nevertheless,

master from Linus? That's missing entire development for this cycle. The
easiest is to work on recent linux-next.

> maybe it was good to "miss it" and do the "double work" here, to show
> what dtfmt caught that previous work missed.
> 
> Let me know if you want me to run it on `arch/arm/boot/dts/samsung` to
> show some more examples. Or even better, you could play with it yourself

Sure, I left arm/samsung for the community to deal with, just note that
Henrik Grimler mentioned in IRC he was working on that.

Best regards,
Krzysztof

      reply	other threads:[~2026-10-01  9:06 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-28 22:38 Waqar Hameed
2026-09-28 22:38 ` [PATCH 01/16] arm64: dts: exynos2200: Remove empty line at end of node Waqar Hameed
2026-09-29  5:43   ` Krzysztof Kozlowski
2026-09-28 22:38 ` [PATCH 02/16] arm64: dts: exynos5433: Use tabs for indentation Waqar Hameed
2026-09-28 22:38 ` [PATCH 03/16] arm64: dts: exynos7: Remove empty line at end of node Waqar Hameed
2026-09-28 22:38 ` [PATCH 04/16] arm64: dts: exynos7: Align comments with minimal whitespace Waqar Hameed
2026-09-28 22:38 ` [PATCH 05/16] arm64: dts: exynos7885: Fix format of line comment Waqar Hameed
2026-09-28 22:38 ` [PATCH 06/16] arm64: dts: exynos7885: Align end of node definition brace Waqar Hameed
2026-09-28 22:38 ` [PATCH 07/16] arm64: dts: exynos850: " Waqar Hameed
2026-09-28 22:38 ` [PATCH 08/16] arm64: dts: exynos850: Use tabs for indentation Waqar Hameed
2026-09-28 22:38 ` [PATCH 09/16] arm64: dts: exynos8850: Add missing space in compatible Waqar Hameed
2026-09-29  5:49   ` (subset) " Krzysztof Kozlowski
2026-09-28 22:38 ` [PATCH 10/16] arm64: dts: exynos8855: Remove empty line at end of node Waqar Hameed
2026-09-28 22:38 ` [PATCH 11/16] arm64: dts: exynos8855: Use tabs for indentation Waqar Hameed
2026-09-28 22:38 ` [PATCH 12/16] arm64: dts: exynosautov920: Add space before line comments Waqar Hameed
2026-09-28 22:38 ` [PATCH 13/16] arm64: dts: exynosautov920: Add missing space in compatible Waqar Hameed
2026-09-29  5:49   ` (subset) " Krzysztof Kozlowski
2026-09-28 22:38 ` [PATCH 14/16] arm64: dts: exynosautov920: Remove empty line at end of node Waqar Hameed
2026-09-28 22:38 ` [PATCH 15/16] arm64: dts: exynos: gs101: Use tabs for indentation Waqar Hameed
2026-09-28 22:38 ` [PATCH 16/16] arm64: dts: exynos: gs101: Add space before line comments Waqar Hameed
2026-09-29  5:43 ` [PATCH 00/16] arm64: dts: exynos: Format with dtfmt Krzysztof Kozlowski
2026-10-01  8:45   ` Waqar Hameed
2026-10-01  9:06     ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d7bef9eb-144d-4476-b6bd-d4b14ec1059c@kernel.org \
    --to=krzk@kernel.org \
    --cc=alim.akhtar@samsung.com \
    --cc=andre.draszik@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=ivo.ivanov.ivanov1@gmail.com \
    --cc=kernel@axis.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=peter.griffin@linaro.org \
    --cc=robh@kernel.org \
    --cc=semen.protsenko@linaro.org \
    --cc=tudor.ambarus@linaro.org \
    --cc=waqar.hameed@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®