From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752168AbcHFV2U (ORCPT ); Sat, 6 Aug 2016 17:28:20 -0400 Received: from hedera.naiandei.net ([91.240.84.8]:34552 "EHLO naiandei.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751297AbcHFV2S (ORCPT ); Sat, 6 Aug 2016 17:28:18 -0400 X-Greylist: delayed 4200 seconds by postgrey-1.27 at vger.kernel.org; Sat, 06 Aug 2016 17:28:17 EDT MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Sat, 06 Aug 2016 14:00:08 +0200 From: Oscar To: Peter Chen Cc: , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v4 0/6] power: add power sequence library In-Reply-To: <1470108652-16812-1-git-send-email-peter.chen@nxp.com> References: <1470108652-16812-1-git-send-email-peter.chen@nxp.com> Message-ID: User-Agent: Roundcube Webmail/0.8.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org El 2016-08-02 05:30, Peter Chen escribió: > Hi all, > > This is a follow-up for my last power sequence framework patch set > [1]. > According to Rob Herring and Ulf Hansson's comments[2], I use a > generic > power sequence library for parsing the power sequence elements on DT, > and implement generic power sequence on library. The host driver > can allocate power sequence instance, and calls pwrseq APIs > accordingly. > > In future, if there are special power sequence requirements, the > special > power sequence library can be created. > > This patch set is tested on i.mx6 sabresx evk using a dts change, I > use > two hot-plug devices to simulate this use case, the related binding > change is updated at patch [1/6], The udoo board changes were tested > using my last power sequence patch set.[3] > > Except for hard-wired MMC and USB devices, I find the USB ULPI PHY > also > need to power on itself before it can be found by ULPI bus. > > [1] http://www.spinics.net/lists/linux-usb/msg142755.html > [2] http://www.spinics.net/lists/linux-usb/msg143106.html > [3] http://www.spinics.net/lists/linux-usb/msg142815.html > > Changes for v4: > - Create the patch on next-20160722 > - Fix the of_node is not NULL after chipidea driver is unbinded > [Patch 5/6] > - Using more friendly wait method for reset gpio [Patch 2/6] > - Support multiple input clocks [Patch 2/6] > - Add Rob Herring's ack for DT changes > - Add Joshua Clayton's Tested-by > > Changes for v3: > - Delete "power-sequence" property at binding-doc, and change related > code > at both library and user code. > - Change binding-doc example node name with Rob's comments > - of_get_named_gpio_flags only gets the gpio, but without setting > gpio flags, > add additional code request gpio with proper gpio flags > - Add Philipp Zabel's Ack and MAINTAINER's entry > > Changes for v2: > - Delete "pwrseq" prefix and clock-names for properties at dt binding > - Should use structure not but its pointer for kzalloc > - Since chipidea core has no of_node, let core's of_node equals glue > layer's at core's probe > > Peter Chen (6): > binding-doc: power: pwrseq-generic: add binding doc for generic > power > sequence library > power: add power sequence library > binding-doc: usb: usb-device: add optional properties for power > sequence > usb: core: add power sequence handling for USB devices > usb: chipidea: let chipidea core device of_node equal's glue layer > device of_node > ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property > Hi Peter, I tried the last version on my udoo board but I got these compile errors: [21330s] ERROR: "pwrseq_get" [drivers/usb/core/usbcore.ko] undefined! [21330s] ERROR: "pwrseq_free" [drivers/usb/core/usbcore.ko] undefined! [21330s] ERROR: "pwrseq_put" [drivers/usb/core/usbcore.ko] undefined! [21330s] ERROR: "pwrseq_off" [drivers/usb/core/usbcore.ko] undefined! [21330s] ERROR: "pwrseq_on" [drivers/usb/core/usbcore.ko] undefined! Will you do another version? Thanks! -- Oscar