From: Oliver Neukum <oneukum@suse.com>
To: Andrew Lunn <andrew@lunn.ch>,
Franklin Lin <franklin_lin@wistron.corp-partner.google.com>
Cc: edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, davem@davemloft.net,
franklin_lin@wistron.com
Subject: Re: [PATCH] drivers/net/usb/r8152: Enable MAC address passthru support
Date: Tue, 28 Jun 2022 13:26:40 +0200 [thread overview]
Message-ID: <d7c3ce9f-d144-0083-162b-448570f2b5e5@suse.com> (raw)
In-Reply-To: <YrrVT33IZ1hMkhw2@lunn.ch>
On 28.06.22 12:17, Andrew Lunn wrote:
> On Tue, Jun 28, 2022 at 09:53:25AM +0800, Franklin Lin wrote:
>> From: franklin_lin <franklin_lin@wistron.corp-partner.google.com>
>>
>> Enable the support for providing a MAC address
>> for a dock to use based on the VPD values set in the platform.
>
> Maybe i'm missing it, but i don't see any code which verifies this
> r8152 is actually in the dock, and not a USB ethernet dongle plugged
> into some port of either the laptop or the dock itself.
And it will happily assign the same MAC to multiple devices.
I am afraid this patch needs some basic redesign.
Regards
Oliver
prev parent reply other threads:[~2022-06-28 11:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 1:53 Franklin Lin
2022-06-28 5:41 ` Greg KH
2022-06-28 5:42 ` Greg KH
2022-06-28 10:17 ` Andrew Lunn
2022-06-28 11:26 ` Oliver Neukum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7c3ce9f-d144-0083-162b-448570f2b5e5@suse.com \
--to=oneukum@suse.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=franklin_lin@wistron.com \
--cc=franklin_lin@wistron.corp-partner.google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®