From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBF80298CC4 for ; Thu, 12 Feb 2026 09:24:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770888244; cv=none; b=XTxsn+N/VI79M2vlajzWNQD1JmbtggA4k9OPMHHgQk5/X22KFgOyQIejcbpsjH8F+xhPSe5ambrXsMxARN0JT6o/a5jd+ySIZp4Q+dfXt5Rj9vkfHMmhm8E96ir0I4b9G5V9zY+CBdUuSIPdPyqA8KTyr6MnhZj5Wrn9ZwyZofQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770888244; c=relaxed/simple; bh=FNY/wXUFTDAUIoYt1SUyj6jU69X3UEtPaOl7Hq6tX3E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=u5dQJriHet63SYXMc05qk51vlVCtUkMmt8s5SNnSlffqL/XvVd1+Vd1GEEv3zcXbiXeu+u3R/uSGSrnRqI6I1PcOk6BQ0VFS3pZjvgxSi6dxrvmEqNND8AIGO7hgYrKFJ+ciZIWldzaq7twupdxt1ByGl9GAYk6Ugd0q5nATEwQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=evqxtkRy; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IaVBpGio; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="evqxtkRy"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IaVBpGio" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61C3RuDS3963785 for ; Thu, 12 Feb 2026 09:24:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jYQTdQ3eriXSnzd+Hz092D0hWf/uAteoJhiJrVldSDY=; b=evqxtkRydXiX2AV7 byV66pKayOc6TVexcUwade+SjBI+SLFsaNSCwwKMfgASWVVN+v2PUFyTBayU9ddI lQg/LzQQ17FfoE4NLadjtfWsrjxuVedDC9ML7zKPHr7F4+uKoFhoF7P0HiIzGP5N w9yEIpca19ENGG/5Jf+jJOExixPuxBZAemMtH96zd1Tp3nDSHBgnoAO7XEESLqAt 0L67vpBaDi//HIFEVTcmKqrxJyZD+SwS7kziY8aObKNS7YF4B4wI7SviSoL8oIov lmqBb3H/gFbqR4lcWbGA8P4hTx+HElnCMpPVvE2tMssaS4UKK0qKW87svE9F/il+ 4E69JQ== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c8y8ntdeu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Feb 2026 09:24:01 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-8954ab64c65so31956186d6.3 for ; Thu, 12 Feb 2026 01:24:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770888241; x=1771493041; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jYQTdQ3eriXSnzd+Hz092D0hWf/uAteoJhiJrVldSDY=; b=IaVBpGioZJq+jwl0U9amCK9YknTITLR6ZP38X0sS3hAIHs+kJDoQRBs7a/L1FolcxO J3g9qwOVAYAblMi4UjZDnOa4B1eea7XUc+sDIQDqUDL9rh4ldHvmEkfkUHLDVE6A5Fmj WEx6I/RVTfvbPHjDkfWM/ZdfGnZMzpudt6nvFvJjOzVHksWWZkUH2KxSOMjB2O0oV7zN 8/8EM8LCToknF5SAlHtl8umaePjCLESahHjv+0KuXO8qb3cOVh4N+ugITRlJBZjGbzaM eFwK6DgZkh2XbpIMv2ql+9pdaTx0VRFEGRg3HFuby0jjWit7RII+MOFcvvVX49zNGZxG cHEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770888241; x=1771493041; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jYQTdQ3eriXSnzd+Hz092D0hWf/uAteoJhiJrVldSDY=; b=wtRFdf/cO2TxPuDb5jfMEdT4tg7uiQl5q3aA8AUO/+5FKLL8LsKhnfxwBrDqs1sbyz 29LbxNdbl5BHgbRq720ieJxvSk4/tph/A9oiTUcXT8rjNhVg+QwKgR4Zm43IXaIQCS+/ ajC/t5OUbtc39NnoXZQHvxS3AZhXIqy9qZl33Atdz1x8RtPv6oiizCSh3e3gYsatc0Fr u6tSzbIsCVjVauUx3aptvGFKso884GKoFbeJONx6Auz19Ub07GGVliTrsP6+ujz7tXTA daIYQA7fQNWTg0S468C6O2rabvLHjHvUAPtL6DSN65PGMSFS7lpCaP6ZlS13oQ8joQKx ydQg== X-Forwarded-Encrypted: i=1; AJvYcCUVaJiU7EvSn6ge+enkQWBuQ4VFDAzeDYxd1W3y9bJkFGZhfkCbv6XT+P7sLYSym0G+JjvIPWu49C8/JvQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyQedriMW0pUBdTfbkkn4UOb5ZRVj5SS1PHKukoh+VCeTq2wjlr uHK0crGo9FTuzG9EFfERXnEyOENhCp/ZLb1gX0shfByL3QVscx70ddojAytLyEDbqEKOhO9i9xe vhuTPtM9K9rH2XrEyQaELkw7Fw1RiZFQYQjhXNPMFFQs7cr6Jx8avR3NMparC9cF9Lnc= X-Gm-Gg: AZuq6aJwO7sbgfFazZ9sr9yFaxRZ0gW3zJ8kYaceMIm5eQ1ykIwvEoIUivlOdfaZYT2 i7CQedFUq90W86RyIpfoc/PWSePcD6RvpaDR7yR4YVGAGbKF5J2xP1Amv0lx2iB93FSjdOR53HQ BkmidpjFiHx/8d/1tbQ5Aj3tQIyjzc3VAEgLiFVj3ZHccG6/QIrn7cAv/+9O5/5SmhTUqGuT9qu XxdxpBXtff0eltdsTYcFQ1wz+Nijkdf1AniJKoHQkQBVyczZg+hyWXT1CbHRCq7UmEVv2K1OD3+ S484G5zspNujQSSgpTwQmghMcWJTE2SIaoCaaB0kmSmuJhcJ7ijij/KrTw1upvtFjyt595KSx+8 kVFT/l94fCQ9xdMzXiWbre36nIGIIVagJ7A/IP1+gZRYbgUELHyGK7LFridMx3yJSonwyZfEIFS 01Fcw= X-Received: by 2002:a05:6214:6105:b0:896:f9ed:be98 with SMTP id 6a1803df08f44-89727999b22mr22927266d6.5.1770888240985; Thu, 12 Feb 2026 01:24:00 -0800 (PST) X-Received: by 2002:a05:6214:6105:b0:896:f9ed:be98 with SMTP id 6a1803df08f44-89727999b22mr22927126d6.5.1770888240531; Thu, 12 Feb 2026 01:24:00 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-65a3ced48dbsm1488000a12.15.2026.02.12.01.23.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Feb 2026 01:23:59 -0800 (PST) Message-ID: Date: Thu, 12 Feb 2026 10:23:57 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: Add vdda-refgen supply for Glymur To: Qiang Yu , Krzysztof Kozlowski Cc: Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260208-refgen-v1-0-87ca84fd78b3@oss.qualcomm.com> <20260208-refgen-v1-1-87ca84fd78b3@oss.qualcomm.com> <20260209-magic-conscious-seahorse-b81c8b@quoll> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjEyMDA2OCBTYWx0ZWRfX/Ofym9cxneM5 KpugvFrT2nwJTYo7hobGAzijOgla5eJqTbjpDg0bd/rYdrY0JbZBnb5Mi9D7+JkIgk5kP8lOCKQ B9POGKKcgj895NB4wVSnF3jNRVVw9TAXlXIeNKTrq5mkvQF4KA+7NgQpSShpMqTiYDs/viquGwh m7GWZpXo/D4iziQiDv7IUF5Ez9SElgah2B24IV9LY+4ukeWKVEvjk6xMGk5ZWP+wIHdwVSp6lxE G2Eq2m1TcVY1luNd4Qb6iwc1sUW4L1DGg9arxU2k14Jmy2oEpSrr0jvFtEpwnx3JhKF6Zeeslb+ oh2AzmaGNN4cj+G89rVcCypRPe5hGMgTJgKaJupQYRwksKOwN+liLHqyaF4klM1pbg0QUZeSKbM b5yFc5WdCDy5RFah762nkIVndg1y2DhBw+KcNG4i1GWCvUwJlCKLSOYGSloeb3+rqyZcb9uT0WC L7NZFi/lDNeFd7Mw2Xg== X-Authority-Analysis: v=2.4 cv=VNvQXtPX c=1 sm=1 tr=0 ts=698d9c31 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=4XAFBGz2Hh_vFV4knqAA:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-GUID: eWR2aC3dU0eifalbK5sD3dRRuA5KvEP8 X-Proofpoint-ORIG-GUID: eWR2aC3dU0eifalbK5sD3dRRuA5KvEP8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-12_02,2026-02-11_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 spamscore=0 suspectscore=0 adultscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602120068 On 2/12/26 4:32 AM, Qiang Yu wrote: > On Mon, Feb 09, 2026 at 09:06:23AM +0100, Krzysztof Kozlowski wrote: >> On Sun, Feb 08, 2026 at 08:49:39PM -0800, Qiang Yu wrote: >>> The PCIe QMP PHYs on Glymur require stable reference voltage provided by >>> refgen. The refgen itself requires two separate power supplies: >>> vdda-refgen0p9 and vdda-refgen1p2. >>> >>> Since there is no dedicated driver for REFGEN, add vdda-refgen0p9-supply >> >> How does the driver matter for the bindings? If I add dedicated driver >> for refgen, then I change the bindings? > > Yeah, I know that dt-bindings should describe hardware, not software. But > what I meant to say is that the refgen is different from qref which is > controlled via TCSR registers and its LDOs are requested to vote in > tcsrcc driver. The refgen doesn't required register setting and it doesn't > have dedicated driver, so we vote its LDOs in phy driver. I will avoid > this statement in next version. > >> >> There is qcom,sc8280xp-refgen-regulator so why there cannot be >> qcom,x1e-refgen-regulator? > > I think we can and it seems better because the refgen for pcie phy also > supplies reference voltage to other modules like usb. But I checked the > qcom-refgen-regulator.c, it contains some register settings and there is > no LDOs voting. I'm not sure what does those register do, maybe Konrad > can provide some backgroud. But on Glymur, we only need to vote LDOs. So > what if we use a fixed regulator in the device tree to represent refgen? > We could set refgen0p9 and refgen1p2 as its input supplies, then the PCIe > PHY would just need one refgen supply reference. That refgen on e.g. 8280 supplies display and camera PHYs. The latter have some sideband interface to request a vote directly (on all but some single old SoCs, IIUC), while the display ones need a manual vote. It would stand to reason that perhaps this MMIO-controlled regulator would have some sort of a voltage input.. so maybe that's the missing part in the story? I'm trying to find some answers but it's not easy.. Konrad