From: Krzysztof Kozlowski <krzk@kernel.org>
To: Aleksander Jan Bajkowski <olek2@wp.pl>,
ansuelsmth@gmail.com, herbert@gondor.apana.org.au,
davem@davemloft.net, matthias.bgg@gmail.com,
angelogioacchino.delregno@collabora.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, lorenzo@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-crypto@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: crypto: eip93: add clock gate and reset line
Date: Thu, 5 Mar 2026 21:00:39 +0100 [thread overview]
Message-ID: <d7c83ef5-c7f7-4401-9032-5a86844b6d82@kernel.org> (raw)
In-Reply-To: <20260305195903.59776-1-olek2@wp.pl>
On 05/03/2026 20:53, Aleksander Jan Bajkowski wrote:
> Add the clock gate and reset line, both of which are available
> on the Airoha AN7581. Both properties are mandatory.
Why are mandatory? We see that from the diff, you must explain WHY you
are doing things.
Also, that's ABI break without that explanation.
Best regards,
Krzysztof
prev parent reply other threads:[~2026-03-05 20:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 19:53 Aleksander Jan Bajkowski
2026-03-05 19:53 ` [PATCH v2 2/2] arm64: dts: airoha: en7581: add crypto offload support Aleksander Jan Bajkowski
2026-03-05 20:00 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7c83ef5-c7f7-4401-9032-5a86844b6d82@kernel.org \
--to=krzk@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=ansuelsmth@gmail.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lorenzo@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=olek2@wp.pl \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®