From: Kishon Vijay Abraham I <kishon@ti.com>
To: Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
<bhelgaas@google.com>, <lorenzo.pieralisi@arm.com>,
<Joao.Pinto@synopsys.com>, <jingoohan1@gmail.com>,
<adouglas@cadence.com>, <jesper.nilsson@axis.com>,
<shawn.lin@rock-chips.com>
Cc: <linux-pci@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v9 01/12] PCI: dwc: Fix EP link notification implementation
Date: Fri, 13 Jul 2018 13:17:57 +0530 [thread overview]
Message-ID: <d7ce93a5-0f35-4b8e-3744-d5fd319d8172@ti.com> (raw)
In-Reply-To: <3b43f37cc5fe654294c1ea696ed8df1797ad213b.1531155252.git.gustavo.pimentel@synopsys.com>
On Monday 09 July 2018 11:12 PM, Gustavo Pimentel wrote:
> Move specific features settings from EP shared code
> (pcie-designware-ep.c) to the driver (pcie-designware-plat.c).
>
> Previous implementation disables the EP link notification
> by default for all SoCs that uses EP DesignWare IP, which affects
> directly the dra7xx and artpec6 SoCs.
>
> Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> Change v8->v9:
> - Created patch file.
>
> drivers/pci/controller/dwc/pcie-designware-ep.c | 14 ++++++--------
> drivers/pci/controller/dwc/pcie-designware-plat.c | 3 +++
> 2 files changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c
> index 8650416..04092a7 100644
> --- a/drivers/pci/controller/dwc/pcie-designware-ep.c
> +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c
> @@ -386,15 +386,18 @@ int dw_pcie_ep_init(struct dw_pcie_ep *ep)
> return -ENOMEM;
> ep->outbound_addr = addr;
>
> - if (ep->ops->ep_init)
> - ep->ops->ep_init(ep);
> -
> epc = devm_pci_epc_create(dev, &epc_ops);
> if (IS_ERR(epc)) {
> dev_err(dev, "Failed to create epc device\n");
> return PTR_ERR(epc);
> }
>
> + ep->epc = epc;
> + epc_set_drvdata(epc, ep);
> +
> + if (ep->ops->ep_init)
> + ep->ops->ep_init(ep);
> +
> ret = of_property_read_u8(np, "max-functions", &epc->max_functions);
> if (ret < 0)
> epc->max_functions = 1;
> @@ -413,11 +416,6 @@ int dw_pcie_ep_init(struct dw_pcie_ep *ep)
> return -ENOMEM;
> }
>
> - epc->features = EPC_FEATURE_NO_LINKUP_NOTIFIER;
> - EPC_FEATURE_SET_BAR(epc->features, BAR_0);
> -
> - ep->epc = epc;
> - epc_set_drvdata(epc, ep);
> dw_pcie_setup(pci);
>
> return 0;
> diff --git a/drivers/pci/controller/dwc/pcie-designware-plat.c b/drivers/pci/controller/dwc/pcie-designware-plat.c
> index 5937fed..0ce3440 100644
> --- a/drivers/pci/controller/dwc/pcie-designware-plat.c
> +++ b/drivers/pci/controller/dwc/pcie-designware-plat.c
> @@ -70,10 +70,13 @@ static const struct dw_pcie_ops dw_pcie_ops = {
> static void dw_plat_pcie_ep_init(struct dw_pcie_ep *ep)
> {
> struct dw_pcie *pci = to_dw_pcie_from_ep(ep);
> + struct pci_epc *epc = ep->epc;
> enum pci_barno bar;
>
> for (bar = BAR_0; bar <= BAR_5; bar++)
> dw_pcie_ep_reset_bar(pci, bar);
> +
> + epc->features |= EPC_FEATURE_NO_LINKUP_NOTIFIER;
> }
>
> static int dw_plat_pcie_ep_raise_irq(struct dw_pcie_ep *ep, u8 func_no,
>
next prev parent reply other threads:[~2018-07-13 7:48 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 17:42 [PATCH v9 00/12] Add MSI-X support on pcitest tool Gustavo Pimentel
2018-07-09 17:42 ` [PATCH v9 01/12] PCI: dwc: Fix EP link notification implementation Gustavo Pimentel
2018-07-13 7:47 ` Kishon Vijay Abraham I [this message]
2018-07-09 17:42 ` [PATCH v9 02/12] PCI: endpoint: Add MSI-X interfaces Gustavo Pimentel
2018-07-09 17:42 ` [PATCH v9 03/12] PCI: Update xxx_pcie_ep_raise_irq() and pci_epc_raise_irq() signatures Gustavo Pimentel
2018-07-13 7:49 ` Kishon Vijay Abraham I
2018-07-09 17:42 ` [PATCH v9 04/12] PCI: dwc: Add MSI-X callbacks handler Gustavo Pimentel
2018-07-13 7:55 ` Kishon Vijay Abraham I
2018-07-13 15:55 ` Gustavo Pimentel
2018-07-09 17:42 ` [PATCH v9 05/12] PCI: dwc: Rework MSI " Gustavo Pimentel
2018-07-13 7:55 ` Kishon Vijay Abraham I
2018-07-09 17:42 ` [PATCH v9 06/12] PCI: dwc: Add legacy interrupt callback handler Gustavo Pimentel
2018-07-09 17:42 ` [PATCH v9 07/12] pci-epf-test/pci_endpoint_test: Cleanup PCI_ENDPOINT_TEST memspace Gustavo Pimentel
2018-07-13 7:59 ` Kishon Vijay Abraham I
2018-07-09 17:42 ` [PATCH v9 08/12] pci-epf-test/pci_endpoint_test: Use irq_type module parameter Gustavo Pimentel
2018-07-13 8:00 ` Kishon Vijay Abraham I
2018-07-09 17:42 ` [PATCH v9 09/12] pci-epf-test/pci_endpoint_test: Add MSI-X support Gustavo Pimentel
2018-07-13 8:08 ` Kishon Vijay Abraham I
2018-07-09 17:42 ` [PATCH v9 10/12] pci_endpoint_test: Add 2 ioctl commands Gustavo Pimentel
2018-07-10 10:10 ` Alan Douglas
2018-07-10 10:35 ` Gustavo Pimentel
2018-07-09 17:42 ` [PATCH v9 11/12] tools: PCI: Add MSI-X support Gustavo Pimentel
2018-07-09 17:42 ` [PATCH v9 12/12] PCI: endpoint: Add MSI set maximum restriction Gustavo Pimentel
2018-07-13 13:25 ` [PATCH v9 00/12] Add MSI-X support on pcitest tool Lorenzo Pieralisi
2018-07-13 15:59 ` Gustavo Pimentel
2018-07-16 4:07 ` Kishon Vijay Abraham I
2018-07-16 14:49 ` Gustavo Pimentel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7ce93a5-0f35-4b8e-3744-d5fd319d8172@ti.com \
--to=kishon@ti.com \
--cc=Joao.Pinto@synopsys.com \
--cc=adouglas@cadence.com \
--cc=bhelgaas@google.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jesper.nilsson@axis.com \
--cc=jingoohan1@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®