From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BF4315746A for ; Wed, 19 Jun 2024 18:20:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718821227; cv=none; b=BS+OPnaz/T9LAT+2XECbl592F265RR3SONe2hFDSq8713DgzGDuZ9pP5YEF0sdt+T1tDf8quyOdIwF5gJPkNeFLDeq0zKfqMrqFzXoeTp98f/H4PlWAPUxgUTOwES1iylhLucye2NI8CRX+U2Gsv4jNRqGRASnrX3NlaZYUjUOU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718821227; c=relaxed/simple; bh=RlFcuST3MTYw2HhcrIt93bRlktGhL2E9Pa+qAshb+Vc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nrwVyrfEIUlW/udS97L8lA1Zh3ldV5lS77Dww3ayR24MurDE6lFUyZ89PAvdJrHMtpiyq7Z1XydfWlgR/pk5+MlZyoP0gXgL3+BASBLCZU9IvAQ9quTLM93juzmn0BJ837j2LRvDFXQGBJEh20PDOouqoQJ5c16+KlUJSpE5FQk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=UyQVV3m/; arc=none smtp.client-ip=209.85.210.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="UyQVV3m/" Received: by mail-ot1-f42.google.com with SMTP id 46e09a7af769-6f8d0a00a35so42475a34.2 for ; Wed, 19 Jun 2024 11:20:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1718821223; x=1719426023; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EEAmDmdxj2IHWsPzPWl7VVZMI4gsZPCFHp3nAK0/dQs=; b=UyQVV3m/1fcKRjM21ZcHn17RogJM5/UU8Ea41Dgb8Z2wPL36J+rQ3smwnAANQVngOL dIXUI9AqDZAVF27NXLZE090YmRLAl2zH+LyLfxTJ2C3q7Te2vnz5vjkXPOV+7S31mUUX O1dpq7GiY2HgP8lzXFAALVPPD73tZtTkgY5BAbwpuROpk0x3ba+KzfTKTy9TeTFK6sbn W3XbJBYFSqB58DNN3udAyE0yV4lg9ZOksvA6mxqzXwe6MQZD9UqrQn+mm5UVMMif+U8X X7aa+xywMwYn9+CUyl62VsVQSWpobAhj0hEC+2wminpvxpsRO4U4vbluN16wp82AM/kF eZzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718821223; x=1719426023; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EEAmDmdxj2IHWsPzPWl7VVZMI4gsZPCFHp3nAK0/dQs=; b=q2zXduSyKsLvkuN/novS1W1KIbRtbg3Fj/4zK1KUMZFlfzD5Kmi0VZM4ptct5Y1dlX e0PtS5eBKhmrV/z6ho/3xPtlmda9IZIIPGQIDdlAZqDcKriQFcBJpd6nofrwr/oMLKyt L40z55fUoWlkUdwupS68DvUh5yBJm394ieKnogWS8BCkMYtiuYRuxf08R4b6YPLdP2RJ /ubdX8emkeo2Jbz8jtkTSHrATmHBja2XOUpN7Mey03W7zVCuK4r54bcpRhpBxZZxdC01 Q+NzWgnDNYprBK0K+4E+hk7cbOmgWm3UfofIkCTPZduzgqflKLclfAfXRfeBCW6Cbnh3 F4ZA== X-Forwarded-Encrypted: i=1; AJvYcCWK9apcCHvS75oKRs62d2hwY45v9mn3atAn9L4yjCUO3zdP1Uu50tdKVKtcQUvWc0SGRuholVJaaaAeYwb68ktPdiS6QJlbXPjeuIXX X-Gm-Message-State: AOJu0YxYLQ9klA8KqkzmrbPRIf7DrvtkUkm5f+YkAdc8bsp6Kb4T5mN8 sD3HMl8BQnZcohVrkgOLv3wWejiVYQMAMx+KcsFmi5qylbedxKRmyoAXq+xTUKM= X-Google-Smtp-Source: AGHT+IE46EgTLGf5oN4IQLbetpDLGBop9HxlMQVzbGsKy4Pf+gc303cZxbeI8m5oLWrSKPVR+6EHzg== X-Received: by 2002:a05:6870:6494:b0:254:997e:ea4d with SMTP id 586e51a60fabf-25c94910162mr3750542fac.10.1718821223499; Wed, 19 Jun 2024 11:20:23 -0700 (PDT) Received: from [192.168.0.142] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2569930f768sm3826912fac.41.2024.06.19.11.20.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Jun 2024 11:20:23 -0700 (PDT) Message-ID: Date: Wed, 19 Jun 2024 13:20:22 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 4/6] spi: spi-axi-spi-engine: Add support for MOSI idle configuration To: Marcelo Schmitt Cc: Marcelo Schmitt , broonie@kernel.org, lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, nuno.sa@analog.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org References: <6f945701-cac0-4a56-9ca7-1daceccc5efd@baylibre.com> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/19/24 12:27 PM, Marcelo Schmitt wrote: > On 06/19, David Lechner wrote: >> On 6/18/24 6:11 PM, Marcelo Schmitt wrote: >>> @@ -646,6 +651,9 @@ static int spi_engine_probe(struct platform_device *pdev) >>> >>> host->dev.of_node = pdev->dev.of_node; >>> host->mode_bits = SPI_CPOL | SPI_CPHA | SPI_3WIRE; >>> + if (ADI_AXI_PCORE_VER_MAJOR(version) >= 1 && >> >> Currently, the major version is required to be 1, so this check is not >> strictly needed. >> > This is expecting the MOSI idle feature to be available on all versions from 1.3 on. > Will SPI-Engine always be major version 1? Difficult to see, the future is. It's fine if you want to leave it the way it is. > >>> + ADI_AXI_PCORE_VER_MINOR(version) >= 3) >>> + host->mode_bits |= SPI_MOSI_IDLE_LOW | SPI_MOSI_IDLE_HIGH; >>