From: Andrew Lunn <andrew@lunn.ch>
To: Rosen Penev <rosenp@gmail.com>
Cc: netdev@vger.kernel.org, Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] net: phy: marvell: wake the system only from the WoL event
Date: Mon, 14 Sep 2026 15:02:05 +0200 [thread overview]
Message-ID: <d7d3a464-ebd2-4917-9c84-707aaf28f8b2@lunn.ch> (raw)
In-Reply-To: <20260912235125.151370-1-rosenp@gmail.com>
> +static int marvell_wol_suspend_intrs(struct phy_device *phydev)
> +{
> + int oldpage, ret;
> +
> + oldpage = phy_save_page(phydev);
> + if (oldpage < 0)
> + return oldpage;
> +
> + ret = marvell_write_page(phydev, MII_MARVELL_COPPER_PAGE);
> + if (ret < 0)
> + goto out;
> +
> + ret = __phy_write(phydev, MII_88E1318S_PHY_CSIER,
> + MII_88E1318S_PHY_CSIER_WOL_EIE);
> +out:
> + return phy_restore_page(phydev, oldpage, ret);
What is all the oldpage code for?
Andrew
prev parent reply other threads:[~2026-09-14 13:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-12 23:51 Rosen Penev
2026-09-13 6:56 ` Maxime Chevallier
2026-09-14 0:40 ` netdev-bot+sashiko
2026-09-14 13:02 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7d3a464-ebd2-4917-9c84-707aaf28f8b2@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®