From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B69DD1635B6 for ; Tue, 7 May 2024 15:09:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715094576; cv=none; b=OsW7rloqYU4lDxtijqgrcvRFn1F+jbOSsTHorEIvpUkuOkHnASHhdsPg0jJnqyOh6jvx4U4vFWpCG6D8ZCaJbiM6sSyhkLetQDcRORe7gtLD9MOqsx4ceh+rQUv59nArZhXmIDnS/eanltfNTkKw4fVZKOY11XzPFpEa2ZLGayA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715094576; c=relaxed/simple; bh=eQZdBa//GiiwWU5saLscyQ/eNFxlEase1Y9Rz4G07L0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=i1kHPp5EQ/nFDzBgrE1i0l5FYxlf0Qwq0mhIRHvVIHzsS9QP5yGBiTqD145rulU2Cl40PGa8b04LuTEOJlgF11TLNXoSNFIWs4Bn6DSELsUccWwmmm0rrTdnmk+aDbkqPMJK8jj9AyIRke9LrqhbqLoS/IKBaqLohuxYQP48PPg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=sv8TdImZ; arc=none smtp.client-ip=209.85.166.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="sv8TdImZ" Received: by mail-io1-f45.google.com with SMTP id ca18e2360f4ac-7decabf4a36so22483039f.0 for ; Tue, 07 May 2024 08:09:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1715094572; x=1715699372; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=E3D/yzAnQonQm6YpOqNskMzHHJ7JMLgQ77zwyP/bNEI=; b=sv8TdImZqS6aZsCrKHrNTlU7Fe+I6yid9cgMoyhGjULwNIrBIa3xpBG3I872GA88Qt WthjiA9yRZ5G7cIQ0PI7Z3EEsIjYR+HHRe1MCYTB7eFOhxrEy+L720ggO27rJ5PdU6Uo LFsHRA2Cn9D3U9XLCZUFoKAxSw4Cg9arTbVyy5+EaBrO/WUd8RjfqaLzcJogT5X+GBcq X2kGH9/8FKXl/2tAwQEr7EhvgdBJY+iV3nPiEbnNQYGNzF0opdz9NMaYwd0ELtsV+6Fw bljQ/wRGHsS9bGllkPlgKhDwjgR5UmaKCe/cwM6TLNE+ip8u0TxK50Q89KOKBDX+heDE l1Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715094572; x=1715699372; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=E3D/yzAnQonQm6YpOqNskMzHHJ7JMLgQ77zwyP/bNEI=; b=CUPRSELVrTzNReo0OgRXJoCzq0YUDa5h0I44NBX9FNQ3b/XbuhwrIJDwvIJoY19qr9 nsiDl5QbXG0Ts6N2TsyKG2OJqOGpNS0t5kNC9YMBRjEO6NKNH61cdKWxbjsvTX7Vtkt+ ZVZVczCLQwyfAhcnsYIrBJs9pl5ofNzAzpv5yc9RCklyHirgkZX6EZvNGR576SpcbnZB z7s4JcJljA+Nei143ipSgDCOkg/Y6G5D6q3ThXVxkDfK8KbJOBEfN9ker1+Q/CDx9ZjV kYxUtXKfstePMGGU99F5cuER6cePwP6QkGqSWVj0baN4jCchJrXaK5BGhgfPXiBk7nCq BfzQ== X-Forwarded-Encrypted: i=1; AJvYcCWwz3gqLvPmv/Pw0ahhdn/ILvOUUC+HVYcz6qszMNRiiglsLXE+7RGgQfSaMEbWDqTv0Bw6ptHfloOH5I6U4TV3Lo4AXDuRnph2Le+0 X-Gm-Message-State: AOJu0YwRZcsc6z7WvinTJgK86QgzEl4rhRIDmovBCP2yIl7K0AMEWBLC axQOK9epSs0H61mWg5ofeuig4M5VP7rFn2RKmwcMVeqwc3iwKF13/pwXKXvAKJQ= X-Google-Smtp-Source: AGHT+IH/xpJNOj9b9GueLYwJ09ytVaIiUnOPLZsziqVJEzXxE/krpfrw37GQ1qd29ae0cQaKRTT7Tw== X-Received: by 2002:a05:6602:3f48:b0:7e1:8bc8:8228 with SMTP id en8-20020a0566023f4800b007e18bc88228mr963919iob.0.1715094571886; Tue, 07 May 2024 08:09:31 -0700 (PDT) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id r20-20020a056638131400b00488609cd945sm1915683jad.20.2024.05.07.08.09.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 May 2024 08:09:31 -0700 (PDT) Message-ID: Date: Tue, 7 May 2024 09:09:30 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] io_uring/io-wq: Use set_bit() and test_bit() at worker->flags To: Breno Leitao , Pavel Begunkov Cc: christophe.jaillet@wanadoo.fr, "open list:IO_URING" , open list References: <20240507150506.1748059-1-leitao@debian.org> Content-Language: en-US From: Jens Axboe In-Reply-To: <20240507150506.1748059-1-leitao@debian.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/7/24 9:05 AM, Breno Leitao wrote: > @@ -631,7 +631,7 @@ static int io_wq_worker(void *data) > bool exit_mask = false, last_timeout = false; > char buf[TASK_COMM_LEN]; > > - worker->flags |= (IO_WORKER_F_UP | IO_WORKER_F_RUNNING); > + set_mask_bits(&worker->flags, 0, IO_WORKER_F_UP | IO_WORKER_F_RUNNING); This takes a mask, no? I think this should be: set_mask_bits(&worker->flags, 0, BIT(IO_WORKER_F_UP) | BIT(IO_WORKER_F_RUNNING); Hmm? -- Jens Axboe