From: "André Draszik" <andre.draszik@linaro.org>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Peter Griffin <peter.griffin@linaro.org>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>
Cc: Will McVicker <willmcvicker@google.com>,
kernel-team@android.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v2 3/3] arm64: dts: exynos: gs101-raven: add new board file
Date: Mon, 23 Dec 2024 10:42:09 +0000 [thread overview]
Message-ID: <d7dd7286c90ecf43594fd1d44975254479270539.camel@linaro.org> (raw)
In-Reply-To: <dbeb28be-1aac-400b-87c1-9764aca3a799@kernel.org>
On Sun, 2024-12-22 at 12:43 +0100, Krzysztof Kozlowski wrote:
> On 20/12/2024 12:27, André Draszik wrote:
> > Raven is Google's code name for Pixel 6 Pro. Similar to Pixel 6
> > (Oriole), this is also based around its Tensor gs101 SoC.
> >
> > For now, the relevant difference here is the display resolution:
> > 1440 x 3120 instead of 1080 x 2400.
> >
> > Create a new board file to reflect this difference.
>
> There is no board file here, I see only overlay.
>
> >
> > Signed-off-by: André Draszik <andre.draszik@linaro.org>
> >
> > ---
> > Note: MAINTAINERS doesn't need updating, it covers this whole directory
> > ---
> > arch/arm64/boot/dts/exynos/google/Makefile | 3 ++
> > arch/arm64/boot/dts/exynos/google/gs101-raven.dtso | 33 ++++++++++++++++++++++
>
> Nope, boards are not overlays. Boards are DTB.
Several other boards are using this approach, e.g. in
arch/arm64/boot/dts/freescale/ and arch/arm64/boot/dts/xilinx/ and
arch/arm/boot/dts/ti/omap/
Can you please explain why this here can not use this approach?
Cheers,
Andre'
next prev parent reply other threads:[~2024-12-23 10:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-20 11:27 [PATCH v2 0/3] Google Pixel 6 Pro support André Draszik
2024-12-20 11:27 ` [PATCH v2 1/3] dt-bindings: arm: google: add gs101-raven and generic gs101-pixel André Draszik
2024-12-22 11:38 ` Krzysztof Kozlowski
2024-12-23 7:45 ` André Draszik
2024-12-23 14:14 ` Krzysztof Kozlowski
2024-12-23 15:31 ` André Draszik
2024-12-23 15:39 ` Krzysztof Kozlowski
2024-12-23 15:54 ` André Draszik
2024-12-23 15:58 ` Krzysztof Kozlowski
2024-12-20 11:27 ` [PATCH v2 2/3] arm64: dts: exynos: gs101-pixel: add generic gs101-based Pixel support André Draszik
2024-12-22 11:42 ` Krzysztof Kozlowski
2024-12-23 7:59 ` André Draszik
2024-12-23 14:18 ` Krzysztof Kozlowski
2024-12-20 11:27 ` [PATCH v2 3/3] arm64: dts: exynos: gs101-raven: add new board file André Draszik
2024-12-22 11:43 ` Krzysztof Kozlowski
2024-12-23 10:42 ` André Draszik [this message]
2024-12-20 14:42 ` [PATCH v2 0/3] Google Pixel 6 Pro support André Draszik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7dd7286c90ecf43594fd1d44975254479270539.camel@linaro.org \
--to=andre.draszik@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel-team@android.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®