From: Ian Abbott <abbotti@mev.co.uk>
To: Hartley Sweeten <HartleyS@visionengravers.com>,
Piotr Gregor <piotrgregor@rsyncme.org>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers: staging: comedi: fix function prototypes
Date: Thu, 15 Dec 2016 11:46:31 +0000 [thread overview]
Message-ID: <d7dfd1d0-38ec-afd3-aa6e-bdf230efc342@mev.co.uk> (raw)
In-Reply-To: <SN1PR0101MB15654D89B904B4955F621DA5D09A0@SN1PR0101MB1565.prod.exchangelabs.com>
On 14/12/16 16:14, Hartley Sweeten wrote:
> On December 14, 2016 6:42 AM, Piotr Gregor wrote:
>> Add names of parameters to function prototypes in comedi PCI.
>> Checkpatch reports now no errors.
>>
>> Signed-off-by: Piotr Gregor <piotrgregor@rsyncme.org>
>> ---
>> drivers/staging/comedi/comedi_pci.h | 18 ++++++++++--------
>> 1 file changed, 10 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/staging/comedi/comedi_pci.h b/drivers/staging/comedi/comedi_pci.h
>> index 4005cc9..7dfd892 100644
>> --- a/drivers/staging/comedi/comedi_pci.h
>> +++ b/drivers/staging/comedi/comedi_pci.h
>> @@ -34,18 +34,20 @@
>> #define PCI_VENDOR_ID_RTD 0x1435
>> #define PCI_VENDOR_ID_HUMUSOFT 0x186c
>>
>> -struct pci_dev *comedi_to_pci_dev(struct comedi_device *);
>> +struct pci_dev *comedi_to_pci_dev(struct comedi_device *dev);
>
> For the function prototypes I prefer no names for the "pointer" parameters.
>
> The "struct foo *" declaration is just as clear as "struct foo *bar".
Maybe, but checkpatch.pl doesn't agree (not since commit
ca0d8929e75ab1f860f61208d46955f280a1b05e anyway)!
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
next prev parent reply other threads:[~2016-12-15 12:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-14 13:42 Piotr Gregor
2016-12-14 16:14 ` Hartley Sweeten
2016-12-15 11:46 ` Ian Abbott [this message]
2016-12-15 16:12 ` Hartley Sweeten
2016-12-15 11:44 ` Ian Abbott
2016-12-15 17:36 ` Hartley Sweeten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7dfd1d0-38ec-afd3-aa6e-bdf230efc342@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=HartleyS@visionengravers.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=piotrgregor@rsyncme.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®